[HOLD for payment 2024-10-11] [$250] Invoicing verify that the user has the feature enabled on the page

[rezkiy37]

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

To wrap WorkspacePageWithSections with AccessOrNotFoundWrapper to avoid giving access of the Invoice page to the user where areInvoicesEnabled is false.

Manual Test Steps

Automated Tests

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839691254986841972
• Upwork Job ID: 1839691254986841972
• Last Price Increase: 2024-09-27

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839691254986841972

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[Pujan92]

Not sure whether I need to review this PR or not as it has been noticed here while reviewing other PR.

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

To wrap WorkspacePageWithSections with AccessOrNotFoundWrapper to avoid giving access of the Invoice page to the user where areInvoicesEnabled is false.

What is the root cause of that problem?

• On WorkspaceInvoicesPage - WorkspacePageWithSections is not wrapped with AccessOrNotFoundWrapper.

What changes do you think we should make in order to solve the problem?

• On WorkspaceInvoicesPage - wrap WorkspacePageWithSections with AccessOrNotFoundWrapper.

        <AccessOrNotFoundWrapper
            accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
            policyID={route.params.policyID}
            featureName={CONST.POLICY.MORE_FEATURES.ARE_INVOICES_ENABLED}
        >
            <WorkspacePageWithSections
                ...
            </WorkspacePageWithSections>
        </AccessOrNotFoundWrapper>

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[rezkiy37]

@ChavdaSachin, I've already started to work on the issue - #49842 (comment). Moreover, I have a draft PR (#49843). Going to open it soon 🙂

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Invoicing verify that the user has the feature enabled on the page  #49843

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rayane-djouah]

BugZero Checklist

• The PR that introduced the bug has been identified. Link to the PR: Invoicing bank accounts section #47218
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: The author and reviewers are aware
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Create an account
2. Create a workspace
3. Go to workspace settings > more features
4. Disable the invoices feature.
5. Verify that you cannot access the invoices page.
6. Enable the invoices feature.
7. Verify that you can access the invoices page.

Do we agree 👍 or 👎

[twisterdotcom]

Payment Summary:

• @rezkiy37 does not require payment (Contractor)
• @rayane-djouah paid $250 here (Reviewer)

[rayane-djouah]

@twisterdotcom - Offer accepted