-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoicing bank accounts section #47218
Invoicing bank accounts section #47218
Conversation
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
…ture/45177-invoice-back-accounts-section
Reviewer Checklist
Screenshots/VideosAndroid: NativeMacOS: Chrome / SafariScreen.Recording.2024-09-27.at.15.54.09.mov |
…e/45177-invoice-back-accounts-section' and 'main' of https://github.com/rezkiy37/Expensify into feature/45177-invoice-back-accounts-section
As we are not showing the invoices option in the LHN yet, in the test steps we can add to open invoices page directly in URL
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of small comments
…ture/45177-invoice-back-accounts-section
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.42-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀
|
Details
The PR introduces the invoice bank accounts section.
Fixed Issues
$ #45177
PROPOSAL: N/A
Tests
When no bank accounts
When bank accounts are present
Offline tests
QA Steps
Same as "Tests".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.mp4
Android: mWeb Chrome
Android.Chrome.mp4
iOS: Native
IOS.mp4
iOS: mWeb Safari
IOS.Safari.mp4
MacOS: Chrome / Safari
Chrome.mp4
MacOS: Desktop
Desktop.mp4