[HOLD for payment 2024-11-28] IOU - Web - Console error when selecting pay with Business bank account as recipient

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.44.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #50052

Action Performed:

1. Go to https://staging.new.expensify.com/
   and log in as user A
2. Submit an expense in USD to user B who does not have an expensify account yet
3. Navigate to the email box and click on the magic link inviting user B to pay the expense
4. Select Pay with Expensify > Business bank account on the IOU preview

Expected Result:

There are no console errors

Actual Result:

There is a console error after selecting Pay with Expensify > Business bank account. It also happens if Pay elsewhere is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6623320_1727967879848.Recording__835.mp4

logs (2).txt

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[cdOut]

Hi, this was caused by my guided setup PR and is very similar to the previously solved bug here, I think just as before this is a backend problem.

cc @deetergp

[allgandalf]

We can remove the Blocker here as this is BE

[jasperhuangg]

@deetergp This seems to be a similar issue to #48916, can you fix it in the back-end?

[deetergp]

@jasperhuangg It's similar but not the same. There is a mysterious onyx update setting nvp_onboarding to a blank string, but it's not coming from CompleteGuidedSetup which is where the one from #48916 was coming. I tested yesterday and confirmed that that fix is still working as intended, but I cannot find where this change to a blank string is coming from. If you've got any thoughts or theories, I am all ears!

[johncschuster]

Bumping for Melv (discussion ongoing)

[deetergp]

Still have not unearthed where this is coming from. Will keep digging tomorrow.

[johncschuster]

Bumping for Melv 👍

[deetergp]

This wasn't coming from the backend. We conditionally set nvp_onboarding when we call Report.completeOnboarding on the front end here. I've got a PR going to address it, but need to test more and on other platforms.

[deetergp]

Heya, I'm back from OOO and will try to continue testing this in the next day or two.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Do not set optimistic nvp_onboarding for invited users #51440

If no regressions arise, payment will be issued on 2024-11-28. 🎊

[melvin-bot]

@deetergp @johncschuster @deetergp The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[johncschuster]

Adding @allroundexperts as the reviewer of the PR

[johncschuster]

Payment Summary:

Contributor+: @allroundexperts due $250 via NewDot (to be paid after the regression window is passed and BZ Checklist is complete)

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot

BugZero Checklist (@johncschuster)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[johncschuster]

@allroundexperts can you complete the BZ Checklist above when you get a moment?

[allroundexperts]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: The author is aware of this issue already and commented here.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• N/A

Test:

1. Open the app and log in as user A
2. Submit an expense in USD to user B who does not have an Expensify account
3. Click on the magic link received by user B inviting him to pay the expense
4. Select Pay with Expensify -> Business bank account on the IOU preview

Verify that there is no console error after selecting Pay with Expensify -> Business bank account. Also verify that there is no error if "Pay elsewhere" is selected

Do we agree 👍 or 👎

[johncschuster]

Thank you! Please request payment in ND! Payment Summary here