[Guided Setup Stage 3] Onboarding message not sent when VBBA selected #50052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazejkustra
approved these changes
Oct 2, 2024
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@cdOut why I don't see pay with expensify? Are there any missing precondition?
|
|
Needs to be USD. |
The sender account has to have its currency set to USD and then you also need to set it to USD for the expense itself. I've added the preconditions and a video to help with setting your accounts currency. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2024-10-02.at.8.13.23.PM.mov |
trjExpensify
requested review from
allgandalf
and removed request for
ahmedGaber93
|
@trjExpensify @cdOut this works smooth. Do you need videos on all platforms ? I would need to setup my gmail for android and ios then to test native ? or is only MacOS web fine(currently there in the checklist) ? |
|
This functionality is not platform dependent so I don't think testing it on all platforms is necessary. |
|
Yeah, agreed. Let's get this over to @deetergp for the secondary review and merge. 👍 |
allgandalf
approved these changes
Oct 2, 2024
deetergp
approved these changes
Oct 2, 2024
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
63 tasks
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.44-0 🚀
|
|
The reported performance regression can be ignored, see: |
6 tasks
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀
|
eh2077
reviewed
Dec 3, 2024
| @@ -118,7 +116,10 @@ function AddPaymentMethodMenu({ | |||
| { | |||
| text: translate('common.businessBankAccount'), | |||
| icon: Expensicons.Building, | |||
| onSelected: () => onItemSelected(CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT), | |||
| onSelected: () => { | |||
| completePaymentOnboarding(CONST.PAYMENT_SELECTED.BBA); | |||
There was a problem hiding this comment.
The workspace ID of the onboarding task can be -1 and user is navigated to the "Not here" page. #52236 caught this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds a completePaymentOnboarding call directly into AddPaymentMethodMenu so it always runs on payment confirmation, even if the user has to setup bank info afterwards.
Fixed Issues
$ #50027
PROPOSAL:
Tests
Preconditions
Account of the sender has to set it's currency to USD, which you can do by logging into oldDot (expensify.com) and following the example video, setting your account currency to USD at the end.
Screen.Recording.2024-10-02.at.16.35.53.mov
new.expensify.comtodev.new.expensify.com:8082)Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
CHROME-SMALLER.mov