[HOLD for payment 2024-11-01] [$250] Book travel - Search icon is present on Company address RHP

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Company address in Book travel is not set up.

1. Go to staging.new.expensify.com
2. Go to FAB > Book travel.
3. Click Book travel.

Expected Result:

Search icon will not show up on Company address RHP (because this icon is not seen on any RHP across the app, except report RHP in Search).

Actual Result:

Search icon is present on Company address RHP,

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637383_1729153115507.20241017_161520.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846954023671497945
• Upwork Job ID: 1846954023671497945
• Last Price Increase: 2024-10-17
• Automatic offers:
• rayane-djouah | Reviewer | 104471544

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search icon is present on Company address RHP

What is the root cause of that problem?

The search icon is displayed in the companies address RHP component because the shouldDisplaySearchRouter is enabled inside the AddressPage which is used by the company RHP

App/src/pages/AddressPage.tsx

Line 88 in d11bfe1

shouldDisplaySearchRouter

What changes do you think we should make in order to solve the problem?

we should remove shouldDisplaySearchRouter

What alternative solutions did you explore? (Optional)

[rayane-djouah]

This was caused by #49379
cc @Kicu @luacmartins @ikevin127

[Kicu]

@rayane-djouah won't this be also solved by your #50964?

I seem to remember that in total we have 3 "header" components that cover every single header in the App. So perhaps correct check for RHP would also fix this case?

[rayane-djouah]

@Kicu This is not fixed in #50964. We need to remove shouldDisplaySearchRouter from here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846954023671497945

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[johnmlee101]

I think the proposal looks good, I'll @mollfpr also chime in

[mollfpr]

Agree, the proposal looks good to me!

[luacmartins]

IMO we can demote this to NAB. It was caused by #49984, so I think we should let the original authors work on a fix.

[johnmlee101]

Ah okay, @Kicu can you take over on fixing this?

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Kicu]

yeah no problemo I will fix it today, according to this comment from @rayane-djouah
#51009 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix small search visual bugs #51081

If no regressions arise, payment will be issued on 2024-11-01. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @mollfpr requires payment through NewDot Manual Requests
• @rayane-djouah requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr / @rayane-djouah] Determine if we should create a regression test for this bug.
• [@mollfpr / @rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary

• C: @Kicu (Agency)
• C+: @rayane-djouah $250 (owed via Upworks)

Upwork job

@mollfpr you didn't work on this issue, correct?

[mollfpr]

Yes, no work from me.

[rayane-djouah]

BugZero Checklist

• The PR that introduced the bug has been identified. Link to the PR: Add new SearchButton to all pages and tweak SearchRouter #49379
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49379/files#r1819613931
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. This is part of the search project, and regression tests will be added during the project wrap-up
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[jliexpensify]

Paid and job closed!

[melvin-bot]

@johnmlee101 @luacmartins @jliexpensify Be sure to fill out the Contact List!