Hide the search router button when the report of a search result is opened in RHP #50964

rayane-djouah · 2024-10-16T22:07:18Z

Details

We should remove the magnifying glass button from the report header when the report is opened in the RHP.
https://expensify.slack.com/archives/C049HHMV9SM/p1729111663012689

Fixed Issues

$ #50963

Tests

Prerequisites: Account has multiple reports and expenses

Open a report from the inbox.
Verify that the magnifying glass button is displayed in the report header.
Open the Search tab.
Click on an expense to open the report in the RHP.
Verify that the magnifying glass button is not displayed in the report header.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-16.at.11.37.40.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-16.at.11.35.47.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-16.at.23.35.21.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-16.at.23.33.04.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-10-16.at.11.24.42.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-16.at.11.26.38.PM.mov

…pened in RHP

melvin-bot · 2024-10-16T22:37:34Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM and tests well

luacmartins · 2024-10-16T22:58:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2024-10-16.at.4.58.43.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rayane-djouah · 2024-10-16T22:59:31Z

I'm debugging the failing perf tests https://github.com/Expensify/App/actions/runs/11374795129/job/31644223838?pr=50964

rayane-djouah · 2024-10-16T23:51:17Z

Updated

ntdiary

It seems that C+ review isn't required here? So I just clicked approve. 😄

Kicu

I think the logic of when to display the SearchButton makes sense 👍

src/libs/Navigation/Navigation.ts

…rectly in files

…-header

luacmartins

LGTM

OSBotify · 2024-10-17T15:14:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-18T19:05:45Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.51-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-22T04:39:01Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

github-actions · 2024-10-22T17:21:25Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-11-26T09:01:27Z

src/components/MoneyReportHeader.tsx

@@ -157,6 +158,9 @@ function MoneyReportHeader({policy, report: moneyRequestReport, transactionThrea
    const {isDelegateAccessRestricted, delegatorEmail} = useDelegateUserDetails();
    const [isNoDelegateAccessMenuVisible, setIsNoDelegateAccessMenuVisible] = useState(false);

+    const isReportInRHP = isReportOpenInRHP(navigationRef?.getRootState());
+    const shouldDisplaySearchRouter = !isReportInRHP;


Coming from #51730 where we had the issue that whilst RHP is closing, the last route won't be report RHP anymore, so isReportInRHP becomes false and the search icon is briefly shown (as the RHP is closing).

rayane-djouah added 2 commits October 16, 2024 23:06

hide the search router button when the report of a search result is o…

22d6d08

…pened in RHP

Hide the search router button when the report of a search result is o…

50f282b

…pened in RHP

luacmartins self-requested a review October 16, 2024 22:28

rayane-djouah marked this pull request as ready for review October 16, 2024 22:37

rayane-djouah requested a review from a team as a code owner October 16, 2024 22:37

melvin-bot bot requested review from ntdiary and removed request for a team October 16, 2024 22:37

luacmartins previously approved these changes Oct 16, 2024

View reviewed changes

Fix missing mock in perf tests

8992171

rayane-djouah dismissed luacmartins’s stale review via 8992171 October 16, 2024 23:27

Fix Changed files ESLint check deprecation warning

6720b41

rayane-djouah requested a review from luacmartins October 16, 2024 23:51

ntdiary approved these changes Oct 17, 2024

View reviewed changes

Kicu reviewed Oct 17, 2024

View reviewed changes

src/libs/Navigation/Navigation.ts Outdated Show resolved Hide resolved

rayane-djouah added 4 commits October 17, 2024 11:48

Remove getIsReportOpenInRHP function and handle get navigation ref di…

13d6b0a

…rectly in files

Merge branch 'main' into hide-the-search-icon-on-report-RHP-header

b1a8d75

Fix perf tests

8fe5756

Merge branch 'Expensify:main' into hide-the-search-icon-on-report-RHP…

024b277

…-header

Kicu mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-11-01] [$250] Book travel - Search icon is present on Company address RHP #51009

Closed

8 tasks

luacmartins approved these changes Oct 17, 2024

View reviewed changes

luacmartins merged commit 47b6811 into Expensify:main Oct 17, 2024
16 checks passed

luacmartins assigned rayane-djouah Oct 17, 2024

rayane-djouah deleted the hide-the-search-icon-on-report-RHP-header branch October 17, 2024 16:21

github-actions bot mentioned this pull request Oct 18, 2024

Deploy Checklist: New Expensify 2024-10-18 #51106

Closed

59 tasks

melvin-bot bot mentioned this pull request Oct 22, 2024

[$250] [HOLD for payment 2024-10-29] [Search v2.4] Remove search router button from the RHP report screen #50963

Closed

jjcoffee reviewed Nov 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide the search router button when the report of a search result is opened in RHP #50964

Hide the search router button when the report of a search result is opened in RHP #50964

rayane-djouah commented Oct 16, 2024 •

edited

Loading

melvin-bot bot commented Oct 16, 2024

luacmartins left a comment

luacmartins commented Oct 16, 2024 •

edited

Loading

rayane-djouah commented Oct 16, 2024

rayane-djouah commented Oct 16, 2024

ntdiary left a comment •

edited

Loading

Kicu left a comment

luacmartins left a comment

OSBotify commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

jjcoffee Nov 26, 2024

Hide the search router button when the report of a search result is opened in RHP #50964

Hide the search router button when the report of a search result is opened in RHP #50964

Conversation

rayane-djouah commented Oct 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 16, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Oct 16, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rayane-djouah commented Oct 16, 2024

rayane-djouah commented Oct 16, 2024

ntdiary left a comment • edited Loading

Choose a reason for hiding this comment

Kicu left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

jjcoffee Nov 26, 2024

Choose a reason for hiding this comment

rayane-djouah commented Oct 16, 2024 •

edited

Loading

luacmartins commented Oct 16, 2024 •

edited

Loading

ntdiary left a comment •

edited

Loading