-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-28] [$250] Contact Methods - Navigated back to "New contact method" when going back to online #51189
Comments
Triggered auto assignment to @zanyrenney ( |
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
No more reproducible, it was solved here |
Closing as solved above! |
Issue is still reproducible on the mWeb/Chrome on the latest build 9.0.55-2 Record_2024-10-29-14-44-02.mp4 |
Hmm i can't reproduce this. |
@lanitochka17 still about to reproduce? |
User is still Navigated back to "New contact method". But now tester is seeing that user is navigated to "New contact method" page when pressing on cmd + D. Screen.Recording.2024-10-31.at.5.53.19.in.the.afternoon.mp4 |
Okay, this not the expected behaviour, so let's get this added to external for priorities. |
Job added to Upwork: https://www.upwork.com/jobs/~021853397434469388025 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
Being navigated to the wrong place and requiring use of cmd +D = quality issue. |
@fedirjh @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Part of the screen is covered with black rectangle on MC page. Scrolling gets stuck after swiping up and down a few times What is the root cause of that problem?After we offline and online,
It leads loading page shown, and the input is unmounted and mounted again which causes the empty input appears App/src/pages/workspace/AccessOrNotFoundWrapper.tsx Lines 168 to 170 in 10454f0
What changes do you think we should make in order to solve the problem?Here we check whether the
What alternative solutions did you explore? (Optional)We can add
|
Edited by proposal-police: This proposal was edited at 2024-11-11 21:40:42 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Return to "New contact method" when going back online. What is the root cause of that problem?We are using Modal to show validation section. Using modal have these limitations:
What changes do you think we should make in order to solve the problem?Contact validation page is not directly related to a report, but we conditionaly show loading indicator each time report data loaded here:
I think we don't need to show loading indicator in validation page because it is not directly related to a report, we can add new and modify logic to show the loading const shouldShowFullScreenLoadingIndicator = !isMoneyRequest && isLoadingReportData !== false && (!Object.entries(policy ?? {}).length || !policy?.id) && !shouldDisableLoadingIndicator; Apply it in <AccessOrNotFoundWrapper shouldBeBlocked={isActingAsDelegate} shouldDisableLoadingIndicator={true}>
This way the validation modal will not need to re-mount. What alternative solutions did you explore? (Optional)Alternative 1 This will also resolve this issue #51189 (comment) Alternative 2 Directly use if (isActingAsDelegate) {
return <NotFoundPage onBackButtonPress={onBackButtonPress} />;
} |
@wildan-m Your RCA make sense to me. However, the main solution doesn't look ideal to me. I agree that we don't need to use if (isActingAsDelegate) {
return <NotFoundPage onBackButtonPress={onBackButtonPress} />;
} |
@fedirjh If no one has proposed it yet, I have added it as alternative 2. I agree that we only need a "not found" page for this case and the |
Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-28. 🎊 For reference, here are some details about the assignees on this issue:
|
@fedirjh @zanyrenney @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
I have asked @fedirjh to complete checklist |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalPrecondition:
Test:
Do we agree 👍 or 👎 |
payment summary@wildan-m requires payment automatic offer (Contributor) - paid $250 via upwork |
$250 approved for @fedirjh |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.51-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
User is not Navigated back to "New contact method" when going back to online
Actual Result:
Navigated back to "New contact method" when going back to online
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6641216_1729527065628.Screen_Recording_2024-10-21_at_6.57.57_in_the_evening.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @zanyrenneyThe text was updated successfully, but these errors were encountered: