Show No access Modal when Copilot tries to add new contact method on behalf of owner. #50643

ChavdaSachin · 2024-10-11T12:51:11Z

Show No access Modal when Copilot tries to add new contact method on behalf of owner.

Details

As per App's philosophy we do not allow certain actions to be performed by a copilot on behalf of owner add new contact method is one of them.
When copilot completes add new contact method flow on behalf of owner - BE return an error, this PR implements FE handling for the same by not allowing copilot to start the flow and provide explanation in form of a Modal.

Fixed Issues

$ #50063
PROPOSAL: #50063 (comment)

Tests

Same QA test

Verify that no errors appear in the JS console

Offline tests

Same ad QA test.

QA Steps

Prerequisites: Enable Copilot Beta, and perform following steps as a copilot. To add account as copilot see link.

Navigate to settings/profile as a copilot.
Click 'contact methods'.
Click 'New contact method' button.
Verify 'Not So Fast...' modal appears and 'New contact method' flow does not start.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-11.at.5.46.46.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-11.at.5.48.19.PM.mov

iOS: Native

Screen.Recording.2024-10-11.at.6.33.07.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-11.at.6.41.00.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-11.at.5.45.14.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-11.at.6.09.30.PM.mov

…behalf of owner

melvin-bot · 2024-10-11T13:50:29Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ChavdaSachin · 2024-10-11T13:54:43Z

@c3024 ESLint is failing for already implemented code using withOnyx. And this PR is not any how related with the fail here.
What should be my next step ?

c3024 · 2024-10-14T08:22:44Z

ESLint is failing for already implemented code using withOnyx.

I think this should be dealt in a different PR. useOnyx migrations can cause unexpected issues related to loading like this case. In case something expected comes up we can easily revert that PR.

c3024 · 2024-10-14T08:22:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

copilotAndroid.mp4

Android: mWeb Chrome

copilotAndroidmWeb.mp4

iOS: Native

copilotiOS.mp4

iOS: mWeb Safari

copilotiOSmWeb.mp4

MacOS: Chrome / Safari

copilotChrome.mp4

MacOS: Desktop

copilotDesktop.mp4

c3024

LGTM!

Julesssss · 2024-10-14T09:39:33Z

Hey @ChavdaSachin, unfortunately a check was modified since you raised this PR that causes a failure: https://github.com/Expensify/App/actions/runs/11293174238/job/31410713217?pr=50643#step:4:24

ChavdaSachin · 2024-10-14T09:56:14Z

Hey @ChavdaSachin, unfortunately a check was modified since you raised this PR that causes a failure: https://github.com/Expensify/App/actions/runs/11293174238/job/31410713217?pr=50643#step:4:24

hi @Julesssss, for the fail here, We need to migrate the page to useOnyx. And as @c3024 suggested here we should handle it as a separate PR.
do you agree? or we should handle migration in this pr itself, what's your take here?

IMO you could raise a new issue and assign me along with @c3024 and we will raise a quick PR. And put current issue on hold for the migration.

Julesssss · 2024-10-14T10:21:50Z

And as @c3024 suggested here we should handle it as a separate PR. do you agree?

Yeah that's fine, I missed that comment when looking this morning.

melvin-bot · 2024-10-14T10:22:04Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2024-10-14T10:22:27Z

Ignoring failed check as mentioned here.

OSBotify · 2024-10-14T10:31:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-15T03:31:38Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-17T01:46:33Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ChavdaSachin · 2024-10-20T22:58:41Z

Ignoring failed check as mentioned here.

Hey @Julesssss I kinda he useOnyx migration ready, just waiting for you to create a GH.

Julesssss · 2024-10-21T09:24:34Z

Hey @Julesssss I kinda he useOnyx migration ready

Hi @ChavdaSachin, could you explain again? thanks 🙂

ChavdaSachin · 2024-10-21T09:26:20Z

We had a discussion to handle onyx migration as a separate PR.

Julesssss · 2024-10-21T09:28:30Z

Oh yes I agree with that. We can use this Github

ChavdaSachin · 2024-10-21T09:39:03Z

Works for me

fedirjh · 2024-11-28T13:11:07Z

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

-                onSubmit={handleValidateMagicCode}
-                submitButtonText={translate('common.add')}
-                style={[styles.flexGrow1, styles.mh5]}
+        <AccessOrNotFoundWrapper shouldBeBlocked={isActingAsDelegate}>


This change has introduced a bug in #51189 , we should have just early returned instead of using AccessOrNotFoundWrapper.

ChavdaSachin added 3 commits October 11, 2024 17:57

Show No access Modal when Copilot tries to add new contact method on …

e04eabe

…behalf of owner

Eslint fix

841379c

Prettier

1603725

ChavdaSachin marked this pull request as ready for review October 11, 2024 13:50

ChavdaSachin requested a review from a team as a code owner October 11, 2024 13:50

melvin-bot bot requested review from c3024 and removed request for a team October 11, 2024 13:50

c3024 approved these changes Oct 14, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss October 14, 2024 08:27

Julesssss approved these changes Oct 14, 2024

View reviewed changes

Julesssss merged commit 58a8528 into Expensify:main Oct 14, 2024
17 of 18 checks passed

melvin-bot bot added the Emergency label Oct 14, 2024

Julesssss removed the Emergency label Oct 14, 2024

github-actions bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

melvin-bot bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-24] [$250] Error when copilot adds a new contact method #50063

Closed

6 tasks

fedirjh mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-28] [$250] Contact Methods - Navigated back to "New contact method" when going back to online #51189

Closed

8 tasks

This was referenced Nov 21, 2024

Onyx Migration For #50796 #52884

Merged

Handle blocked copilot and Expensify card flows gracefully #52103

Merged

fedirjh reviewed Nov 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show No access Modal when Copilot tries to add new contact method on behalf of owner. #50643

Show No access Modal when Copilot tries to add new contact method on behalf of owner. #50643

ChavdaSachin commented Oct 11, 2024 •

edited

Loading

melvin-bot bot commented Oct 11, 2024

ChavdaSachin commented Oct 11, 2024

c3024 commented Oct 14, 2024 •

edited

Loading

c3024 commented Oct 14, 2024 •

edited

Loading

c3024 left a comment

Julesssss commented Oct 14, 2024

ChavdaSachin commented Oct 14, 2024

Julesssss commented Oct 14, 2024

melvin-bot bot commented Oct 14, 2024

Julesssss commented Oct 14, 2024

OSBotify commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 17, 2024

ChavdaSachin commented Oct 20, 2024

Julesssss commented Oct 21, 2024

ChavdaSachin commented Oct 21, 2024

Julesssss commented Oct 21, 2024

ChavdaSachin commented Oct 21, 2024

fedirjh Nov 28, 2024

Show No access Modal when Copilot tries to add new contact method on behalf of owner. #50643

Show No access Modal when Copilot tries to add new contact method on behalf of owner. #50643

Conversation

ChavdaSachin commented Oct 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2024

ChavdaSachin commented Oct 11, 2024

c3024 commented Oct 14, 2024 • edited Loading

c3024 commented Oct 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

Julesssss commented Oct 14, 2024

ChavdaSachin commented Oct 14, 2024

Julesssss commented Oct 14, 2024

melvin-bot bot commented Oct 14, 2024

Julesssss commented Oct 14, 2024

OSBotify commented Oct 14, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 17, 2024

ChavdaSachin commented Oct 20, 2024

Julesssss commented Oct 21, 2024

ChavdaSachin commented Oct 21, 2024

Julesssss commented Oct 21, 2024

ChavdaSachin commented Oct 21, 2024

fedirjh Nov 28, 2024

Choose a reason for hiding this comment

ChavdaSachin commented Oct 11, 2024 •

edited

Loading

c3024 commented Oct 14, 2024 •

edited

Loading

c3024 commented Oct 14, 2024 •

edited

Loading