[HOLD for payment 2024-11-22] [$250] Attachment - Image moves to the bottom when swiping down slightly

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+kh2010001@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch ND app.
2. Go to DM.
3. Upload an image.
4. Tap on the image preview.
5. Swipe down from the top slightly.

Expected Result:

The image will be dismissed (production behavior).

Actual Result:

The image moves to the bottom.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6645372_1729849782889.swiipe.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849822965045405568
• Upwork Job ID: 1849822965045405568
• Last Price Increase: 2024-10-25
• Automatic offers:
• brunovjk | Reviewer | 104693785

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

Production

P.2.MP4

[Julesssss]

Thanks! This is annoying, and I will seek out the cause, but I won't mark this as a blocker.

[Julesssss]

Reverting the 'Swipe attatchement' PR didn't resolve the issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849822965045405568

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[Julesssss]

Nice, yeah lets replace all uses please.

[melvin-bot]

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @brunovjk

[CortneyOfstad]

PR actively being worked on so no update

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix image moves permanently when swipe down #51921

If no regressions arise, payment will be issued on 2024-11-22. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @brunovjk requires payment automatic offer (Reviewer)

[melvin-bot]

@brunovjk @CortneyOfstad @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[brunovjk]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other: Applause-Internal team

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: No PR directly introduce the bug.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Discussion not started, as regression was not critical.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

• Send at least 2 attachments to any chat.

Test:

1. Open one of the attachments.
2. Verify you can't swipe left/right while swiping down.
3. Verify you can't swipe down while swiping left/right.
4. Swipe the image down a little.
   • Verify it goes back to its initial position.
5. Swipe the image down completely.
   • Verify it closes the image.

Web/Desktop: Verify there is no swipe.

Do we agree 👍 or 👎

[bernhardoj]

Does it make sense if the price for this issue is increased since we cover other things (only allow one swipe gesture at a time) on the issue too? Appreciate any decision, thanks 🙇

cc: @Julesssss

[Julesssss]

Hey @bernhardoj. I appreciate that we took time to add the additional fix, but I think in this case it could be considered to be refining the solution. Let me know if you have any other thoughts here, though 👍

[brunovjk]

To provide more context to support @bernhardoj's request: The initial issue was resolved, but during testing, we noticed the same symptom (freezing the image when swiping) caused by a different root. I researched similar apps to see how they handle this and found they block swiping in two directions. We suggested this approach, and after team approval, we moved to implement and test it. Anyway I am in favor of any decision. Thank you.

[Julesssss]

Thanks @brunovjk. It definately took extra effort and that is appreciated. I think in this case it falls just on the side of not getting an increased payment. I believe they balance over multiple jobs.

I believe other internal engineers would vote the same way, but I can ask for quick second opinion if you'd like.

[brunovjk]

but I can ask for quick second opinion if you'd like.

No it's fine :D I totally agree, thanks for clarifying 🚀

[CortneyOfstad]

Payment Summary

@bernhardoj — to be paid $250 via NewDot
@brunovjk — paid $250 via Upwork

Regression Test

https://github.com/Expensify/Expensify/issues/447135

Link to check list — #51465 (comment)

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj