Fix image moves permanently when swipe down #51921

bernhardoj · 2024-11-02T03:45:20Z

Explanation of Change

When swiping down an image attachment, it doesn't go back to its place. The root of the issue is the function that captured an old canvas value. This PR fixes it by making sure the canvas size is added to the useCallback deps.

Fixed Issues

$ #51465
PROPOSAL: #51465 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Send at least 2 attachments to any chat
Open one of the attachments
Swipe the image down a little
Verify it goes back to its initial position
Verify you can't swipe left/right while swiping down
Verify you can't swipe down while swiping left/right

Web/Desktop: There is no swipe

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-11-02T03:45:25Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-11-02T03:45:44Z

Swiping the image on mWeb chrome throws an error (on main too).

bernhardoj · 2024-11-02T03:46:37Z

Additional videos:

Double tap zoom:

double.tap.zoom.mp4

Pinch:

pinch.mp4

Avatar crop modal:

avatar.mp4

brunovjk · 2024-11-04T12:47:46Z

@bernhardoj If we have just one image, everything looks fine to me, but if we upload two images, especially with different heights, then swipe a bit to the side, so that you can see both images, and then swipe down, something strange is happening:

51921_ios_native_bug.mov

Can you reproduce it? I haven't tested it in main yet. I'll take a look and see if I can find the root. Thanks.

bernhardoj · 2024-11-04T13:05:51Z

Not exactly the same, but it always behave strangely after uploading a new image, on main too.

asd.mp4

ios.mp4

brunovjk · 2024-11-04T14:56:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

51921_android_native.mov

Android: mWeb Chrome

51921_android_web.mov

iOS: Native

51921_ios_native.mov

iOS: mWeb Safari

51921_ios_web.mov

MacOS: Chrome / Safari

51921_web_chorme.mov

MacOS: Desktop

51921_web_desktop.mov

brunovjk · 2024-11-04T18:35:04Z

Not exactly the same, but it always behave strangely after uploading a new image, on main too.

True, however, apart from this strange behavior, I believe that the problem we are trying to solve still persists, If we only have one image, everything works fine, with two:

Screen.Recording.2024-11-04.at.15.29.19.mov

What do you think @bernhardoj?

bernhardoj · 2024-11-05T11:40:13Z

I'll take a look.

brunovjk · 2024-11-05T12:19:05Z

Gerat! Let me know if I can help in any way.

…-down

bernhardoj · 2024-11-06T08:14:27Z

I'm having problem with my iOS. It doesn't respond to press.

…-down

bernhardoj · 2024-11-07T05:47:43Z

It works normally back and I can repro this. The root cause is that the finishPanGesture isn't called because shouldDisableTransformationGestures is true.

App/src/components/MultiGestureCanvas/usePanGesture.ts

Lines 233 to 238 in afa7b33

    
           // If we are swiping (in the pager), we don't want to return to boundaries 
        
           if (shouldDisableTransformationGestures.value) { 
        
               return; 
        
           } 
        
           finishPanGesture();

From the comment, looks like it's expected?

brunovjk · 2024-11-07T18:31:29Z

From the comment, looks like it's expected?

I see, thanks for clarifying, that makes sense. @bernhardoj what do you think about preventing swiping in more than one direction? Example: preventing "swiping sideways" if we are performing another gesture, in this case "swiping down". Not allowing two movements to be made at the same time. I tested it on Whatsapp and this is how they do it there, I couldn't record a video to illustrate it better, but if it wasn't clear, let me know. Do you think it would be feasible here? Thank you.

bernhardoj · 2024-11-08T03:02:45Z

Yeah, I prefer to prevent that too, but I think we need the team's input first about changing this behavior.

Julesssss · 2024-11-08T13:54:27Z

Yeah I totally agree with the suggestion of only allowing swiping in one direction at a time 👍

brunovjk · 2024-11-09T11:10:40Z

Nice. @bernhardoj do you think we can make these changes here? Thanks.

…-down

bernhardoj · 2024-11-10T07:03:48Z

Updated. Please check

brunovjk · 2024-11-11T14:00:59Z

Nice! Looking good, except for one detail: when adding a new photo, we could skip the upload by swiping the image down:

iOS: Native - main

Screen.Recording.2024-11-11.at.10.49.36.mov

Now, after the changes, I can't:

iOS: Native - testing PR

Screen.Recording.2024-11-11.at.10.50.37.mov

@bernhardoj, was that intentional? Other than that, everything else looks great.

…-down

bernhardoj · 2024-11-12T04:10:34Z

src/components/MultiGestureCanvas/index.tsx

+            }
+            // eslint-disable-next-line react-compiler/react-compiler, no-param-reassign
+            isPagerScrollEnabled.value = !current;
+        },


Fixed. In non-carousel, changing isScrollEnabled, changes the nope shared value here

App/src/components/AttachmentModal.tsx

Lines 474 to 475 in 64cb4ee

isPagerScrolling: nope,

isScrollEnabled: nope,

which sets isPagerScrolling to true too, disabling the pan gesture.

github-actions · 2024-11-12T10:26:21Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51921/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51921/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51921/NewExpensify.dmg	https://51921.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

brunovjk · 2024-11-12T12:15:44Z

Thanks for the changes @bernhardoj, in native everything looks good now:

Android: Native

51921_android_native.mov

iOS: Native

51921_ios_native.mov

However, in mobile web, when we already have some images uploaded, I can't dismiss the image by swiping down:

Android: mWeb Chrome

51921_android_web.mov

iOS: mWeb Safari

51921_ios_web.mov

Otherwise everything looks fine:

MacOS: Chrome / Safari

51921_web_chorme.mov

MacOS: Desktop

51921_web_desktop.mov

Let me know if I can help in any way. Thank you.

…-down

bernhardoj · 2024-11-12T16:36:20Z

src/components/Attachments/AttachmentCarousel/index.tsx

@@ -201,12 +201,12 @@ function AttachmentCarousel({report, source, onNavigate, setDownloadButtonVisibi
            activePage: 0,
            pagerRef,
            isPagerScrolling: nope,
-            isScrollEnabled: nope,
+            isScrollEnabled,


Fixed. Same with the previous issue.

brunovjk · 2024-11-12T18:36:37Z

Sorry @bernhardoj, but it seems to be worse on mWeb:

mobile_mWeb

mobile_mWeb.mov

In native still fine:

native

native.mov

Do you have any idea what it could be? Let me know if you find anything.

bernhardoj · 2024-11-13T02:47:05Z

src/components/Attachments/AttachmentCarousel/index.tsx

                    scrollTo(scrollRef, page * cellWidth - translationX, 0, false);
                })
                .onEnd(({translationX, velocityX}) => {
-                    if (scale.current !== 1) {
+                    if (!isScrollEnabled.value) {
                        return;
                    }


Fixed. The scroll stuck because we swipe down while scrolling, making isScrollEnabled false. Now I update isPagerScrolling while scrolling.

bernhardoj · 2024-11-13T02:47:41Z

src/components/Attachments/AttachmentCarousel/index.tsx

@@ -253,11 +257,12 @@ function AttachmentCarousel({report, source, onNavigate, setDownloadButtonVisibi
                        newIndex = Math.min(attachments.length - 1, Math.max(0, page + delta));
                    }

+                    isPagerScrolling.value = false;
                    scrollTo(scrollRef, newIndex * cellWidth, 0, true);


There is no completion callback when the scroll animation is complete.

brunovjk

Great job @bernhardoj, everything looks good to me now. I retested on all platforms and updated the videos.

Julesssss · 2024-11-13T12:44:28Z

One last thing, is there another test we should add to cover the slightly changed behaviour?

...what do you think about preventing swiping in more than one direction? Example: preventing "swiping sideways" if we are performing another gesture, in this case "swiping down". Not allowing two movements to be made at the same time. I tested it on Whatsapp and this is how they do it there

brunovjk · 2024-11-13T13:10:33Z

One last thing, is there another test we should add to cover the slightly changed behaviour?

...what do you think about preventing swiping in more than one direction? Example: preventing "swiping sideways" if we are performing another gesture, in this case "swiping down". Not allowing two movements to be made at the same time. I tested it on Whatsapp and this is how they do it there

Well noted @Julesssss. @bernhardoj can you update the Test Steps for us? Thank you.

bernhardoj · 2024-11-13T13:13:59Z

Added the test.

brunovjk · 2024-11-13T13:16:49Z

Thank you @bernhardoj! What do you think @Julesssss? Thanks.

Julesssss · 2024-11-13T13:41:32Z

Thanks, looks good.

OSBotify · 2024-11-13T13:52:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-14T00:52:59Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2024-11-15T14:16:19Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

bernhardoj added 3 commits November 2, 2024 11:16

fix typo

99a4e93

fix swiping image doesn't move back to its position

4835a6a

replace all useWorkletCallback to useCallback

9b8c5de

bernhardoj requested a review from a team as a code owner November 2, 2024 03:45

melvin-bot bot requested a review from brunovjk November 2, 2024 03:45

melvin-bot bot removed the request for review from a team November 2, 2024 03:45

bernhardoj added 2 commits November 2, 2024 11:54

lint

27374bc

lint

7306c7d

Merge branch 'main' into fix/51465-image-moves-permanently-when-swipe…

79a760d

…-down

Merge branch 'main' into fix/51465-image-moves-permanently-when-swipe…

4011c97

…-down

bernhardoj added 2 commits November 10, 2024 14:41

Merge branch 'main' into fix/51465-image-moves-permanently-when-swipe…

f95fd08

…-down

disable pager scrolling when swiping image down

0e4bee6

bernhardoj added 2 commits November 10, 2024 15:28

suppress lint

69c5001

suppress lint

67438d0

bernhardoj added 3 commits November 12, 2024 11:37

Merge branch 'main' into fix/51465-image-moves-permanently-when-swipe…

b8f1135

…-down

change fallback value to false

ca558c1

fix can't swipe down on non carousel attachment

7e32422

bernhardoj commented Nov 12, 2024

View reviewed changes

Julesssss added the Ready To Build label Nov 12, 2024

bernhardoj added 2 commits November 12, 2024 23:57

Merge branch 'main' into fix/51465-image-moves-permanently-when-swipe…

06be95e

…-down

fix can't swipe down on mweb

4e53b33

bernhardoj commented Nov 12, 2024

View reviewed changes

prevent swiping down when scrolling

d55ddee

bernhardoj commented Nov 13, 2024

View reviewed changes

lint

5ecd45e

brunovjk approved these changes Nov 13, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss November 13, 2024 11:50

Julesssss approved these changes Nov 13, 2024

View reviewed changes

Julesssss merged commit b1c1a4b into Expensify:main Nov 13, 2024
19 checks passed

github-actions bot mentioned this pull request Nov 14, 2024

Deploy Checklist: New Expensify 2024-11-14 #52512

Closed

47 tasks

melvin-bot bot mentioned this pull request Nov 15, 2024

[HOLD for payment 2024-11-22] [$250] Attachment - Image moves to the bottom when swiping down slightly #51465

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix image moves permanently when swipe down #51921

Fix image moves permanently when swipe down #51921

bernhardoj commented Nov 2, 2024 •

edited by Julesssss

Loading

melvin-bot bot commented Nov 2, 2024

bernhardoj commented Nov 2, 2024

bernhardoj commented Nov 2, 2024

brunovjk commented Nov 4, 2024

bernhardoj commented Nov 4, 2024

brunovjk commented Nov 4, 2024 •

edited

Loading

brunovjk commented Nov 4, 2024

bernhardoj commented Nov 5, 2024

brunovjk commented Nov 5, 2024

bernhardoj commented Nov 6, 2024

bernhardoj commented Nov 7, 2024

brunovjk commented Nov 7, 2024

bernhardoj commented Nov 8, 2024

Julesssss commented Nov 8, 2024

brunovjk commented Nov 9, 2024

bernhardoj commented Nov 10, 2024

brunovjk commented Nov 11, 2024

bernhardoj Nov 12, 2024

github-actions bot commented Nov 12, 2024

brunovjk commented Nov 12, 2024

bernhardoj Nov 12, 2024

brunovjk commented Nov 12, 2024

bernhardoj Nov 13, 2024

bernhardoj Nov 13, 2024

brunovjk left a comment

Julesssss commented Nov 13, 2024

brunovjk commented Nov 13, 2024 •

edited

Loading

bernhardoj commented Nov 13, 2024

brunovjk commented Nov 13, 2024

Julesssss commented Nov 13, 2024

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

Fix image moves permanently when swipe down #51921

Fix image moves permanently when swipe down #51921

Conversation

bernhardoj commented Nov 2, 2024 • edited by Julesssss Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 2, 2024

bernhardoj commented Nov 2, 2024

bernhardoj commented Nov 2, 2024

brunovjk commented Nov 4, 2024

bernhardoj commented Nov 4, 2024

brunovjk commented Nov 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

brunovjk commented Nov 4, 2024

bernhardoj commented Nov 5, 2024

brunovjk commented Nov 5, 2024

bernhardoj commented Nov 6, 2024

bernhardoj commented Nov 7, 2024

brunovjk commented Nov 7, 2024

bernhardoj commented Nov 8, 2024

Julesssss commented Nov 8, 2024

brunovjk commented Nov 9, 2024

bernhardoj commented Nov 10, 2024

brunovjk commented Nov 11, 2024

bernhardoj Nov 12, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 12, 2024

brunovjk commented Nov 12, 2024

bernhardoj Nov 12, 2024

Choose a reason for hiding this comment

brunovjk commented Nov 12, 2024

bernhardoj Nov 13, 2024

Choose a reason for hiding this comment

bernhardoj Nov 13, 2024

Choose a reason for hiding this comment

brunovjk left a comment

Choose a reason for hiding this comment

Julesssss commented Nov 13, 2024

brunovjk commented Nov 13, 2024 • edited Loading

bernhardoj commented Nov 13, 2024

brunovjk commented Nov 13, 2024

Julesssss commented Nov 13, 2024

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

bernhardoj commented Nov 2, 2024 •

edited by Julesssss

Loading

brunovjk commented Nov 4, 2024 •

edited

Loading

brunovjk commented Nov 13, 2024 •

edited

Loading