[PAID] [Search v2.5] - Category field is still present after deleting all the categories

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #52102
Email or phone of affected tester (no customers): applausetester+290324@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Create a new workspace.
4. Go to workspace settings > More features.
5. Enable Tags.
6. Go to Tags and add some tags.
7. Go to Search > Filters.
8. Note that Category and Tag fields are present.
9. Go back to workspace settings.
10. Delete all categories and tags.
11. Go to Search > Filters.

Expected Result:

Both Category and Tag fields will not be present because there are no categories and tags.

Actual Result:

Category field is still present after deleting all the categories, while Tag field is not present which is expected.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6661800_1731356979898.20241112_042538.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Edited by proposal-police: This proposal was edited at 2024-11-12 10:11:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Category field is still present after deleting all the categories

What is the root cause of that problem?

Offending PR: #52102
We will show the category menu if the policy category id exist in nonPersonalPolicyCategoryIds

App/src/pages/Search/AdvancedSearchFilters.tsx

Lines 279 to 284 in e3632a9

	const nonPersonalPolicyCategoryIds = Object.values(policies)
	.filter((policy): policy is NonNullable<Policy> => !!(policy && policy.type !== CONST.POLICY.TYPE.PERSONAL))
	.map((policy) => `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policy.id}`);
	const nonPersonalPolicyCategoryCount = Object.keys(allPolicyCategories).filter((policyCategoryId) => nonPersonalPolicyCategoryIds.includes(policyCategoryId)).length;
	const shouldDisplayCategoryFilter = nonPersonalPolicyCategoryCount !== 0 || !!singlePolicyCategories;

When we create new workspace and enable the categories feature, the category menu item will show because the policy category id is exist inside nonPersonalPolicyCategoryIds

App/src/pages/Search/AdvancedSearchFilters.tsx

Line 282 in e3632a9

const nonPersonalPolicyCategoryCount = Object.keys(allPolicyCategories).filter((policyCategoryId) => nonPersonalPolicyCategoryIds.includes(policyCategoryId)).length;

But when we delete all the categories, the policy category id still exists in this allPolicyCategories with empty object value and when when we check if the policy category is exist inside nonPersonalPolicyCategoryIds it will return true which cause this issue

App/src/pages/Search/AdvancedSearchFilters.tsx

Line 282 in e3632a9

const nonPersonalPolicyCategoryCount = Object.keys(allPolicyCategories).filter((policyCategoryId) => nonPersonalPolicyCategoryIds.includes(policyCategoryId)).length;

What changes do you think we should make in order to solve the problem?

Inside allPolicyCategories we should filter out if the value is empty object

const filteredPoliciyCategories = useMemo(() => Object.values(allPolicyCategories ?? {}).filter((policyCategory) => !isEmptyObject(policyCategory)), [allPolicyCategories])

OR

const nonPersonalPolicyCategoryCount = Object.keys(allPolicyCategories).filter(
    (policyCategoryId) => nonPersonalPolicyCategoryIds.includes(policyCategoryId) && !isEmptyObject(allPolicyCategories[policyCategoryId]),
).length;

const shouldDisplayCategoryFilter = nonPersonalPolicyCategoryCount !== 0 || !!singlePolicyCategories;

What alternative solutions did you explore? (Optional)

[MariaHCD]

Since this is a bug from #52102 and we're still in the regression period, the original PR author will be handling the fix for this.

cc: @Kicu @fedirjh @luacmartins

[Kicu]

will write a comment here a bit later

[Kicu]

Please assign me, I will provide a fix for this.
That being said I don't think this is necessarily a deploy blocker, maybe @luacmartins you can verify

[luacmartins]

Yea, this is not a blocker. Assigning it to you @Kicu

[SzymczakJ]

@Kicu asked me to take a look at it, I think that solution that @NJ-2020 proposed is good(also tested it) and we should let him open a PR with it 😄
WDYT @luacmartins

[luacmartins]

That works for me

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix category menu still presents while the list is empty #52608

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @NJ-2020 requires payment (Needs manual offer from BZ)

[melvin-bot]

@luacmartins @strepanier03 @Kicu / @NJ-2020 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @Kicu is from an agency-contributor and not due payment
• ROLE: @NJ-2020 paid $250 via Upwork (Job)

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@Kicu, @strepanier03, @luacmartins, @NJ-2020 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Working on this now, the "HOLD" in the title had it hidden from me yesterday and I didn't see it. Sorry for the delay.

[strepanier03]

@NJ-2020 - Can you please share a link to your profile in Upwork? I'm unable to find it to send you an offer. Thanks!

[strepanier03]

@Kicu - I think you're responsible for the checklist, can you take care of that as well?

[NJ-2020]

@strepanier03 Sure here's my upwork profile: https://www.upwork.com/freelancers/~01ff73ff788ecf5f2e

[Kicu]

@strepanier03 I work for SWM, an expert agency as a contractor and I'm also not a C+.
So are you sure that I should take care of the checklist? 😅 I think this is not something we are responsible for.

[strepanier03]

Hmmm, I thought you were the reviewer here; sorry about that, @Kicu. This comment had me a bit turned around I think. I'll figure out who is responsible for it.

[strepanier03]

Hmmm, looks like @Ollyws reviewed the PR.

[Ollyws]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/52102/files#r1871922833

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Sign in with new account
2. Create a new workspace
3. Go to workspace settings > categories
4. Delete all categories
5. Go to Search page > Filters
6. Make sure the Category menu is not presents in the Filters menu page

Do we agree 👍 or 👎

[Ollyws]

@strepanier03 Could you post an updated payment summary and I'll request payment in ND, thanks!

[strepanier03]

Payment summary

• $250 - @NJ-2020 via Upwork (offer)
• $250 - @Ollyws via New Expensify manual offer

[strepanier03]

updated payment summary above @Ollyws, feel free to request. @NJ-2020 I sent you the offer, I'll check it in a few hours to see if I can pay it out.

[Ollyws]

Requested in ND.

[NJ-2020]

@strepanier03 Done accepted, Thanks

[strepanier03]

I paid and closed the contract for @NJ-2020 and I see that @Ollyws has requested payment.

Closing this now.

[garrettmknight]

$250 approved for @Ollyws