Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2021-09-23 #5477

Closed
27 tasks done
OSBotify opened this issue Sep 23, 2021 · 13 comments
Closed
27 tasks done

Deploy Checklist: New Expensify 2021-09-23 #5477

OSBotify opened this issue Sep 23, 2021 · 13 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 23, 2021

Release Version: 1.1.2-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 24, 2021
@mvtglobally
Copy link

Starting QA

@isagoico
Copy link

isagoico commented Sep 24, 2021

@iwiznia
Copy link
Contributor

iwiznia commented Sep 24, 2021

Correct

@iwiznia
Copy link
Contributor

iwiznia commented Sep 24, 2021

Please hold on closing this check list. Context: https://expensify.slack.com/archives/C020EPP9B9A/p1632508075043800

@Jag96 Jag96 changed the title Deploy Checklist: New Expensify 2021-09-23 [HOLD ON DEPLOY] Deploy Checklist: New Expensify 2021-09-23 Sep 24, 2021
@isagoico
Copy link

Regression and PRs are finished!

No issues found today 🎉 🎉

@isagoico
Copy link

Checking off #5515 (comment) 🎉

@parasharrajat
Copy link
Member

Shouldn't this be deployed?

@MelvinBot MelvinBot added the Monthly KSv2 label Sep 27, 2021
@timszot
Copy link
Contributor

timszot commented Sep 28, 2021

@isagoico any update on #5524 as I see it's not checked off yet.

@isagoico
Copy link

isagoico commented Sep 28, 2021

@timszot oh sorry I missed that CP. We are currently blocked from testing that PR, will leave a comment there

@isagoico
Copy link

Checking off #5524 (comment)

@timszot timszot changed the title [HOLD ON DEPLOY] Deploy Checklist: New Expensify 2021-09-23 Deploy Checklist: New Expensify 2021-09-23 Sep 28, 2021
@timszot
Copy link
Contributor

timszot commented Sep 28, 2021

We've removed the hold on this deploy and QA is complete! Closing this out.

@timszot timszot closed this as completed Sep 28, 2021
@OSBotify OSBotify reopened this Sep 28, 2021
@OSBotify
Copy link
Contributor Author

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@timszot
Copy link
Contributor

timszot commented Sep 28, 2021

:shipit:

@timszot timszot closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants