Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spinner so policy links don't break #5439

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Add spinner so policy links don't break #5439

merged 1 commit into from
Sep 23, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Sep 23, 2021 •
edited
Loading

Details

Fixed Issues

Alternative fix for #5396 (comment)

Tests / QA Steps

  1. Create a new account in OldDot and validate it
  2. Create a free plan policy via group policy page (Do not refresh OldDot)
  3. Verify you are logged into NewDot in a new tab and land on the workspace page
  4. Sign out of NewDot
  5. Create another free plan policy via the group policy page in OldDot
  6. Verify you are logged into NewDot in a new tab and land on the workspace page
  7. Sign out of NewDot
  8. Refresh the page in OldDot
  9. Tap the first policy in OldDot
  10. Verify you are logged into NewDot in a new tab and land on the workspace page
  11. Sign out of NewDot
  12. Tap the second policy in OldDot
  13. Verify you are logged into NewDot in a new tab and land on the workspace page

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Sep 23, 2021
@marcaaron marcaaron marked this pull request as ready for review September 23, 2021 05:21
@marcaaron marcaaron requested a review from a team as a code owner September 23, 2021 05:21
cead22
cead22 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@cead22 cead22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple 👍

@MelvinBot MelvinBot requested review from thienlnam and removed request for a team September 23, 2021 05:22
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham roryabraham merged commit ae932fc into main Sep 23, 2021
@roryabraham roryabraham deleted the marcaaron-doDumbSpinnerUnblockWorkspaceInvalid branch September 23, 2021 05:55
github-actions bot pushed a commit that referenced this pull request Sep 23, 2021
@roryabraham
Merge pull request #5439 from Expensify/marcaaron-doDumbSpinnerUnbloc…
f8b4858 
…kWorkspaceInvalid

(cherry picked from commit ae932fc)
This was referenced Sep 23, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.1-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@iwiznia iwiznia mentioned this pull request Sep 23, 2021
Merged
5 tasks
@OSBotify OSBotify mentioned this pull request Sep 23, 2021
Closed
27 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.1-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@cead22 cead22 cead22 approved these changes

@thienlnam thienlnam Awaiting requested review from thienlnam

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcaaron @OSBotify @cead22 @roryabraham