Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for bank transaction validation failure #5393

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Sep 21, 2021

Details

Right now, when validating a bank account, if it fails for any reason other than validation being locked, we just show whatever error the API gives. In the case of incorrect validation transaction amounts, the error message given is a bit confusing. So this update shows a more user-friendly error message in this scenario.

Before:

The validate code you entered is incorrect, please try again.

After:

The validation amounts you entered are incorrect. Please double-check your bank statement and try again.

or

Los montos de validación que ingresaste son incorrectos. Verifica tu cuenta de banco e intenta de nuevo.

Fixed Issues

$ #5388

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-09-21 at 2 03 24 PM

Mobile Web

Screen Shot 2021-09-21 at 6 10 55 PM

Desktop

image

iOS

image

Android

Screen Shot 2021-09-21 at 5 48 20 PM

And a spanish example:

image

@puneetlath puneetlath self-assigned this Sep 21, 2021
@puneetlath puneetlath marked this pull request as ready for review September 22, 2021 13:28
@puneetlath puneetlath requested a review from a team as a code owner September 22, 2021 13:28
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team September 22, 2021 13:29
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nickmurray47 nickmurray47 merged commit f7b24d7 into main Sep 22, 2021
@nickmurray47 nickmurray47 deleted the puneet-validate-error branch September 22, 2021 15:46
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nickmurray47 in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants