Attachment preview is cut if the file name is long - @Santhosh-Sellavel

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to a conversation
2. Upload a file with a long name that will not show a preview (like a zip or a mp4)

Expected Result:

The attachment preview should not extend beyond the screen.

Actual Result:

Attachment preview is cut if the file name is long and the download button is not visible.

Workaround:

Upload files with shorter names.

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.7-0

Reproducible in staging?: yes
Reproducible in production?: yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633726212054300?thread_ts=1633726118.053700&cid=C01GTK53T8Q

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Santhosh-Sellavel]

Proposal

1. Add style style={styles.mw100} in here.
   

   App/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.native.js

   Line 27 in ed0eae8

   <Pressable onPress={() => {

2. Add style styles.flexShrink1 in here.
   

   App/src/components/AttachmentView.js

   Line 65 in ed0eae8

   <Text style={[styles.textStrong]}>{props.file && props.file.name}</Text>

Post Fix:

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[chiragsalian]

Demoting to weekly since there is N6 hold on this. @Santhosh-Sellavel your proposal looks good to me. Once puneet posts the issue on Upwork feel free to post your plan there and we'll hire you for the task.

[puneetlath]

@Santhosh-Sellavel created the job and invited you!

[Santhosh-Sellavel]

Applied for the job! Will get started and submit PR soon!

[Santhosh-Sellavel]

cc: @chiragsalian @puneetlath

A heads up here.
When I reported this issue, the filename is not quite long here. Have a look at the attachment in the issue description.
And this issue preview cut-off in chat view which occurred only in native mobile devices.

Here @isagoico described the issue as when filename long preview cuts, so it tested out with a really long filename.
Still, issues that occurred only in native mobile apps, web/desktop still work fine.

But surprisingly while adding an attachment with a really long name break UI in Send Attachment modal and the issue occurs in web/desktop also. This looks like a separate issue to me. If possible I'll try to address this issue also here or will raise it separately to get the issue fixed.

Please post your thoughts in this thanks!

Send Attachment modal UI Break Issue

[chiragsalian]

I was OOO for a couple of days so i'm only just getting to this.

But surprisingly while adding an attachment with a really long name break UI in Send Attachment modal and the issue occurs in web/desktop also. This looks like a separate issue to me. If possible I'll try to address this issue also here or will raise it separately to get the issue fixed.

Yeah, that super long file name feels like another issue so feel free to raise it separately since we might want to pull in designs opinion for it and to decide if its ROI is worth it.

Anyway once your current PR is ready for review can you let me know.

[Santhosh-Sellavel]

@isagoico Can you help me setup this -> #5755 (comment) as an seperate issue.

[Santhosh-Sellavel]

@chiragsalian PR is here #5969

Did you check these out?

[chiragsalian]

Ah i missed that you said its ready for review in the PR. I'll assign it to me so that its on my plate for review. Thanks for the bump.

[isagoico]

Created an issue for this here

#6157

[Santhosh-Sellavel]

Wondering why the payment date is not updated in the title yet, PR is deployed to production 7 days ago refer #5969 (comment)

[puneetlath]

Sorry about that @Santhosh-Sellavel. I'm not sure why that's happening. I'll have the team look into it.

In the meantime, I've gone ahead and paid the contract out.

[Santhosh-Sellavel]

@puneetlath You've ended the wrong contract!

[mountiny]

The problem here was that Exported label was not added, which is a requirement for the comment to work.

[puneetlath]

Ah got it! Thanks for the explanation @mountiny.

[Christinadobrzyn]

Closed this job https://www.upwork.com/ab/applicants/1449105733264527360/job-details (internal) & https://www.upwork.com/jobs/~011a863672a9e9645d (external) and paid @Santhosh-Sellavel!