Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment preview cut out in comments fixed #5969

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Attachment preview cut out in comments fixed #5969

merged 2 commits into from
Oct 29, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

Details

Fixed Issues

$ #5755

Tests & QA Steps

  1. Send a non-preview attachment file to any user chat.
  2. Open and view the attachment preview on iOS & Android devices.
  3. Now attachment preview will not cut off now.

Tested On

  • iOS
  • Android

Screenshots

iOS

Simulator Screen Shot - iPhone 12 - 2021-10-21 at 03 49 12

Android

Screenshot_1634768343

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner October 20, 2021 22:29
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team October 20, 2021 22:29
@Santhosh-Sellavel
Copy link
Collaborator Author

@chiragsalian This one is ready for review.

@Santhosh-Sellavel Santhosh-Sellavel mentioned this pull request Oct 29, 2021
Closed
@chiragsalian chiragsalian requested review from chiragsalian and removed request for puneetlath October 29, 2021 21:14
chiragsalian
chiragsalian approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works well.

@chiragsalian chiragsalian merged commit 5a1e87f into Expensify:main Oct 29, 2021
@OSBotify OSBotify mentioned this pull request Oct 29, 2021
Closed
23 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.11-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Christinadobrzyn Christinadobrzyn mentioned this pull request Nov 2, 2021
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2021

🚀 Deployed to production by @yuwenmemon in version: 1.1.12-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Santhosh-Sellavel @OSBotify @chiragsalian