Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$4000] Android - Login - Login box moving up when tapping inside the field #6941

Closed
kavimuru opened this issue Dec 29, 2021 · 113 comments
Closed
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Dec 29, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Tap in the login input field

Expected Result:

Login page shouldn't move up when the keypad opens to input login email address

Actual Result:

On the login page, when opening the keyboard, the page is shifted up.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: v1.1.24-0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5390564_20211229_171816.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Dec 29, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aldo-expensify
Copy link
Contributor

@kavimuru Did it scroll up by itself after you opened the keyboard?

I tried to reproduce this in my phone and didn't happen (failed to make a video):

@mvtglobally
Copy link

@aldo-expensify, 2 different testers were able to reproduce this issue on Android. I will collect more info and share shortly.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Dec 29, 2021 via email

@mvtglobally
Copy link

@aldo-expensify
We have 2 testers with SG A50 - Android 11 & SG S21 - Android 12 able to reproduce the issue
and 2 testers with SG S10 - Android 10 & Pixel 4 - Android 11 Unable to repro
I am not sure at this point if this is a device specific issue or anything else is causing it. But it definitely not impacting every user

@aldo-expensify
Copy link
Contributor

Thanks @mvtglobally

We have 2 testers with SG A50 - Android 11 & SG S21 - Android 12 able to reproduce the issue

Is it possible for these 2 testers to test it in production? If the issue is in production also, we can remove this as a deploy blocker.

@mvtglobally
Copy link

1 tester of 2 was able to repro in Prod. Removing DeployBlocker label

@mvtglobally mvtglobally removed the DeployBlockerCash This issue or pull request should block deployment label Dec 31, 2021
@cead22 cead22 added Daily KSv2 Improvement Item broken or needs improvement. and removed Hourly KSv2 labels Jan 3, 2022
@cead22 cead22 removed their assignment Jan 3, 2022
@flodnv flodnv added the External Added to denote the issue can be worked on by a contributor label Jan 6, 2022
@MelvinBot
Copy link

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@dylanexpensify
Copy link
Contributor

@MelvinBot MelvinBot removed the Overdue label Jan 6, 2022
@botify botify removed the Daily KSv2 label Jan 6, 2022
@MelvinBot MelvinBot added the Weekly KSv2 label Jan 6, 2022
@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 6, 2022
@parasharrajat
Copy link
Member

@liyamahendra Your video is not representing this issue. That scrolling is desired.

@MTN718
Copy link
Contributor

MTN718 commented Jun 20, 2022

I think this issue is same as this #9122

And this is my proposal. It can resolve this issue too I think.

#9122 (comment)

@parasharrajat
Copy link
Member

parasharrajat commented Jun 20, 2022

I think this issue is the same as this #9122

Good Catch! I will debug this and another issue. Don't know yet. But we do want the Main Continue button and forgot links to be above the keyboard.

@MTN718
Copy link
Contributor

MTN718 commented Jun 20, 2022

then it makes move up logo and description text because its height different with email form height so when change screen, it moves up.

@parasharrajat
Copy link
Member

Update: it seems that nobody is able to successfully reproduce this so far apart from the QA team. Based on the comments, I feel this exists within the APP.

I will try to debug this and share my analysis. I have couple of thoughts on why it might be happening.

@ahmdshrif
Copy link
Contributor

ahmdshrif commented Jun 20, 2022

@parasharrajat If this is the issue . I can reproduce it .

But @mvtglobally mentioned before it's happening automatically. That's why i say i can't repro it on any device . It's happening only when i scroll not automatically.

you agree on this comment #6941 (comment)
and maria say here it's automatedly #6941 (comment)

Screen_Recording_20220621-003043_New.Expensify.mp4

@melvin-bot melvin-bot bot added the Overdue label Jun 29, 2022
@adelekennedy
Copy link

Where are we with this issue? I go the doubling ping but it sounds like we're still unsure if this is reproducible - should we put this issue on hold? @parasharrajat @mountiny

@mountiny
Copy link
Contributor

I think you meant to tag Tim, but he is OOO. Given there are some problems with reproducing this particular issue, I would not double yet but try to maybe ask Applause (@kavimuru) to improve the reproduction steps and make it clearer what actually is not working as that will also help the contributors in solving this.

@kavimuru
Copy link
Author

kavimuru commented Jul 4, 2022

@mountiny I have updated the steps.
When the keypad opens up to write in the email field, the input field moves up and partially hidden.

@mountiny
Copy link
Contributor

mountiny commented Jul 4, 2022

Thanks @kavimuru!

@liyamahendra
Copy link
Contributor

@kavimuru does the page automatically move up or you mean to say when the page is scrolled up completely the input field is partially hidden?

@tgolen
Copy link
Contributor

tgolen commented Jul 4, 2022

Not overdue. Still getting proposals.

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2022
@kavimuru
Copy link
Author

kavimuru commented Jul 4, 2022

@liyamahendra The page automatically moved up. But now the same tester could not repro this issue in the build 1.1.79.13

new.dot.0407.mp4

@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2022
@parasharrajat
Copy link
Member

Ok, Let's wait for another week.

@melvin-bot melvin-bot bot removed the Overdue label Jul 13, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2022
@tgolen
Copy link
Contributor

tgolen commented Jul 25, 2022

Two weeks have passed here, what do we think? Is it still an issue or should we close this?

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2022
@aneequeahmad
Copy link
Contributor

I can still reproduce this issue on Huwawei A-9

cc" @tgolen @parasharrajat

@parasharrajat
Copy link
Member

Good @aneequeahmad. Could you please record a video and reproduction steps in detail? They can be technical as well.

@aneequeahmad
Copy link
Contributor

aneequeahmad commented Jul 28, 2022

WhatsApp.Video.2022-07-28.at.12.35.59.PM.mp4

Actions Performed:

  • Open app on Android (Huwawei Y9 prime, Huwawei y7 prime).
  • Tap on input field to focus(First focus doesn't move up login box sometimes).
  • Enter email address and press continue.
  • On password page input is focused and password box moves up.
  • Tap outside password field to blur and dismiss keyboard.
  • Tap on password field again and see box moves up.
  • Press Go back from password page and dismiss the keyboard on email page.
  • Tap on Phone or Email and see the box moves up.

Platform
Android

Version
1.1.86-4

cc: @parasharrajat, @tgolen

Let me know if anything else should be added Thanks

@parasharrajat
Copy link
Member

Of, I see. But the video does not show the bug we are trying to solve. It seems you are still confused about what the real issue is.

We are good to close this and reopen if this comes back.

@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2022
@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests