Deploy Checklist: New Expensify 2021-12-29

[OSBotify]

Release Version: 1.1.24-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update Address search - show all inputs #6569

  • QA
  • Accessibility

• Anthony remove second secure inputs #6809

  • QA
  • Accessibility

• Changed the Amount Text to TextInput #6811

  • QA
  • Accessibility

• Corrected - IOU Cursor is set to pointer in IOU preview #6832

  • QA
  • Accessibility

• Rename ExpensifyText #6835

  • QA
  • Accessibility

• Show permission error dialog only when storage permission is denied or missing #6840

  • QA
  • Accessibility

• Clean up ReimbursementAccountUtils #6843

  • QA
  • Accessibility

• validate value in "Name on card" field #6845

  • QA
  • Accessibility

• Refactor BankAccountSetup using nextStepValues to force Chase manual account numbers #6851

  • QA
  • Accessibility

• Initial Setup for wallet Transfer #6852

  • QA
  • Accessibility

• Increase upload size for avatar image #6864

  • QA
  • Accessibility

• fix overlapping text #6880

  • QA
  • Accessibility

• Hide Keyboard shortcuts menu in Native Devices #6881

  • QA
  • Accessibility

• Add onfido logs #6892

  • QA
  • Accessibility

• [NO QA] Minor refactor - polish #6897

  • QA
  • Accessibility

• fix: New chat aren't showing bold in Left Hand Nav #6898

  • QA
  • Accessibility

• Fix IOU Page #6909

  • QA
  • Accessibility

Internal QA:

• Adjusting IOUModal and adding createAndPayIOU #4329 - @nkuoch @nickmurray47 @mountiny

Deploy Blockers:

• VBA - Placeholder text for address field in company information page is displayed as "Personal address" #6928
• mWeb - New Room- Button ''New room'' is not floating #6929
• [HOLD for payment 2022-01-27] Mac - Safari - IOU - Unable to paste the amount copied from notes  #6931
• Android - White screen displayed after log out #6932
• Android - White screen displayed after log out #6933
• Staging/Dev: Adding VBA using plaid bounces the user to manual step of adding Routing/Account number #6940
• [$4000] Android - Login - Login box moving up when tapping inside the field #6941
• [HOLD for payment 2022-01-11] PayPal.me link redirects to Undefined account  #6947
• Android/IOS - Undefined showed instead of phone number after Pay by Venmo #6948

cc @Expensify/applauseleads

[mvtglobally]

Starting QA

[mountiny]

@nickmurray47 The InternalQA PR #4329 will not be available to QA until Web-E PR https://github.com/Expensify/Web-Expensify/pull/32181 will be deployed, right?

[nickmurray47]

Ah yes, that's correct @mountiny!

[mvtglobally]

@yuwenmemon @roryabraham We are still waiting for IOS and Desktop builds. Can you please check

[aldo-expensify]

I think this may be a regression: #6940

I haven't been able to test if this problem is in production because I don't have bank credentials to test there.

[aldo-expensify]

Removed deploy blocker label from #6931 because of reasons exposed here: #6931 (comment)

[mountiny]

@nickmurray47 Therefore I have check the PR off. We will QA it together with the Web-E PR and all the features are under beta so no need to worry about that.

[mvtglobally]

Checking off #6947. It has been fixed

[mvtglobally]

Regression is complete

Issues logged

1. VBA - Placeholder text for address field in company information page is displayed as "Personal address" #6928
2. [HOLD for payment 2022-01-27] Mac - Safari - IOU - Unable to paste the amount copied from notes  #6931
3. mWeb - New Room- Button ''New room'' is not floating #6929
4. Android - White screen displayed after log out #6932
5. [$4000] Android - Login - Login box moving up when tapping inside the field #6941
6. Android/IOS - Undefined showed instead of phone number after Pay by Venmo #6948

Pending PRs
Checking off #6569 as #6928 is fixed
#6811 is failing due to #6931

[mvtglobally]

Checking off #6948. Re-test is a pass

[mvtglobally]

Checking off #6932 . Re-test is a pass

[mvtglobally]

@francoisl Are we good to check off #6811 since #6931 is no longer a blocker?
It would be great if we can close this checklist today and get a new deploy to QA.

[francoisl]

@mvtglobally Yes looks like it. Also, I see that there are other issues that are still marked as deploy blockers above, but had their blocker label removed since they were added, namely:

• mWeb - New Room- Button ''New room'' is not floating #6929
• [$4000] Android - Login - Login box moving up when tapping inside the field #6941

And then, #6932 is confirmed to be fixed, so it would mean all deploy blockers are cleared and we can deploy?

[mvtglobally]

Checking off
#6811 & #6931 as deploy blocker was removed
#6929 #6929 (comment)
#6941 #6941 (comment)

[mvtglobally]

all blockers have been resolved.
This is the only pending item #4329 - Internal QA

[francoisl]

Internal QA done for #4329

[francoisl]

[francoisl]

Going to rerun this, hoping that it fixes https://expensify.slack.com/archives/C03V9A4TB/p1641234691374100

[francoisl]

[francoisl]

[francoisl]

[francoisl]

Sorry for the multiple reopens, we're trying to fix various issues with the deploy today. That last one mostly worked, but there was an issue with creating a new deploy checklist because the release version in the original message of this issue was wrong. I'm going to change it to 1.1.24-8 and close again.

[francoisl]