Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Minor refactor - polish #6897

Merged
merged 2 commits into from
Dec 23, 2021
Merged

[NO QA] Minor refactor - polish #6897

merged 2 commits into from
Dec 23, 2021

Conversation

aldo-expensify
Copy link
Contributor

Details

Addressing NAB comments

  • Update comment
  • Do trim() before comparing length of street text in AddressSearch
  • Move renamedFields map (object) into the callback for consistency

Fixed Issues

#6569 (comment)
#6569 (comment)
#6569 (comment)

Tests

  1. Create New dot account
  2. Start add VBA flow
  3. Check that address related fields in Company step are still working

@aldo-expensify aldo-expensify requested a review from a team as a code owner December 23, 2021 21:54
@aldo-expensify aldo-expensify removed the request for review from a team December 23, 2021 21:54
@aldo-expensify aldo-expensify self-assigned this Dec 23, 2021
@marcaaron marcaaron merged commit 8a26663 into main Dec 23, 2021
@marcaaron marcaaron deleted the aldo_minor-polish-address-fields branch December 23, 2021 22:44
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 29, 2021
Closed
44 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.23-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcaaron marcaaron marcaaron approved these changes

@TomatoToaster TomatoToaster Awaiting requested review from TomatoToaster

Assignees

@aldo-expensify aldo-expensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aldo-expensify @OSBotify @marcaaron