Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected - IOU Cursor is set to pointer in IOU preview #6832

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

PrashantMangukiya
Copy link
Contributor

@parasharrajat @mallenexpensify PR is ready for review.

Details

User can see pointer when mouse over on IOU Preview in details modal at RHN, but there is no action occurring when clicking on it. So in this PR corrected cursor behaviour. i.e. Now it will show default cursor when mouse over on IOU Preview. This cursor behaviour is visible on Web and Desktop version.
Proposal: #6693 (comment)

Fixed Issues

$ #6693

Tests | QA Steps

  1. Login
  2. Request money from someone.
  3. From chat list click on IOU Preview
  4. It will open details window in RHN
  5. Hover cursor over IOU Preview shows in RHN (amount and user details box)

QA Check: Within Web and Desktop it will show default cursor because it is not clickable. (previously it was showing pointer).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web.mov

Mobile Web

MobileWeb.mov

Desktop

Desktop.mov

iOS

iOS.mov

Android

Android.mov

@PrashantMangukiya PrashantMangukiya requested a review from a team as a code owner December 18, 2021 05:45
@MelvinBot MelvinBot requested review from parasharrajat and stitesExpensify and removed request for a team December 18, 2021 05:45
src/components/ReportActionItem/IOUPreview.js Outdated Show resolved Hide resolved
src/styles/styles.js Outdated Show resolved Hide resolved
src/pages/iou/IOUDetailsModal.js Outdated Show resolved Hide resolved
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @stitesExpensify

@stitesExpensify stitesExpensify merged commit a5d3259 into Expensify:main Dec 28, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.23-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants