Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overlapping text #6880

Merged
merged 1 commit into from
Dec 22, 2021
Merged

fix overlapping text #6880

merged 1 commit into from
Dec 22, 2021

Conversation

thesahindia
Copy link
Member

Details

fixed overlapping text and made the view scrollable

Fixed Issues

$ #6826

Tests

QA Steps

  1. Go to app
  2. Create a new workspace if you don't have one
  3. Click "+" > New room

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Screenshot 2021-12-23 at 12 40 04 AM

Desktop

iOS

Android

Screenshot 2021-12-23 at 12 38 48 AM

@thesahindia thesahindia requested a review from a team as a code owner December 22, 2021 19:20
@MelvinBot MelvinBot requested review from parasharrajat and tgolen and removed request for a team December 22, 2021 19:20
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small change and works great on Web | Desktop so not asking from screenshots for other platforms.

LGTM.
cc: @tgolen

@tgolen tgolen merged commit ff04827 into Expensify:main Dec 22, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @tgolen in version: 1.1.23-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants