Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High]: Chrome+JAWS: Screen reader: Role is not defined for control. #8393

Closed
SumitDiyora opened this issue Mar 31, 2022 · 1 comment
Closed

Comments

@SumitDiyora
Copy link

SumitDiyora commented Mar 31, 2022

Action Performed:

  1. Using Chrome+JAWS, open URL: staging.new.expensify.com
  2. Navigate to Settings > Workspace > Manage members > Invite
  3. Navigate to the 'Invite' control using the screen reader.
  4. Observe the screen reader announcement.

Expected Result:

Role should be defined as a 'button' for the "Invite" control.

Actual Result:

Role is not defined for the "Invite" control. This made it difficult for screen reader users to access the functionality associated with it.

Other Occurrences:

Similar type of issue repro on PRs #8143, #8017, #8039, #8019, #8196, #8452, #8448, #7362, #8256, #8584, #8694,#8969, #8878, #9144,
Same issue repro on PR #8494 -Role is not defined for new group.
Same issue repro on PR #9369, #9056, #9550 -Role is not defined for 'Save' button.
Same issue repro on PR #9144 -Role is not defined for 'Create group' button.
Same issue repro on PR #9351 -Role is not defined for 'Confirm' button.
Same issue repro on PR #9400 -Role is not defined for 'Close Account' button.
Same issue repro on PR #9348 -Role is not defined for 'Add a payment method' button.
Same issue repro on PR #9347 -Role is not defined for 'Invite' and 'Remove' button.
Same issue repro on PR #9472 -Role is not defined for 'Next' button.
Same issue repro on PR #9486 -Role is not defined for 'Call me' button.
Same issue repro on PR #9502 -Role is not defined for 'Download','Copy to clipboard','Copy link','Mark as read','Delete' button.

Workaround:

Yes

Area issue was found in:

Invite new members

Failed WCAG checkpoints

4.1.2

User impact:

Screen reader users will not be made aware that these elements are buttons.

Suggested resolution:

Ensure that all the page functionality is available for all users irrespective of the device being used.
Apply the following changes:

  • Specify role="button" for the 'div' element containing the "Invite" control.

Platform:

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.49-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Reference link: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role
Issue reported by: Sumit

#7920_Role and label not defined for Invite control

@melvin-bot
Copy link

melvin-bot bot commented Jun 17, 2022

@SumitDiyora, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants