fix footer message overflow

[thesahindia]

Details

The footer message flows out of the container when the email is long. This PR fixes that.

Fixed Issues

$ #8520

Tests | QA Steps

1. Create a new workspace from an account that's on the policyExpenseChat beta (e.g @expensifail.com)
2. Add a new member with a big email to the workspace via Manage Members > Invite
3. Log-in as the member and send a message in the member's workspace chat
4. Log back in again to the admin account and remove the member from the workspace via Manage Members > Remove
5. Now log-in as the member again and navigate to the workspace chat
6. Verify the message doesn't go out of the container and you can see the whole message.

• Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • Any functional components have the displayName property
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose and it is
• If a new CSS style is added I verified that:
  • A similar style doesn’t already exist
  • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • Any functional components have the displayName property
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn’t already exist
  • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[thesahindia]

Ios native app stays unchanged

[Santhosh-Sellavel]

@toglen we have one more block problem here, what should we do now?

[Santhosh-Sellavel]

bump @tgolen!

[tgolen]

Yeah, I don't know what to do. It can't be fixed? Seems like a strange way for it to wrap the text. If it can't be fixed, then maybe plan B would be to just remove the email address from the message entirely (this was an alternative mentioned in the original GH I believe).

[thesahindia]

Yeah, I don't know what to do. It can't be fixed?

I think it's how ios native app wraps the text because on android it was working fine even without using breakAll.

Maybe plan B would be to just remove the email address from the message entirely (this was an alternative mentioned in the original GH I believe).

I don't think that would be a good solution because that's only one case, we also show the email in some other cases (e.g. user merged his account or deleted his account)

I will try to fix this on ios or will try to find a new approach, the worst case scenario would be to leave it as it is because I don't think most people have big emails also I think we show the user's name and we only show email when there's no name set at profile, right?

[tgolen]

Yeah, then I guess we just have to figure out how to fix that word wrapping.

…

On Wed, May 11, 2022 at 3:07 AM Sahil ***@***.***> wrote: Yeah, I don't know what to do. It can't be fixed? Seems like a strange way for it to wrap the text. If it can't be fixed, then maybe plan B would be to just remove the email address from the message entirely (this was an alternative mentioned in the original GH I believe). I don't think that would be a good solution because that's only one case, we also show the email in some other cases (e.g. user merged his account or deleted his account) — Reply to this email directly, view it on GitHub <#8878 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB3RJ55YCXAGSYSOWVLVJN2GFANCNFSM5VDM3L2A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[thesahindia]

I think we can't fix this. I tried adding different styles but nothing worked. To verify that it's not related to our code, I used View and added Text component inside it and got the same results. I think this is how ios wraps the text.

cc: @tgolen

[deetergp]

@thesahindia Have you tried hard seetting textBreakStategy to see if it addresses the issue in iOS? https://stackoverflow.com/questions/53236569/what-is-the-difference-between-simple-highquality-balanced-for-textbreakstrate

[deetergp]

I also don't think we necessarily need to get too held up on this, as it does not seem to be an uncommon practice. Here's an example of similar behavior from a Google Doc I was working that wraps similarly:

[thesahindia]

@deetergp, It's not working for ios and also we are actually using RenderHTML here so we are only limited to css.

[deetergp]

@thesahindia I understand that it's not working for iOS. Unless I have misread this thread, we're saying that it currently looks right in Android but "wrong" (which is debatable) in iOS. The SO I linked says that by default Android uses textBreakStrategy: highQuality on Text objects, which implies that maybe iOS doesn't. I was asking if had tried hard setting it so it's textBreakStrategy: highQuality for iOS as well.

[thesahindia]

Ah my bad, I wanted to say that I tried it but it didn't work.

[deetergp]

I think this wrapping is fine as it is and separate from what we were trying to fix here. I'm going to accept it and if we feel that something needs to be done about it, we can open another issue and put it out for proposals.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[Santhosh-Sellavel]

Okay 👍🏼

[Santhosh-Sellavel]

we can open another issue and put it out for proposals.

Ya, we should do that. Can you straight away put up an issue on GH?
@deetergp

[OSBotify]

🚀 Deployed to staging by @deetergp in version: 1.1.70-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @deetergp in version: 1.1.70-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @deetergp in version: 1.1.70-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.1.71-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅