-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the breaking of email at close account page #9400
fix the breaking of email at close account page #9400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thesahindia Please try to keep the QA steps and test separate on each PR. On the other hand, QA steps are non technical steps to verify the solution against the issue. Both of them can be similar but try to keep the QA steps at it position in the template even though points are duplicated between tests and QA steps. |
@parasharrajat, yeah sure will remember the next time. |
@thesahindia Email appears below the "Default contact method" text only if the email is longer. If the email is shorter appears beside "Default contact method" text. Its repro in android and iOS app. Issue #9229 is partially fixed. |
@kavimuru It was designed this way and it's expected. |
Not 100% sure, but I think this might have caused a new crash on Android. |
🚀 Deployed to production by @roryabraham in version: 1.1.76-5 🚀
|
Details
At close account page long email breaks and takes another line, this PR fixes that.
Fixed Issues
$ #9229
Tests | QA Steps
.
(dot)PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Mobile Web
Desktop
iOS
Android