Add new API method SetPasswordForNewUserAndSignin #10244

MonilBhavsar · 2022-08-04T13:12:45Z

Details

Adds a new API call SetPasswordForNewAccountAndSignin
Updates to use errors object instead of string in ACCOUNT and SESSION Onyx keys

Fixed Issues

https://github.com/Expensify/Expensify/issues/218819

Tests

Checkout this branch in Web-E and run newdot app

Enter a new user email in Signin.
In Web-E run php script/notifyall.php to get the validation link
Click on validation link and set the new password for account
Ensure you are sucessfully authenticated and appropriate ACCOUNT and SESSION Onyx keys are set.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Enter a completely different email in signin page
Click on the validation link received in email/sms
Set password for new account and ensure you're authenticated
Signout and Signin and ensure it works

Feel free to repeat above steps for email and phone login

Verify that no errors appear in the JS console

Screenshots

Offline

Web

Mobile Web

Desktop

Unable to test the workflow on App.
Issue and discussion

iOS

Android

JmillsExpensify · 2022-09-01T09:13:19Z

Can't we take this one off hold now that 34698 was merged yesterday? Or do we need to that PR to hit production first?

MonilBhavsar · 2022-09-01T09:19:59Z

Yes, wait till it hits production and I'll push some more changes to this PR

JmillsExpensify · 2022-09-06T12:00:22Z

34698 hit production yesterday so I'm taking this one off hold. Do you expect to have this up for review today?

MonilBhavsar · 2022-09-07T16:56:15Z

Reviewers, Suppressing cyclic dependency lint errors until we fix it.
Has asked for a help here https://expensify.slack.com/archives/C03TQ48KC/p1662562289708789

melvin-bot · 2022-09-07T17:13:53Z

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

MonilBhavsar · 2022-09-15T04:44:01Z

Off hold

danieldoglas

LGTM, just a little question.

danieldoglas · 2022-09-15T12:24:43Z

src/libs/actions/Session/index.js

@@ -348,7 +348,7 @@ function setPassword(password, validateCode, accountID) {
            }

            // This request can fail if the password is not complex enough
-            Onyx.merge(ONYXKEYS.ACCOUNT, {error: response.message});
+            Onyx.merge(ONYXKEYS.ACCOUNT, {errors: {[DateUtils.getMicroseconds()]: response.message}});


Can't we use Localize.translateLocal here?

We could. One way I can think of is to map error codes with localize phrases and get the appropriate phrase when we receive the response code from the mapping. We do that for Authentication call.
But since, we're deprecating this API call soon, I think we can skip this for now.

Apparently the linter disagrees with you haha - it's requiring the change...

dangrous

Thanks for your patience while I looked into testing. This makes sense to me!

iwiznia · 2022-09-16T11:49:28Z

Error: 351:51 error Use Localize.translateLocal('i18n.key') over hard coded messages rulesdir/prefer-localization

This lint error is a mistake, the linter has a bug and should only be throwing if the message is a hardcoded string. So it's safe to merge without this passing and create a new issue to fix that separately.

MonilBhavsar · 2022-09-16T11:50:35Z

@dangrous @danieldoglas could you complete the PR Reviewers checklist 🙏

dangrous · 2022-09-16T19:54:10Z

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

dangrous · 2022-09-16T21:09:17Z

Checklist is checklisted! I'll attempt to rerun that checklist check, then will go ahead and merge either way since it IS all checked.

melvin-bot · 2022-09-16T21:13:33Z

@dangrous looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

dangrous · 2022-09-16T21:14:45Z

As noted above - the failed test is a linting error, we'll be updating that separately.

francoisl · 2022-09-16T21:28:55Z

The lint error made the merge action here fail. I think it's mostly fine because there's an open deploy checklist open so it wouldn't have needed to be deployed to staging anyway, but can someone follow up with a PR to fix the lint issue please?

src/libs/actions/Session/index.js

src/libs/actions/SignInRedirect.js

luacmartins · 2022-09-16T22:32:04Z

In addition to my comments above, please do not merge PRs with failing tests. Anyone that merges main into their PRs will have issues and it will block them until the lint error is resolved (this just happened to me)

dangrous · 2022-09-16T22:34:47Z

Ack, sorry about that! Will definitely not do in the future. I didn't realize that would cause trouble outside of this specific process, and was following the comment thread above

luacmartins · 2022-09-16T22:46:44Z

PR to fix the lint error - #11075

OSBotify · 2022-09-19T16:47:58Z

🚀 Deployed to staging by @dangrous in version: 1.2.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2022-09-19T16:58:17Z

🚀 Deployed to staging by @dangrous in version: 1.2.2-0 🚀

This seems wrong? I do not deploy...

luacmartins · 2022-09-19T17:36:15Z

@dangrous that is correct! App PRs are deployed to staging when they are merged, unless the checklist is locked in which case they are deployed once a new checklist is created or the current one is unlocked. This differs for a production deploy, since the deployer is actually the App deployer. You can read more about the process here.

Since you merged this PR, you technically deployed it to staging 🙌

OSBotify · 2022-09-20T14:23:23Z

🚀 Deployed to production by @luacmartins in version: 1.2.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham · 2022-09-23T00:21:18Z

Is there a follow-up issue somewhere to fix the require cycle this introduced?

MonilBhavsar · 2022-09-23T04:44:17Z

Yes, here it is #11102

Add new API method SetPasswordForNewUserAndSignin

e9ad92f

MonilBhavsar self-assigned this Aug 4, 2022

Merge branch 'main' into monil-setPasswordRefactor

51807fc

MonilBhavsar changed the title ~~[HOLD Web-E #34508] Add new API method SetPasswordForNewUserAndSignin~~ [HOLD Web-E #34698] Add new API method SetPasswordForNewUserAndSignin Aug 31, 2022

robertjchen previously approved these changes Aug 31, 2022

View reviewed changes

Merge branch 'main' into monil-setPasswordRefactor

67bc64e

Handle API call and change button text

41671c7

MonilBhavsar dismissed robertjchen’s stale review via 41671c7 September 2, 2022 08:52

MonilBhavsar added 4 commits September 2, 2022 17:55

Update errors to error

f4e191d

Prevent setting empty error

2394c80

Merge branch 'main' into monil-setPasswordRefactor

f771214

Update error props and displaying error

233aa13

JmillsExpensify changed the title ~~[HOLD Web-E #34698] Add new API method SetPasswordForNewUserAndSignin~~ Add new API method SetPasswordForNewUserAndSignin Sep 6, 2022

MonilBhavsar added 2 commits September 7, 2022 17:54

Use errors object in Onyx key

1e5a1ec

Suppress cyclic dependency error temporarily

a48e38a

MonilBhavsar marked this pull request as ready for review September 7, 2022 16:55

MonilBhavsar requested a review from a team as a code owner September 7, 2022 16:55

melvin-bot bot requested review from pecanoro and removed request for a team September 7, 2022 16:55

pecanoro previously approved these changes Sep 7, 2022

View reviewed changes

robertjchen previously approved these changes Sep 7, 2022

View reviewed changes

MonilBhavsar changed the title ~~Add new API method SetPasswordForNewUserAndSignin~~ [HOLD] Add new API method SetPasswordForNewUserAndSignin Sep 7, 2022

Fix lint error by using multilingual error message

7f9d0ca

MonilBhavsar dismissed stale reviews from robertjchen and pecanoro via 7f9d0ca September 7, 2022 17:51

melvin-bot bot requested a review from danieldoglas September 14, 2022 19:21

MonilBhavsar changed the title ~~[HOLD Web-E #34757] Add new API method SetPasswordForNewUserAndSignin~~ Add new API method SetPasswordForNewUserAndSignin Sep 15, 2022

MonilBhavsar mentioned this pull request Sep 15, 2022

Refactor to use SignInUser #10811

Merged

91 tasks

danieldoglas approved these changes Sep 15, 2022

View reviewed changes

dangrous approved these changes Sep 15, 2022

View reviewed changes

dangrous merged commit 60cf2f7 into main Sep 16, 2022

dangrous deleted the monil-setPasswordRefactor branch September 16, 2022 21:13

melvin-bot bot added the Emergency label Sep 16, 2022

francoisl removed the Emergency label Sep 16, 2022

luacmartins reviewed Sep 16, 2022

View reviewed changes

src/libs/actions/Session/index.js Show resolved Hide resolved

src/libs/actions/SignInRedirect.js Show resolved Hide resolved

luacmartins mentioned this pull request Sep 16, 2022

[No QA] Fixes lint errors on main #11075

Merged

93 tasks

MonilBhavsar mentioned this pull request Sep 19, 2022

[HOLD for payment 2022-10-24] [$250] Resolve cyclic dependencies lint errors #11102

Closed

OSBotify mentioned this pull request Sep 19, 2022

Deploy Checklist: New Expensify 2022-09-19 #11108

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new API method SetPasswordForNewUserAndSignin #10244

Add new API method SetPasswordForNewUserAndSignin #10244

MonilBhavsar commented Aug 4, 2022 •

edited

Loading

JmillsExpensify commented Sep 1, 2022

MonilBhavsar commented Sep 1, 2022

JmillsExpensify commented Sep 6, 2022

MonilBhavsar commented Sep 7, 2022

melvin-bot bot commented Sep 7, 2022

MonilBhavsar commented Sep 15, 2022

danieldoglas left a comment

danieldoglas Sep 15, 2022

MonilBhavsar Sep 15, 2022 •

edited

Loading

dangrous Sep 15, 2022 •

edited

Loading

dangrous left a comment

iwiznia commented Sep 16, 2022

MonilBhavsar commented Sep 16, 2022

dangrous commented Sep 16, 2022 •

edited

Loading

PR Reviewer Checklist

dangrous commented Sep 16, 2022 •

edited

Loading

melvin-bot bot commented Sep 16, 2022

dangrous commented Sep 16, 2022

francoisl commented Sep 16, 2022

luacmartins commented Sep 16, 2022

dangrous commented Sep 16, 2022

luacmartins commented Sep 16, 2022 •

edited

Loading

OSBotify commented Sep 19, 2022

dangrous commented Sep 19, 2022 •

edited

Loading

luacmartins commented Sep 19, 2022

OSBotify commented Sep 20, 2022

roryabraham commented Sep 23, 2022

MonilBhavsar commented Sep 23, 2022

Add new API method SetPasswordForNewUserAndSignin #10244

Add new API method SetPasswordForNewUserAndSignin #10244

Conversation

MonilBhavsar commented Aug 4, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Offline

Web

Mobile Web

Desktop

iOS

Android

JmillsExpensify commented Sep 1, 2022

MonilBhavsar commented Sep 1, 2022

JmillsExpensify commented Sep 6, 2022

MonilBhavsar commented Sep 7, 2022

melvin-bot bot commented Sep 7, 2022

MonilBhavsar commented Sep 15, 2022

danieldoglas left a comment

Choose a reason for hiding this comment

danieldoglas Sep 15, 2022

Choose a reason for hiding this comment

MonilBhavsar Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

dangrous Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

iwiznia commented Sep 16, 2022

MonilBhavsar commented Sep 16, 2022

dangrous commented Sep 16, 2022 • edited Loading

PR Reviewer Checklist

dangrous commented Sep 16, 2022 • edited Loading

melvin-bot bot commented Sep 16, 2022

dangrous commented Sep 16, 2022

francoisl commented Sep 16, 2022

luacmartins commented Sep 16, 2022

dangrous commented Sep 16, 2022

luacmartins commented Sep 16, 2022 • edited Loading

OSBotify commented Sep 19, 2022

dangrous commented Sep 19, 2022 • edited Loading

luacmartins commented Sep 19, 2022

OSBotify commented Sep 20, 2022

roryabraham commented Sep 23, 2022

MonilBhavsar commented Sep 23, 2022

MonilBhavsar commented Aug 4, 2022 •

edited

Loading

MonilBhavsar Sep 15, 2022 •

edited

Loading

dangrous Sep 15, 2022 •

edited

Loading

dangrous commented Sep 16, 2022 •

edited

Loading

dangrous commented Sep 16, 2022 •

edited

Loading

luacmartins commented Sep 16, 2022 •

edited

Loading

dangrous commented Sep 19, 2022 •

edited

Loading