[HOLD for payment 2023-01-19] [$2000] Feature Request: Open link in Desktop app if it is installed and not in browser

[MonilBhavsar]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Have desktop app installed
2. Create a new account on desktop app
3. Click the validation link from email

Expected Result:

Link should open in Desktop app

Actual Result:

Link always open in browser

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
For users:
They can still use the app on web and then move to desktop

For contributors:
None
I think contributors are not able to test the workflow on the desktop app

Platform:

Where is this issue occurring?

• Web
• Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork job URL: https://www.upwork.com/jobs/~01c5b3dd89b6a749b1
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662630927711119

View all open jobs on GitHub

Slack handles this nicely! If desktop app is installed, Link opens in app and they ask if one wants to open it in the browser.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

Sounds cool, passing this on to engineering!

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[madmax330]

@MonilBhavsar I think this can be external yeah?

[MonilBhavsar]

Yes 👍

[madmax330]

Cool

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Santhosh-Sellavel]

PR is merged, and awaiting deployment!

[Christinadobrzyn]

I'll take this GH back @mallenexpensify thank you for watching it!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.52-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Desktop deeplink #13606

If no regressions arise, payment will be issued on 2023-01-19. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Santhosh-Sellavel]

@Christinadobrzyn

We can continue the discussion regarding the bounty increase request on this one while we wait the regression period.

cc: @cowboycito

[cowboycito]

@Santhosh-Sellavel how should we proceed for payment?
cc @Christinadobrzyn @NikkiWines

[Santhosh-Sellavel]

@cowboycito
You've requested an increase in compensation while working on the proposal here.

But then we are not sure about how long/complex it might take, I've replied here

Again this is too early, we can discuss it once the issue is completed.

Now the job is done I've initiated the discussion here waiting for it CM.

Meanwhile, let us know what you think is a fair amount. I'll post internally let us get it sorted thanks!
cc: @NikkiWines @Christinadobrzyn

[mallenexpensify]

@Santhosh-Sellavel do you want to post the increased compensation request first then @cowboycito can 👍 or comment? I think that'd be easiest. Please include the amount total you think is fair. Provide reasoning, including links and details. That will make it easy for the BZ / @Christinadobrzyn to 👍 (if they agree). Thanks.

[Christinadobrzyn]

Hey @cowboycito - what compensation amount do you think is fair for this job?

[Santhosh-Sellavel]

Sorry for the delay everyone, I'll post a summary of events by date.
The current price of the job of $2000 is set on 22 Oct 2022 here to encourage proposals.

Pretty same we got the proposal kick-started from @cowboycito here

After review and some discussions, I've requested additional changes i.e requested POC to completely test the code on 7 Nov 2022 here.

On the same day, @cowboycito questioned about an increase in bounty here.

I thought it's fair to raise bounty since I'm not sure about how much work is left out, so commented here let's discuss once the job is complete.

On 10 Nov 2022 here the POC is ready for review.

After some discussions and review. On 25 Nov 2022 here, I was able to verify the POC. And a design request for a deep link page was initiated.

The proposal was updated by @cowboycito on Dec 1 here And I recommended hire here on the same day.

Also, I noticed a bug on safari while reviewing.

9 Dec 2022
@cowboycito Investigated it but could not get through so requested what's next steps here

12 Dec 2022 Ignoring the bug, we have a lot to ship here so we decided to move forward here and here

15 Dec 2022 PR Submitted

23 Dec 2022 Here I requested to flag this one as a penalty as its feature might take more time.

25 Dec 2022 to Jan 2 No activity due to Holiday.

Resumed Review Activity Jan 3 PR was merged on Jan 10.

Considering the efforts made here, IMO $5K is a fair amount here.
cc: @Christinadobrzyn @NikkiWines

[cowboycito]

Sorry for the delay everyone! I agree with what @Santhosh-Sellavel said and I think that sounds fair.

[Christinadobrzyn]

Thanks @Santhosh-Sellavel and @cowboycito! @NikkiWines does this sound good to you?

[iwiznia]

Context https://expensify.slack.com/archives/C01GTK53T8Q/p1674481724781139

I think this PR has a bug: whenever I reload the website, I get the Open electron banner, but I don't have the app installed (I think, not 100% how to check). So, it's kind of 2 bugs I think?

1. Banner should not be shown if you are reloading the page
2. Banner should not be shown if you don't have the app installed

[Santhosh-Sellavel]

Discussion outcome we decided to create a new issue to sort this one as it occurs only for developers.

[NikkiWines]

Thanks @Santhosh-Sellavel and @cowboycito! @NikkiWines does this sound good to you?

Yep, seems reasonable to me! This was a tricky issue and both @cowboycito and @Santhosh-Sellavel did a good job of keeping it moving and following through to get it across the finish line 👍

[Christinadobrzyn]

Okay! ready to close this out:

• Paid @cowboycito $2,000 for the job and $3,000 bonus
• Paid @Santhosh-Sellavel $2,000 for the job and $3,000 bonus
• No external reporter
• Closed the Upwork job
• Closing this GH as complete!

please let me know if there are any questions!