Desktop deeplink #13606

cowboycito · 2022-12-15T00:44:55Z

Details

Implemented deeplink on the web app that will show a popup to the user asking if they want to open the desktop app (if the desktop app is installed).
The deeplink code will trigger the popup if the user opens up the web app in any of the following routes:

/concierge/*
/statements/*
/partners/plaid/oauth_ios/
/enable-payments/*
/iou/*
/bank-account/*
/v/*
/details/*
/setpassword/*
/settings/*
/r/*

Fixed Issues

$ #10893
PROPOSAL: #10893 (comment)

Tests

Navigate to Expensify's home page on MacOS
Make sure the deeplink popup does NOT show
Navigate to any of the screens listed above, like the settings page
Now you should see a screen saying Launching Expensify and the deeplink popup above it.
If you click to open Expensify it should open the desktop app and take you straight to the given page you are (like the settings page we used in the example above).
If you close the popup and press to "open this link in your browser" if should take you straight to that same page and the "Launching Expensify" screen should be gone.
Please notice that if you're testing in Safari there's a small bug that was already discussed here. Safari has a known bug where the deeplink "check" (the "Launching Expenfify" screen) will only work/show if you move your mouse while the website is loading). That's a minor bug that was previously discussed and that does not affect the deeplink feature, as it will launch the app if you have it installed.

Verify that no errors appear in the JS console

Offline tests

Navigate to Expensify's home page on MacOS
Make sure the deeplink popup does NOT show
Navigate to any of the screens listed above, like the settings page
Now you should see a screen saying Launching Expensify and the deeplink popup above it.
If you click to open Expensify it should open the desktop app and take you straight to the given page you are (like the settings page we used in the example above).
If you close the popup and press to "open this link in your browser" if should take you straight to that same page and the "Launching Expensify" screen should be gone.
Please notice that if you're testing in Safari there's a small bug that was already discussed here. Safari has a known bug where the deeplink "check" (the "Launching Expenfify" screen) will only work/show if you move your mouse while the website is loading). That's a minor bug that was previously discussed and that does not affect the deeplink feature, as it will launch the app if you have it installed.

QA Steps

Navigate to Expensify's home page on MacOS
Make sure the deeplink popup does NOT show
Navigate to any of the screens listed above, like the settings page
Now you should see a screen saying Launching Expensify and the deeplink popup above it.
If you click to open Expensify it should open the desktop app and take you straight to the given page you are (like the settings page we used in the example above).
If you close the popup and press to "open this link in your browser" if should take you straight to that same page and the "Launching Expensify" screen should be gone.
Please notice that if you're testing in Safari there's a small bug that was already discussed here. Safari has a known bug where the deeplink "check" (the "Launching Expenfify" screen) will only work/show if you move your mouse while the website is loading). That's a minor bug that was previously discussed and that does not affect the deeplink feature, as it will launch the app if you have it installed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Chrome

Safari

Microsoft Edge

Firefox

Opera

iOS

ios.mov

iOS web

ios_mweb.mp4

Android web

android.mweb.mp4

Desktop

desktop.mp4

melvin-bot · 2022-12-15T00:45:00Z

@NikkiWines @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2022-12-15T00:45:09Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Santhosh-Sellavel · 2022-12-15T00:59:48Z

@cowboycito commits are not signed

So you need to retroactively sign commits on this branch. We are unable to merge pull requests which contain any unsigned commits.

I think that the easiest way to do that would be to follow the instructions in this article.

src/languages/es.js

aldo-expensify

I added some Spanish translations, but would be good if @Gonals or @iwiznia can double check :)

src/languages/es.js

NikkiWines

Did a HL once-over, will give this a proper review next week

src/styles/fontFamily/index.js

desktop/main.js

src/components/DeeplinkWrapper/DeeplinkWrapper.website.js

src/styles/styles.js

src/pages/signin/TermsAndLicenses.js

src/components/DeeplinkWrapper/deeplinkRoutes.js

cowboycito · 2022-12-17T02:10:30Z

Fixed all the issues reported by @NikkiWines, signed all the commits (cc @Santhosh-Sellavel) and applied the Spanish translations provided by @aldo-expensify.

shawnborton · 2022-12-19T00:14:26Z

For this one, I would just use our current ExpensifyNeue font for the headline. We will follow up separately with a PR to add in the correct headline font, but no need to worry about it here.

cowboycito · 2022-12-19T11:07:35Z

For this one, I would just use our current ExpensifyNeue font for the headline. We will follow up separately with a PR to add in the correct headline font, but no need to worry about it here.

Done!

shawnborton · 2022-12-19T13:22:19Z

Great! Mind updating the screenshots when you get a moment? Thanks!

Santhosh-Sellavel · 2022-12-19T16:02:51Z

Thanks @cowboycito

Can you update screen recording for other platforms too, Let's ensure that it's working as expected and no weird behaviors.

cowboycito · 2022-12-21T13:00:41Z

@Santhosh-Sellavel sorry for the delay.

Here are the recordings with the style adjustments.

Chrome:

chrome.mov

Safari (showing when the deeplink check works and when it doesn't):

safari.mov

Is there anything else you want me to do so we can start reviewing the code? Also, what is the CLA check that is failing in the PR? How do I fix that?

shawnborton · 2022-12-21T13:43:58Z

Looking good!

cc @luacmartins as we'll want to update the headline font for this screen too. So depending on whether or not this gets merged before or after your fonts PR, we can adjust accordingly.

luacmartins

LGTM thanks for the changes!

NikkiWines

Looks great !! Thanks for your perseverance here @cowboycito & @Santhosh-Sellavel 🙌

One minor note for the testing steps @cowboycito :

Please notice that if you're testing in Safari there's a small bug that was already discussed #10893 (comment).

Might be good to add a bit more context here as to what the small bug is, so you don't have to go to a separate page to know if you've encountered the bug while testing.

cowboycito · 2023-01-09T19:51:08Z

Looks great !! Thanks for your perseverance here @cowboycito & @Santhosh-Sellavel 🙌

One minor note for the testing steps @cowboycito :

Please notice that if you're testing in Safari there's a small bug that was already discussed #10893 (comment).

Might be good to add a bit more context here as to what the small bug is, so you don't have to go to a separate page to know if you've encountered the bug while testing.

@NikkiWines done

luacmartins · 2023-01-09T20:57:57Z

@cowboycito seems like the author checklist is outdated. Could you please update it with the most recent version?

cowboycito · 2023-01-09T21:04:23Z

@cowboycito seems like the author checklist is outdated. Could you please update it with the most recent version?

@luacmartins done!

aldo-expensify

Working fine for me!

OSBotify · 2023-01-09T21:30:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2023-01-09T21:57:22Z

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start nativeLaunch	10.419 ms → 19.375 ms (+8.956 ms, +86.0%) 🔴
App start regularAppStart	0.014 ms → 0.015 ms (+0.000 ms, +3.2%)
App start runJsBundle	195.563 ms → 195.188 ms (-0.375 ms, ±0.0%)
App start TTI	689.824 ms → 683.859 ms (-5.964 ms, -0.9%)
Open Search Page TTI	605.695 ms → 599.020 ms (-6.675 ms, -1.1%)

Show details

Name	Duration
App start nativeLaunch	Baseline Mean: 10.419 ms Stdev: 2.137 ms (20.5%) Runs: 8 8 8 8 8 9 9 9 9 9 9 9 9 9 9 10 10 10 11 11 11 11 11 12 12 12 13 14 15 15 15 Current Mean: 19.375 ms Stdev: 1.452 ms (7.5%) Runs: 17 18 18 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 21 21 22 22 22 23
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (9.6%) Runs: 0.012165999971330166 0.012533000204712152 0.012654999736696482 0.012817000038921833 0.012979999650269747 0.012980000115931034 0.013061000034213066 0.01310200011357665 0.013141999952495098 0.013264999724924564 0.013264999724924564 0.013387000188231468 0.013590000104159117 0.013591000344604254 0.013631999958306551 0.013712000101804733 0.013712999876588583 0.013875999953597784 0.014322999864816666 0.014404000248759985 0.014607999939471483 0.014688999857753515 0.0148930000141263 0.015015000011771917 0.015462000388652086 0.015503000002354383 0.0157880000770092 0.0166830001398921 0.01696800021454692 0.0176189998164773 Current Mean: 0.015 ms Stdev: 0.001 ms (6.7%) Runs: 0.013061000034213066 0.01310200011357665 0.013143000192940235 0.013427999801933765 0.013549999799579382 0.013590000104159117 0.013631000183522701 0.013753000181168318 0.013793999794870615 0.0138349998742342 0.0138349998742342 0.014159999787807465 0.014322999864816666 0.014403999783098698 0.01448499970138073 0.014485999941825867 0.014607000164687634 0.014730000402778387 0.014932999853044748 0.014973999932408333 0.014973999932408333 0.015015000011771917 0.015176999848335981 0.015217999927699566 0.015217999927699566 0.01537999976426363 0.015462000388652086 0.01582799991592765 0.016398000065237284 0.016398000065237284 0.016681999899446964
App start runJsBundle	Baseline Mean: 195.563 ms Stdev: 29.261 ms (15.0%) Runs: 153 157 157 158 160 160 169 171 172 176 177 178 180 188 188 192 198 198 198 201 202 207 209 213 226 228 229 232 235 236 252 258 Current Mean: 195.188 ms Stdev: 27.236 ms (14.0%) Runs: 161 162 165 167 168 168 169 170 172 173 176 181 182 183 183 189 191 196 196 199 207 207 208 208 209 217 218 221 235 250 256 259
App start TTI	Baseline Mean: 689.824 ms Stdev: 35.442 ms (5.1%) Runs: 621.8982939999551 636.1714320001192 636.8211759999394 641.930933999829 646.2069580000825 648.0137370000593 661.7014139997773 663.8602849999443 665.5828860001639 666.6015329998918 672.803501999937 673.5715230000205 675.385766999796 676.1013930002227 676.6811819998547 680.0793579998426 693.1834470001049 696.8697250001132 700.9469010001048 702.8283350002021 711.8136200001463 712.8503220002167 713.565950000193 715.8364479998127 720.0107049997896 724.8877639998682 726.7857630001381 730.4356459998526 737.2338640000671 746.1708809998818 747.1621659998782 750.3609409998171 Current Mean: 683.859 ms Stdev: 29.709 ms (4.3%) Runs: 640.25014499994 641.1255899998359 649.9429709999822 651.056596999988 653.2129600001499 653.6327479998581 655.718499999959 659.5019620000385 662.0689309998415 662.4442440001294 672.0789049998857 673.3177820001729 673.7223410001025 674.3884069998749 674.4115109997801 674.8843840002082 677.5897450000048 681.3742669997737 682.9315740000457 695.9422470000573 699.6625879998319 700.1576140001416 701.5209690001793 703.0622419998981 704.0587599999271 711.4851890001446 713.1089460002258 724.8497939999215 730.3920550001785 737.0656989999115 764.6819620002061
Open Search Page TTI	Baseline Mean: 605.695 ms Stdev: 25.671 ms (4.2%) Runs: 548.7828780002892 568.8864750000648 570.6480310000479 577.5766610000283 578.3484300002456 578.5702720000409 579.13830600027 583.9148359997198 590.2533780001104 590.3605960002169 591.943847999908 592.5712490002625 592.7895510001108 597.4974360000342 598.2146399999037 599.7218019999564 600.3895270000212 600.8952640001662 608.1415200000629 613.5559489997104 613.6378179998137 615.4777839998715 619.7522789998911 626.6169429998845 629.0522060003132 632.9851080002263 634.7223720001057 634.9782309997827 634.9927989998832 638.6016039997339 646.4793700003065 646.643962000031 651.7929689995944 Current Mean: 599.020 ms Stdev: 21.965 ms (3.7%) Runs: 567.3149419999681 567.3254399998114 568.2692879997194 568.6654059998691 569.6825759997591 571.0745040001348 577.3090409999713 579.6863199998625 583.3933520000428 583.7967530000024 588.6802159999497 588.7269290001132 588.9259850000963 591.9107259996235 595.9408780001104 598.0925300000235 598.7986659999005 599.2847090000287 599.4692799998447 600.2740890001878 604.2049970002845 604.2885739998892 606.5966799999587 610.0465499996208 614.2207030002028 615.5767830000259 622.8831380000338 627.7417399999686 630.206298999954 632.269288000185 634.7617190000601 639.0941159999929 639.1329749999568

github-actions · 2023-01-09T21:57:24Z

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

luacmartins · 2023-01-09T22:18:41Z

Started a discussion about the performance regression here

cowboycito · 2023-01-09T22:28:51Z

Started a discussion about the performance regression here

@luacmartins let me know it I can/need to do anything as I don't have access to that Slack link

luacmartins · 2023-01-09T22:30:39Z

Seems like we don't care about the meaningless changes to duration, so I'll remove the label and work on a fix to prevent adding the label in such cases.

OSBotify · 2023-01-10T17:07:45Z

🚀 Deployed to staging by @NikkiWines in version: 1.2.52-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-01-12T13:38:21Z

🚀 Deployed to production by @Julesssss in version: 1.2.52-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2023-01-15T15:46:17Z

Sorry everyone,
Only today I was able to test this on Production,

I believe this is not working as expected, @cowboycito

cc: @NikkiWines

cowboycito · 2023-01-15T15:47:46Z

@Santhosh-Sellavel check out this thread

Santhosh-Sellavel · 2023-01-15T15:50:08Z

I'll dm you.

cowboycito · 2023-01-15T16:00:32Z

@Santhosh-Sellavel screenshots of both staging and production after removing all references to Electron in any node_modules I had on my computer:

Staging:

Production:

Santhosh-Sellavel · 2023-01-15T16:30:48Z

Ya, that helps, thanks @cowboycito. I still feel it's quite annoying for developers here.

parasharrajat · 2023-03-07T16:56:01Z

src/components/DeeplinkWrapper/index.website.js

+
+    openRouteInDesktopApp() {
+        const expensifyUrl = new URL(CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL);
+        const expensifyDeeplinkUrl = `${CONST.DEEPLINK_BASE_URL}${expensifyUrl.host}${window.location.pathname}`;


We forgot to pass the query params here which caused a few URLs to break in our App.

Here is the regression issue #15059

cc: @Santhosh-Sellavel

rushatgabhane · 2023-05-05T09:22:59Z

we'd need a solution that works for any link that a user would open in a browser (source: #10893 (comment))

Hi all, from the issue the plan was that clicking any link would deeplink with desktop.
But somehow we ended up enabling deeplink only for a small set of links, causing #16083

Cheers!

roryabraham · 2023-06-07T23:24:16Z

src/components/DeeplinkWrapper/index.website.js

+        }
+    }
+
+    isMacOSWeb() {


Why did we put this in the component instead of the Browser lib?

No specific reasons we just missed out on that Review.

cowboycito requested a review from a team as a code owner December 15, 2022 00:44

melvin-bot bot requested review from NikkiWines and Santhosh-Sellavel and removed request for a team December 15, 2022 00:44

cowboycito mentioned this pull request Dec 15, 2022

[HOLD for payment 2023-01-19] [$2000] Feature Request: Open link in Desktop app if it is installed and not in browser #10893

Closed

Santhosh-Sellavel reviewed Dec 15, 2022

View reviewed changes

src/languages/es.js Outdated Show resolved Hide resolved

NikkiWines assigned cowboycito Dec 15, 2022

NikkiWines added the Waiting for copy User facing verbiage needs polishing label Dec 15, 2022

aldo-expensify reviewed Dec 15, 2022

View reviewed changes

src/languages/es.js Outdated Show resolved Hide resolved

src/languages/es.js Outdated Show resolved Hide resolved

src/languages/es.js Outdated Show resolved Hide resolved

src/languages/es.js Outdated Show resolved Hide resolved

src/languages/es.js Outdated Show resolved Hide resolved

NikkiWines requested changes Dec 16, 2022

View reviewed changes

cowboycito force-pushed the iss-10893/desktop-deeplink branch 2 times, most recently from 26a5b14 to 1425f23 Compare December 17, 2022 01:09

cowboycito added 4 commits December 16, 2022 22:11

Desktop deeplink POC

ec5becf

Implemented launcher screen design and fixed iOS issue

b7c02f5

Safari check

c3d7186

Added TODO for spanish translations

b1b9ba6

cowboycito force-pushed the iss-10893/desktop-deeplink branch from 1425f23 to b1b9ba6 Compare December 17, 2022 01:12

Fixed PR comments

90a4e1b

Using default font for deeplink headline

5a4093d

luacmartins mentioned this pull request Dec 21, 2022

Add new header font #13714

Merged

53 tasks

luacmartins approved these changes Jan 9, 2023

View reviewed changes

NikkiWines approved these changes Jan 9, 2023

View reviewed changes

aldo-expensify approved these changes Jan 9, 2023

View reviewed changes

NikkiWines merged commit eb6aa08 into Expensify:main Jan 9, 2023

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2023

luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2023

luacmartins mentioned this pull request Jan 9, 2023

Also check for shortLivedToken when signing in with shortLivedAuthToken #14045

Merged

53 tasks

OSBotify mentioned this pull request Jan 10, 2023

Deploy Checklist: New Expensify 2023-01-10 #14188

Closed

15 tasks

parasharrajat reviewed Mar 7, 2023

View reviewed changes

parasharrajat mentioned this pull request Mar 7, 2023

[HOLD for payment 2023-03-13] [$1000] Deep link for user profile crashes on desktop #15059

Closed

6 tasks

ntdiary mentioned this pull request May 2, 2023

clean up the deep link code #17452

Merged

56 tasks

rushatgabhane mentioned this pull request May 5, 2023

[PAID] [$1000] When clicking link to chat with Concierge on expensify.com, the pop up option to open the desktop app is not surfaced. #16083

Closed

6 tasks

roryabraham reviewed Jun 7, 2023

View reviewed changes

Desktop deeplink #13606

Desktop deeplink #13606

Conversation

cowboycito commented Dec 15, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 15, 2022

github-actions bot commented Dec 15, 2022 • edited Loading

Santhosh-Sellavel commented Dec 15, 2022 • edited Loading

aldo-expensify left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

cowboycito commented Dec 17, 2022

shawnborton commented Dec 19, 2022

cowboycito commented Dec 19, 2022

shawnborton commented Dec 19, 2022

Santhosh-Sellavel commented Dec 19, 2022

cowboycito commented Dec 21, 2022 • edited Loading

shawnborton commented Dec 21, 2022

luacmartins left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

cowboycito commented Jan 9, 2023

luacmartins commented Jan 9, 2023

cowboycito commented Jan 9, 2023

aldo-expensify left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 9, 2023

github-actions bot commented Jan 9, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Meaningless Changes To Duration

github-actions bot commented Jan 9, 2023

luacmartins commented Jan 9, 2023

cowboycito commented Jan 9, 2023

luacmartins commented Jan 9, 2023

OSBotify commented Jan 10, 2023

OSBotify commented Jan 12, 2023

Santhosh-Sellavel commented Jan 15, 2023 • edited Loading

cowboycito commented Jan 15, 2023

Santhosh-Sellavel commented Jan 15, 2023

cowboycito commented Jan 15, 2023

Santhosh-Sellavel commented Jan 15, 2023

parasharrajat Mar 7, 2023

Choose a reason for hiding this comment

rushatgabhane commented May 5, 2023 • edited Loading

roryabraham Jun 7, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Jun 8, 2023

Choose a reason for hiding this comment

cowboycito commented Dec 15, 2022 •

edited

Loading

github-actions bot commented Dec 15, 2022 •

edited

Loading

Santhosh-Sellavel commented Dec 15, 2022 •

edited

Loading

cowboycito commented Dec 21, 2022 •

edited

Loading

Santhosh-Sellavel commented Jan 15, 2023 •

edited

Loading

rushatgabhane commented May 5, 2023 •

edited

Loading