onKeyDown added to Textlink component #12034

dhairyasenjaliya · 2022-10-20T05:47:58Z

Details

Fixed Issues

$ #11354
PROPOSAL: #11354 (comment)

Tests

Go to staging.new.expensify.com
Login with the account
Send PDF protected file
Click on the PDF file
Use the Tab key to navigate to Enter the Password name
Click Enter
Notice On pressing Enter Password modal should open

Verify that no errors appear in the JS console

QA Steps

Go to staging.new.expensify.com
Login with the account
Send PDF protected file
Click on the PDF file
Use the Tab key to navigate to Enter the Password name
Click Enter
Notice On pressing Enter Password modal should open

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Chrome
https://user-images.githubusercontent.com/47522946/196866996-1498e6fd-e578-48e0-a690-8b283c839d5a.mov

Safari
https://user-images.githubusercontent.com/47522946/196867024-5c4461fb-4eec-4314-a537-588b49ad0ab8.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Desktop.mov

iOS

Android

src/components/TextLink.js

…into enterKeyEvent

tgolen

I like how this was combined into a single method now 👍

src/components/TextLink.js

dhairyasenjaliya · 2022-10-25T04:40:25Z

I found one issue in this condition for native it's not pressable I'm fixing that
@tgolen for web and m-web we are getting events like click and enter key events but for native we are not getting them, so should we create platform-specific index files for <TextLink> or maybe just add condition only on onMouseDown

eVoloshchak · 2022-10-26T14:52:20Z

@dhairyasenjaliya
We should create platform-specific files as per README.md

The same structure all of the components are using, for example, PopoverMenu

dhairyasenjaliya · 2022-10-27T03:44:39Z

hello, For now, we have 2 options

To create a platform-specific index
To add conditions into onKeyDown like below

onKeyDown={(e) => {
    if (e.key !== 'Enter') {
        return;
    }
    handlePress(e);
}}

I'm happy to proceed with any options from above just wanted to confirm with you guys @eVoloshchak @tgolen

tgolen · 2022-10-27T13:58:34Z

I'd be fine with using option 2. As long as we don't have anything like Platform.OS === whatever

…into enterKeyEvent

dhairyasenjaliya · 2022-10-28T04:08:53Z

option 2 added @tgolen @eVoloshchak

eVoloshchak · 2022-10-31T14:07:58Z

Screenshots

Web

Screen.Recording.2022-10-31.at.14.49.29.mov

Mobile Web - Chrome

Screen.Recording.2022-10-31.at.15.52.23.mov

Mobile Web - Safari

Screen.Recording.2022-10-31.at.15.54.47.mov

Desktop

Screen.Recording.2022-10-31.at.14.50.38.mov

iOS

It's not possible to select a link with Tab on native platforms

Android

It's not possible to select a link with Tab on native platforms

eVoloshchak · 2022-10-31T14:14:27Z

@dhairyasenjaliya, could you please re-test native platforms? It looks like this for me, which is not how it looks on web/desktop. Make sure to merge the latest changes from main.

src/components/TextLink.js

dhairyasenjaliya · 2022-11-01T03:00:27Z

@dhairyasenjaliya, could you please re-test native platforms? It looks like this for me, which is not how it looks on web/desktop. Make sure to merge the latest changes from main.

hm weird let me check in the latest main might be any other PR causing regression!

…into enterKeyEvent

dhairyasenjaliya · 2022-11-01T04:17:24Z

@eVoloshchak native platform has an issue in the main branch same as you posted a screenshot, you can check even without this PR I think we can post this issue in slack since this was working fine recently these changes so I do think this might be a regression from other PR

src/components/TextLink.js

eVoloshchak · 2022-11-02T14:54:29Z

@eVoloshchak native platform has an issue in the main branch same as you posted a screenshot, you can check even without this PR I think we can post this issue in slack since this was working fine recently these changes so I do think this might be a regression from other PR

You are right, retested all platforms, updated the screenshots.
It's not possible to select a link using Tab navigation on native platforms, is it the same for you?

Co-authored-by: e_voloshchak <copyreading@gmail.com>

dhairyasenjaliya · 2022-11-02T14:56:10Z

@eVoloshchak native platform has an issue in the main branch same as you posted a screenshot, you can check even without this PR I think we can post this issue in slack since this was working fine recently these changes so I do think this might be a regression from other PR

You are right, retested all platforms, updated the screenshots. It's not possible to select a link using Tab navigation on native platforms, is it the same for you?

yeah this is available only for web

eVoloshchak · 2022-11-02T15:01:21Z

LGTM!
cc: @tgolen

Screenshots

Web

Screen.Recording.2022-10-31.at.14.49.29.mov

Mobile Web - Chrome

Screen.Recording.2022-10-31.at.15.52.23.mov

Mobile Web - Safari

Screen.Recording.2022-10-31.at.15.54.47.mov

Desktop

Screen.Recording.2022-10-31.at.14.50.38.mov

iOS

It's not possible to select a link with Tab on native platforms

Android

It's not possible to select a link with Tab on native platforms

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

src/components/TextLink.js

Co-authored-by: Tim Golen <tgolen@gmail.com>

dhairyasenjaliya · 2022-11-03T16:29:41Z

@tgolen any changes remaining from my side?

eVoloshchak · 2022-11-03T16:35:00Z

@dhairyasenjaliya, I think this comment is not addressed yet
I agree, we should avoid using anonymous functions inside the JSX

dhairyasenjaliya · 2022-11-03T16:37:25Z

@dhairyasenjaliya, I think this comment is not addressed yet I agree, we should avoid using anonymous functions inside the JSX

ah I missed that let me take a look at it

…into enterKeyEvent

…xpensify into enterKeyEvent

dhairyasenjaliya · 2022-11-03T16:55:14Z

@tgolen @eVoloshchak have moved the callback to openLinkIfEnterKeyPressed is that correct or am I missing something?

src/components/TextLink.js

eVoloshchak

cc: @tgolen

tgolen

Looks great, thank you!

melvin-bot · 2022-11-03T20:36:10Z

@tgolen looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2022-11-03T20:41:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

tgolen · 2022-11-03T20:55:50Z

I manually verified the reviewer checklist is complete.

OSBotify · 2022-11-04T17:51:59Z

🚀 Deployed to staging by @tgolen in version: 1.2.24-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-11-08T19:38:07Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.24-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-08T21:07:40Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.24-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-08T21:37:59Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.24-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

onKeyDown added to textlink component

4a2bc89

dhairyasenjaliya marked this pull request as ready for review October 20, 2022 05:56

dhairyasenjaliya requested a review from a team as a code owner October 20, 2022 05:56

melvin-bot bot requested review from eVoloshchak and tgolen and removed request for a team October 20, 2022 05:56

tgolen requested changes Oct 23, 2022

View reviewed changes

src/components/TextLink.js Outdated Show resolved Hide resolved

src/components/TextLink.js Outdated Show resolved Hide resolved

dhairyasenjaliya added 2 commits October 24, 2022 13:16

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

bd9948a

…into enterKeyEvent

Rename Function & Move Callback

b7b242b

tgolen requested changes Oct 24, 2022

View reviewed changes

src/components/TextLink.js Outdated Show resolved Hide resolved

Removed Obsolete parameter from JsDoc

58046cc

dhairyasenjaliya added 2 commits October 28, 2022 09:22

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

ec629dd

…into enterKeyEvent

Adding onKeyDown condition

5e5d2e7

eVoloshchak suggested changes Oct 31, 2022

View reviewed changes

src/components/TextLink.js Outdated Show resolved Hide resolved

src/components/TextLink.js Outdated Show resolved Hide resolved

dhairyasenjaliya added 2 commits November 1, 2022 09:20

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

11a27a6

…into enterKeyEvent

Removed Obsolute comment

3ab018e

eVoloshchak suggested changes Nov 2, 2022

View reviewed changes

src/components/TextLink.js Outdated Show resolved Hide resolved

Update src/components/TextLink.js

2a654db

Co-authored-by: e_voloshchak <copyreading@gmail.com>

eVoloshchak previously approved these changes Nov 2, 2022

View reviewed changes

tgolen requested changes Nov 2, 2022

View reviewed changes

src/components/TextLink.js Outdated Show resolved Hide resolved

src/components/TextLink.js Outdated Show resolved Hide resolved

Update src/components/TextLink.js

a056f80

Co-authored-by: Tim Golen <tgolen@gmail.com>

dhairyasenjaliya dismissed eVoloshchak’s stale review via a056f80 November 2, 2022 15:24

0xmiros mentioned this pull request Nov 3, 2022

[$500] BUG: Mac/Firefox - Opening the protect PDF modal and pressing TAB doesn’t focus on enter the password reported by @dhairyasenjaliya #12058

Closed

dhairyasenjaliya added 3 commits November 3, 2022 22:08

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

bc9166b

…into enterKeyEvent

Merge branch 'enterKeyEvent' of https://github.com/dhairyasenjaliya/E…

d9156b9

…xpensify into enterKeyEvent

move callback

a4b84bc

eVoloshchak suggested changes Nov 3, 2022

View reviewed changes

src/components/TextLink.js Outdated Show resolved Hide resolved

src/components/TextLink.js Outdated Show resolved Hide resolved

Remove Obsolute lines

d0ad7de

eVoloshchak approved these changes Nov 3, 2022

View reviewed changes

tgolen approved these changes Nov 3, 2022

View reviewed changes

tgolen merged commit 1dd7174 into Expensify:main Nov 3, 2022

melvin-bot bot added the Emergency label Nov 3, 2022

tgolen removed the Emergency label Nov 3, 2022

OSBotify mentioned this pull request Nov 4, 2022

Deploy Checklist: New Expensify 2022-11-04 #12476

Closed

20 tasks

eVoloshchak mentioned this pull request Nov 22, 2022

[$500] Web - Attachment - Unable to open popup "Enter the Password" using Enter Key #11354

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onKeyDown added to Textlink component #12034

onKeyDown added to Textlink component #12034

dhairyasenjaliya commented Oct 20, 2022 •

edited

Loading

tgolen left a comment

dhairyasenjaliya commented Oct 25, 2022 •

edited

Loading

eVoloshchak commented Oct 26, 2022 •

edited

Loading

dhairyasenjaliya commented Oct 27, 2022 •

edited

Loading

tgolen commented Oct 27, 2022

dhairyasenjaliya commented Oct 28, 2022

eVoloshchak commented Oct 31, 2022 •

edited

Loading

Screenshots

eVoloshchak commented Oct 31, 2022

dhairyasenjaliya commented Nov 1, 2022

dhairyasenjaliya commented Nov 1, 2022

eVoloshchak commented Nov 2, 2022

dhairyasenjaliya commented Nov 2, 2022

eVoloshchak commented Nov 2, 2022 •

edited

Loading

Screenshots

PR Reviewer Checklist

dhairyasenjaliya commented Nov 3, 2022 •

edited

Loading

eVoloshchak commented Nov 3, 2022

dhairyasenjaliya commented Nov 3, 2022

dhairyasenjaliya commented Nov 3, 2022

eVoloshchak left a comment

tgolen left a comment

melvin-bot bot commented Nov 3, 2022

OSBotify commented Nov 3, 2022

tgolen commented Nov 3, 2022

OSBotify commented Nov 4, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 8, 2022

onKeyDown added to Textlink component #12034

onKeyDown added to Textlink component #12034

Conversation

dhairyasenjaliya commented Oct 20, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

tgolen left a comment

Choose a reason for hiding this comment

dhairyasenjaliya commented Oct 25, 2022 • edited Loading

eVoloshchak commented Oct 26, 2022 • edited Loading

dhairyasenjaliya commented Oct 27, 2022 • edited Loading

tgolen commented Oct 27, 2022

dhairyasenjaliya commented Oct 28, 2022

eVoloshchak commented Oct 31, 2022 • edited Loading

Screenshots

eVoloshchak commented Oct 31, 2022

dhairyasenjaliya commented Nov 1, 2022

dhairyasenjaliya commented Nov 1, 2022

eVoloshchak commented Nov 2, 2022

dhairyasenjaliya commented Nov 2, 2022

eVoloshchak commented Nov 2, 2022 • edited Loading

Screenshots

PR Reviewer Checklist

dhairyasenjaliya commented Nov 3, 2022 • edited Loading

eVoloshchak commented Nov 3, 2022

dhairyasenjaliya commented Nov 3, 2022

dhairyasenjaliya commented Nov 3, 2022

eVoloshchak left a comment

Choose a reason for hiding this comment

tgolen left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 3, 2022

OSBotify commented Nov 3, 2022

tgolen commented Nov 3, 2022

OSBotify commented Nov 4, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 8, 2022

dhairyasenjaliya commented Oct 20, 2022 •

edited

Loading

dhairyasenjaliya commented Oct 25, 2022 •

edited

Loading

eVoloshchak commented Oct 26, 2022 •

edited

Loading

dhairyasenjaliya commented Oct 27, 2022 •

edited

Loading

eVoloshchak commented Oct 31, 2022 •

edited

Loading

eVoloshchak commented Nov 2, 2022 •

edited

Loading

dhairyasenjaliya commented Nov 3, 2022 •

edited

Loading