Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onKeyDown added to Textlink component #12034

Merged
merged 14 commits into from
Nov 3, 2022
Merged

onKeyDown added to Textlink component #12034

Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4a2bc89
onKeyDown added to textlink component
dhairyasenjaliya Oct 20, 2022
bd9948a
Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …
dhairyasenjaliya Oct 24, 2022
b7b242b
Rename Function & Move Callback
dhairyasenjaliya Oct 24, 2022
58046cc
Removed Obsolete parameter from JsDoc
dhairyasenjaliya Oct 24, 2022
ec629dd
Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …
dhairyasenjaliya Oct 28, 2022
5e5d2e7
Adding onKeyDown condition
dhairyasenjaliya Oct 28, 2022
11a27a6
Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …
dhairyasenjaliya Nov 1, 2022
3ab018e
Removed Obsolute comment
dhairyasenjaliya Nov 1, 2022
2a654db
Update src/components/TextLink.js
dhairyasenjaliya Nov 2, 2022
a056f80
Update src/components/TextLink.js
dhairyasenjaliya Nov 2, 2022
bc9166b
Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …
dhairyasenjaliya Nov 3, 2022
d9156b9
Merge branch 'enterKeyEvent' of https://github.com/dhairyasenjaliya/E…
dhairyasenjaliya Nov 3, 2022
a4b84bc
move callback
dhairyasenjaliya Nov 3, 2022
d0ad7de
Remove Obsolute lines
dhairyasenjaliya Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/components/TextLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,33 @@ const defaultProps = {

const TextLink = (props) => {
const additionalStyles = _.isArray(props.style) ? props.style : [props.style];

/**
*
dhairyasenjaliya marked this conversation as resolved.
Show resolved Hide resolved
* @param {Event} event
*/

const openLink = (event) => {
dhairyasenjaliya marked this conversation as resolved.
Show resolved Hide resolved
event.preventDefault();
if (props.onPress) {
props.onPress();
return;
}

Linking.openURL(props.href);
};

return (
<Text
style={[styles.link, ...additionalStyles]}
accessibilityRole="link"
href={props.href}
onPress={(e) => {
e.preventDefault();
if (props.onPress) {
props.onPress();
onPress={openLink}
onKeyDown={(e) => {
dhairyasenjaliya marked this conversation as resolved.
Show resolved Hide resolved
if (e.key !== 'Enter') {
return;
}

Linking.openURL(props.href);
openLink(e);
}}
>
{props.children}
Expand Down