Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form Refactor] ACHContractStep #13501

Merged
merged 33 commits into from
Feb 1, 2023
Merged

[Form Refactor] ACHContractStep #13501

Changes from 10 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
05d3bb2
Replace ReimbursementAccountForm with Form
grgia Oct 19, 2022
4b089ce
Create ACHContractForm Onyx key and use it
grgia Oct 19, 2022
797e578
Clean up inputs
grgia Oct 19, 2022
780212a
Merge branch 'main' into georgia-ACH-form
grgia Nov 16, 2022
bee453f
Merge branch 'main' into georgia-ACH-form
grgia Nov 29, 2022
6abfb7e
New commit
grgia Dec 10, 2022
cb0fff7
Merge branch 'georgia-ACH-form' of github.com:Expensify/App into geor…
grgia Dec 10, 2022
292e3f3
Use corrext ONYX Form key, Use ReimbursementAccountUtils.getDefaultSt…
grgia Dec 12, 2022
57c61d3
Use dynamic keys for IdentityForm
grgia Dec 13, 2022
b816f5b
Remove consoles, reformat data sent on submit
grgia Dec 13, 2022
382b75a
Merge branch 'main' into georgia-ACH-form
grgia Dec 15, 2022
a379d39
Clean up code and remove unused ReimbursementAccountUtils
grgia Dec 15, 2022
3ad4f46
Set to empty array if hasOtherBeneficialOwners is checked
grgia Dec 15, 2022
fbe7e15
Fix bug where 4 forms are submitted even if requester owns 25%
grgia Dec 15, 2022
a36e8a8
Fix bug where checking the beneifial owners check doesn't open an ide…
grgia Dec 15, 2022
6a32616
Fix > 18 years old check
grgia Dec 16, 2022
49098db
Update comment to be more descriptive
grgia Dec 16, 2022
3f5c1cc
Fix long line
grgia Dec 16, 2022
ea35dc3
Merge branch 'main' into georgia-ACH-form
grgia Dec 16, 2022
b67bd24
Rename ownerID variable to ownerKey, add JSDocs and comments
grgia Dec 16, 2022
efed1c3
Use for loop for requiredFulfilled() calls
grgia Dec 19, 2022
8d167d8
Use Str.guid to generate keys, add section to FORMS.md
grgia Dec 22, 2022
ccb589b
Fix param type, use variable name instead of value for clarity
grgia Dec 23, 2022
d5085c6
Replace '.' with '_' for key to not be confused with dot notation
grgia Dec 23, 2022
45c97c1
Merge branch 'main' into georgia-ACH-form
grgia Jan 9, 2023
853a4f9
pass props from forms
grgia Jan 13, 2023
d4a95a0
Log change
grgia Jan 26, 2023
d27dc93
Use default values / draft values for initial render of form
grgia Jan 26, 2023
aee6c38
Merge branch 'main' into georgia-ACH-form
grgia Jan 31, 2023
a63e322
fix JS console errors
grgia Jan 31, 2023
5937ed9
Remove unused imports
grgia Jan 31, 2023
0df7ec4
use props instead of this.props
grgia Jan 31, 2023
27a6f27
Move proptype to single line
grgia Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading