Flatten styles to avoid crash #13525

aldo-expensify · 2022-12-12T19:43:55Z

Details

Flatten styles

Before:

After:

Fixed Issues

$ #13508
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Access staging.new.expensify.com
Sign into any valid account
Tap on Profile > Workspace > Manage members
Invite any member
Turn off the internet connection
Remove a user from the workspace while offline
Verify that the user gets removed and the App doesn't crash

Verify that no errors appear in the JS console

Offline tests

QA Steps

Access staging.new.expensify.com
Sign into any valid account
Tap on Profile > Workspace > Manage members
Invite any member
Turn off the internet connection
Remove a user from the workspace while offline
Verify that the user gets removed and the App doesn't crash

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2022-12-12.at.12.13.44.PM.mov

Mobile Web - Chrome

Screen.Recording.2022-12-12.at.12.11.46.PM.mov

Mobile Web - Safari

Screen.Recording.2022-12-12.at.12.11.00.PM.mov

Desktop

Screen.Recording.2022-12-12.at.12.15.49.PM.mov

iOS

Screen.Recording.2022-12-12.at.12.07.55.PM.mov

Android

Screen.Recording.2022-12-12.at.12.06.58.PM.mov

github-actions · 2022-12-12T19:47:33Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

aldo-expensify · 2022-12-12T19:47:47Z

Made it ready for review to speed up things, I'll be testing all platforms now

melvin-bot · 2022-12-12T19:47:56Z

@parasharrajat @nkuoch One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2022-12-12T20:16:38Z

Tested in all platforms.

aldo-expensify · 2022-12-12T22:43:52Z

Asked about StyleUtils.combineStyles and StyleSheet.flatten here, and I think in this case it should have been StyleUtils.combineStyle because later one of these styles is getting spread into an array:

App/src/components/DisplayNames/index.js

Line 86 in a464a5c

style={[...this.props.textStyles, styles.pRelative]}

aldo-expensify · 2022-12-12T22:46:03Z

Converting to draft while I change StyleSheet.flatten to StyleUtils.combineStyles and retest

These calculated styles are passed down to other components in our code base, we should keep them as array.

aldo-expensify · 2022-12-12T23:15:31Z

This is ready for review again

parasharrajat · 2022-12-13T13:04:26Z

I am stuck with https://expensify.slack.com/archives/C02NK2DQWUX/p1670926426428439

chiragsalian · 2022-12-13T19:21:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…ployee Flatten styles to avoid crash (cherry picked from commit 8a054ac)

…-13525 🍒 Cherry pick PR #13525 to staging 🍒

OSBotify · 2022-12-13T20:58:00Z

🚀 Cherry-picked to staging by @chiragsalian in version: 1.2.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2022-12-13T22:36:59Z

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:38:34Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:56:19Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Flatten styles to avoid crash

3ef5d88

aldo-expensify self-assigned this Dec 12, 2022

aldo-expensify added the CP Staging label Dec 12, 2022

aldo-expensify marked this pull request as ready for review December 12, 2022 19:47

aldo-expensify requested a review from a team as a code owner December 12, 2022 19:47

melvin-bot bot requested review from nkuoch and parasharrajat and removed request for a team December 12, 2022 19:47

aldo-expensify mentioned this pull request Dec 12, 2022

[HOLD on regression test ] Workspace - Crash when removing a user offline in Manage members #13508

Closed

aldo-expensify marked this pull request as draft December 12, 2022 22:45

Use StyleUtils.combineStyles because they are props

bb8a5dc

These calculated styles are passed down to other components in our code base, we should keep them as array.

aldo-expensify marked this pull request as ready for review December 12, 2022 22:57

nkuoch approved these changes Dec 13, 2022

View reviewed changes

chiragsalian self-requested a review December 13, 2022 18:51

chiragsalian approved these changes Dec 13, 2022

View reviewed changes

chiragsalian merged commit 8a054ac into main Dec 13, 2022

chiragsalian deleted the aldo_fix-remove-workspace-employee branch December 13, 2022 19:39

OSBotify pushed a commit that referenced this pull request Dec 13, 2022

Merge pull request #13525 from Expensify/aldo_fix-remove-workspace-em…

7f17324

…ployee Flatten styles to avoid crash (cherry picked from commit 8a054ac)

OSBotify mentioned this pull request Dec 13, 2022

🍒 Cherry pick PR #13525 to staging 🍒 #13568

Merged

OSBotify added a commit that referenced this pull request Dec 13, 2022

Merge pull request #13568 from Expensify/OSBotify-cherry-pick-staging…

d397774

…-13525 🍒 Cherry pick PR #13525 to staging 🍒

OSBotify mentioned this pull request Dec 13, 2022

Deploy Checklist: New Expensify 2022-12-09 #13498

Closed

32 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flatten styles to avoid crash #13525

Flatten styles to avoid crash #13525

aldo-expensify commented Dec 12, 2022 •

edited

Loading

github-actions bot commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

melvin-bot bot commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

parasharrajat commented Dec 13, 2022

chiragsalian commented Dec 13, 2022 •

edited

Loading

OSBotify commented Dec 13, 2022

OSBotify commented Dec 13, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Flatten styles to avoid crash #13525

Flatten styles to avoid crash #13525

Conversation

aldo-expensify commented Dec 12, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

melvin-bot bot commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

aldo-expensify commented Dec 12, 2022

parasharrajat commented Dec 13, 2022

chiragsalian commented Dec 13, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Dec 13, 2022

OSBotify commented Dec 13, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

aldo-expensify commented Dec 12, 2022 •

edited

Loading

chiragsalian commented Dec 13, 2022 •

edited

Loading