Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten styles to avoid crash #13525

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Flatten styles to avoid crash #13525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ef5d88
Flatten styles to avoid crash
aldo-expensify Dec 12, 2022
bb8a5dc
Use StyleUtils.combineStyles because they are props
aldo-expensify Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/OptionRow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ const OptionRow = (props) => {
: styles.sidebarLinkText;
const textUnreadStyle = (props.boldStyle)
? [textStyle, styles.sidebarLinkTextBold] : [textStyle];
const displayNameStyle = [styles.optionDisplayName, ...textUnreadStyle, props.style];
const alternateTextStyle = [textStyle, styles.optionAlternateText, styles.textLabelSupporting, props.style];
const displayNameStyle = StyleUtils.combineStyles(styles.optionDisplayName, textUnreadStyle, props.style);
const alternateTextStyle = StyleUtils.combineStyles(textStyle, styles.optionAlternateText, styles.textLabelSupporting, props.style);
const contentContainerStyles = [styles.flex1];
const sidebarInnerRowStyle = StyleSheet.flatten([
styles.chatLinkRowPressable,
Expand Down