Update the reanimated and gesture handler versions #14946

mountiny · 2023-02-08T16:34:13Z

Details

Bumping two packages to resolve issues when running native apps locally. There is nothing specific to test, full regression tests should discover if anything will be broken

Fixed Issues

A lot of issues internally running the native apps https://expensify.slack.com/archives/C03TQ48KC/p1675812945076659

Tests

No specific tests, a full regression suite in case something odd is happening.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No specific tests, a full regression suite in case something odd is happening.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Nothing specific to add to the screenshots here, the app was running and mainly it builds fine on native.

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-02-08T16:36:34Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator · 2023-02-09T12:58:59Z

@0xmiroslav do you have time to test this today? :D it's causing issues testing iOS in other PRs

0xmiros · 2023-02-09T13:00:28Z

@0xmiroslav do you have time to test this today? :D it's causing issues testing iOS in other PRs

yes, still testing now from yesterday. will update soon

0xmiros · 2023-02-09T17:26:38Z

react-native-reanimated 3.0.0-rc.6 -> 3.0.0-rc.10 big changes:

Add support for React Native 0.71 by @tomekzaw in Add support for React Native 0.71 software-mansion/react-native-reanimated#3745

react-native-gesture-handler 2.6.0 -> 2.9.0 important changes:

Support React Native 0.71 by @j-piasecki in Support React Native 0.71 software-mansion/react-native-gesture-handler#2313
Add userSelect prop by @Warus15 in Add userSelect prop software-mansion/react-native-gesture-handler#2280
Make gesture required prop in GestureDetector by @Warus15 in Make gesture required prop in GestureDetector software-mansion/react-native-gesture-handler#2285
Change default Kotlin version by @j-piasecki in Change default Kotlin version software-mansion/react-native-gesture-handler#2224
Transform entire MotionEvent instead of single pointer only by @j-piasecki in Transform entire MotionEvent instead of single pointer only software-mansion/react-native-gesture-handler#2156
Touch events web by @Warus15 in Touch events web software-mansion/react-native-gesture-handler#2177
Manual gesture receiving touch events by @Warus15 in Manual gesture receiving touch events software-mansion/react-native-gesture-handler#2188
Pointer events to touch events mapping by @Warus15 in Pointer events to touch events mapping software-mansion/react-native-gesture-handler#2207

Note: Bug fixes and miscellaneous fixes are not mentioned here for both packages

0xmiros · 2023-02-09T17:27:14Z

Some weird crashes happening in native apps. Still investigating

tomekzaw · 2023-02-09T17:30:31Z

Please run npm start -- --reset-cache to clear Metro cache due to changes in Reanimated Babel plugin.

0xmiros · 2023-02-09T17:33:40Z

Please run npm start -- --reset-cache to clear Metro cache due to changes in Reanimated Babel plugin.

@tomekzaw Gotcha. I missed -- when reset cache. npm start --reset-cache was what I tried.
Thanks for help 🙏

mountiny · 2023-02-09T17:56:27Z

Thanks for help!

0xmiros · 2023-02-09T18:25:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mountiny · 2023-02-09T18:34:46Z

@0xmiroslav Thanks! Do you plan to submit any screenshots there before approval? I think its clear you have tested this so probably not a requirement personally.

0xmiros · 2023-02-09T18:35:51Z

@0xmiroslav Thanks! Do you plan to submit any screenshots there before approval? I think its clear you have tested this so probably not a requirement personally.

Wait! I found issue. I will post here once I confirm it doesn't happen on production

mountiny · 2023-02-09T18:36:20Z

thank you!

0xmiros · 2023-02-09T18:52:46Z

I tested on all platforms - navigation, fade animations, slider, image zoom

Only 1 impact found so far: drawer animation not working on android chrome.
Before:

before.mp4

After:

after.mp4

I confirmed animation working on staging/production and also on main, but no visual animation after version updates of 2 packages (sometimes working). This happens only on android chrome. Works fine on all other platforms.

mountiny · 2023-02-09T18:55:44Z

Oh interesting, thank you for testing this thoroughly! @tomekzaw Would you have any idea or capacity to check if the chrome issue is fixed in some other version or why its happening? Thank you!

tomekzaw · 2023-02-09T18:59:46Z

@mountiny I will take a look at it tomorrow. I will keep you updated. Thanks for testing!

mountiny · 2023-02-09T19:17:01Z

Thank you!

tomekzaw · 2023-02-10T10:02:50Z

@0xmiroslav I'm trying to investigate the issue. Can you please describe what's the expected behavior of the drawer when you open a chat? Even when running the app in Google Chrome on my Mac, the drawer seems to behave non-deterministically even on the main branch.

In particular, when I open the chat with Concierge, sometimes the animation starts but sometimes it doesn't. Also, the animation is more likely to be skipped when I open two chats in turn, see the video recording:

main.mov

Here's a video recording from vit-updateReanimatedAndGestureHandler branch (this PR) for a comparision:

PR.mov

0xmiros · 2023-02-10T10:07:26Z

@tomekzaw I attached 2 videos here: Before and After.
If it looks like Before (this is from main), we are fine.
Even on main, I think animation isn't perfect for all platforms but after version update, I seldom see animations or not see at all.

mountiny · 2023-02-10T11:32:12Z

@0xmiroslav but you specifically noticed the issues on Android mWeb Chrome right? For the other platforms, was it fine from your testing?

0xmiros · 2023-02-10T11:35:53Z

@0xmiroslav but you specifically noticed the issues on Android mWeb Chrome right? For the other platforms, was it fine from your testing?

yes only on android chrome. I found no differences between production and this PR on other platforms

tomekzaw · 2023-02-10T14:24:43Z

@0xmiroslav @mountiny Thanks for providing more details. I'm aware of the fact that originally the bug has been found when testing this PR on Android mWeb Chrome. The thing is, I can reproduce this exact problem also on the main branch, also on other platforms. I can easily reproduce the bug when opening two chats in turn (A, B, then A again, then B again etc.). Here are the configurations that I've tested:

new.expensify.com (production) / Chrome on Mac: ✅ (seems to work fine)
main (14ebe26) / Chrome on Mac: ❌ (sometimes animation does not start)
main (14ebe26) / Chrome mWeb Android: ❌ (sometimes animation does not start)
vit-updateReanimatedAndGestureHandler (a4f8faa) / Chrome on Mac: ❌ (sometimes animation does not start)

The conclusion is that most likely this bug was actually introduced some time earlier and not in this PR.

@0xmiroslav Could you please check if you can reproduce this bug on commit 14ebe26 (from main branch)?

edit: Bad news, we actually managed to reproduce the bug on production on @j-piasecki's phone, will upload a recording soon.

mountiny · 2023-02-10T15:00:59Z

I know this is not ideal, if the animation does not work at all on Android chrome it is not great, but if it works on all other platforms the benefits of this upgrade might outweigh this issue and we could just follow up with investigation how to fix the original issue.

tomekzaw · 2023-02-10T15:03:53Z

Just for the record, as promised, here's the video recording of the bug on the production. I believe this may be related to the keyboard appearing as a result of focusing the text input.

Record_2023-02-10-15-57-19.mp4

if it works on all other platforms the benefits of this upgrade might outweigh this issue and we could just follow up with investigation how to fix the original issue.

Exactly.

0xmiros · 2023-02-10T15:08:13Z

@tomekzaw I attached 2 videos here: Before and After. If it looks like Before (this is from main), we are fine. Even on main, I think animation isn't perfect for all platforms but after version update, I seldom see animations or not see at all.

Here, isn't perfect meant sometimes animation is not working or smooth

mountiny · 2023-02-10T15:24:00Z

@0xmiroslav can you sum this up please. is the animation working fine on other platforms and mWeb Android you never got the animation to work?

If this is the case I think we could merge this and then have a follow up issue for why the Android mWeb animation does not work well. What do you think?

0xmiros · 2023-02-10T15:31:58Z

mWeb Android working fine (main)
mWeb Android you never got the animation to work (this branch)
animation working fine on all other platforms (both main and this branch)

Is this clear?

0xmiros · 2023-02-10T15:33:09Z

If needed, I can investigate this which upstream version exactly made mWeb android not work.

mountiny · 2023-02-10T15:43:08Z

@0xmiroslav I would say we can investigate that but we can merge this first too, basically now anyone trying to run from main is running to issues when running pods so it might be better to improve the developer experience here and investigate this bug as a follow up

Can you approve the PR?

0xmiros · 2023-02-10T16:27:00Z

We many need to post in slack to clear cache after pull from main and npm install

npm start -- --reset-cache

OSBotify · 2023-02-10T16:30:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-02-11T01:04:34Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-02-11T02:23:58Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-02-13T12:04:27Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-13T17:45:16Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.70-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update the reanimated versions

f361bb7

mountiny self-assigned this Feb 8, 2023

mountiny marked this pull request as ready for review February 8, 2023 16:35

mountiny requested a review from a team as a code owner February 8, 2023 16:35

melvin-bot bot requested review from youssef-lr and removed request for a team February 8, 2023 16:36

mountiny requested a review from 0xmiros February 8, 2023 17:47

mountiny mentioned this pull request Feb 8, 2023

Update gesture handler and reanimated packages #14703

Closed

54 tasks

mountiny added 2 commits February 9, 2023 15:19

Merge branch 'main' into vit-updateReanimatedAndGestureHandler

caa6a9e

Update the podfile lock file

a4f8faa

0xmiros approved these changes Feb 10, 2023

View reviewed changes

madmax330 approved these changes Feb 10, 2023

View reviewed changes

madmax330 merged commit fcdb73d into main Feb 10, 2023

madmax330 deleted the vit-updateReanimatedAndGestureHandler branch February 10, 2023 16:25

aimane-chnaif mentioned this pull request Feb 10, 2023

Add Emoji Category Picker #14532

Merged

54 tasks

OSBotify mentioned this pull request Feb 11, 2023

Deploy Checklist: New Expensify 2023-02-11 #15070

Closed

13 tasks

mountiny mentioned this pull request Feb 23, 2023

Payment issue for E/App PR#14946 #15465

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the reanimated and gesture handler versions #14946

Update the reanimated and gesture handler versions #14946

mountiny commented Feb 8, 2023 •

edited

Loading

MelvinBot commented Feb 8, 2023

Beamanator commented Feb 9, 2023

0xmiros commented Feb 9, 2023

0xmiros commented Feb 9, 2023

0xmiros commented Feb 9, 2023

tomekzaw commented Feb 9, 2023

0xmiros commented Feb 9, 2023

mountiny commented Feb 9, 2023

0xmiros commented Feb 9, 2023

mountiny commented Feb 9, 2023 •

edited

Loading

0xmiros commented Feb 9, 2023

mountiny commented Feb 9, 2023

0xmiros commented Feb 9, 2023

mountiny commented Feb 9, 2023

tomekzaw commented Feb 9, 2023 •

edited

Loading

mountiny commented Feb 9, 2023

tomekzaw commented Feb 10, 2023 •

edited

Loading

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023

tomekzaw commented Feb 10, 2023 •

edited

Loading

mountiny commented Feb 10, 2023

tomekzaw commented Feb 10, 2023 •

edited

Loading

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023 •

edited

Loading

OSBotify commented Feb 10, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 13, 2023

OSBotify commented Feb 13, 2023

Update the reanimated and gesture handler versions #14946

Update the reanimated and gesture handler versions #14946

Conversation

mountiny commented Feb 8, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 8, 2023

Beamanator commented Feb 9, 2023

0xmiros commented Feb 9, 2023

0xmiros commented Feb 9, 2023

react-native-reanimated 3.0.0-rc.6 -> 3.0.0-rc.10 big changes:

react-native-gesture-handler 2.6.0 -> 2.9.0 important changes:

0xmiros commented Feb 9, 2023

tomekzaw commented Feb 9, 2023

0xmiros commented Feb 9, 2023

mountiny commented Feb 9, 2023

0xmiros commented Feb 9, 2023

Reviewer Checklist

Screenshots/Videos

mountiny commented Feb 9, 2023 • edited Loading

0xmiros commented Feb 9, 2023

mountiny commented Feb 9, 2023

0xmiros commented Feb 9, 2023

mountiny commented Feb 9, 2023

tomekzaw commented Feb 9, 2023 • edited Loading

mountiny commented Feb 9, 2023

tomekzaw commented Feb 10, 2023 • edited Loading

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023

tomekzaw commented Feb 10, 2023 • edited Loading

mountiny commented Feb 10, 2023

tomekzaw commented Feb 10, 2023 • edited Loading

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023 • edited Loading

OSBotify commented Feb 10, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 13, 2023

OSBotify commented Feb 13, 2023

mountiny commented Feb 8, 2023 •

edited

Loading

mountiny commented Feb 9, 2023 •

edited

Loading

tomekzaw commented Feb 9, 2023 •

edited

Loading

tomekzaw commented Feb 10, 2023 •

edited

Loading

tomekzaw commented Feb 10, 2023 •

edited

Loading

tomekzaw commented Feb 10, 2023 •

edited

Loading

0xmiros commented Feb 10, 2023 •

edited

Loading