Add support for React Native 0.71 #3745

tomekzaw · 2022-11-07T07:59:15Z

Description

Closes #3871.

TODO

Won't do

Declare dependency on React-jsi & React-jsc based on ENV['USE_HERMES'] in RNReanimated.podspec - not necessary
Fix Jest testEnvironment, use react-native-env.js - still doesn't work
Do we still need kotlinVersion in build.gradle? - probably yes
Restore MBFingerTip in ReanimatedExample

Checklist

Check compatibility with older RN versions
Check if debugging worklets with Flipper works
Check if debugging in Android Studio works

cortinico

Let me know if you need further inputs on 0.71 support for Reanimated

android/build.gradle

## Description This PR aligns Example app with RN 0.70.5 app template in order to simplify the process of adoption of RN 0.71.0 (#3745). Even though Example never runs with Fabric enabled (it's Paper-only), I decided to leave new-arch Java and C++ files which will be deleted in 0.71.0-rc.0 for the sake of completeness. Example app has a few dependencies, e.g. SVG, PagerView or MaskedView - as of this PR they are autolinked instead of being linked manually in `settings.gradle`. I also removed some files specific for tvOS since we already have a separate app called TVOSExample. ### TODO: - [x] remove `react-native-gradle-plugin` from Example/package.json - [x] check Android / iOS - [ ] check debug / release - [x] check debugging worklets (Flipper needs to be launched before the app) - [x] check if `MaskedView` component works

This PR aligns Example app with RN 0.70.5 app template in order to simplify the process of adoption of RN 0.71.0 (#3745). Even though Example never runs with Fabric enabled (it's Paper-only), I decided to leave new-arch Java and C++ files which will be deleted in 0.71.0-rc.0 for the sake of completeness. Example app has a few dependencies, e.g. SVG, PagerView or MaskedView - as of this PR they are autolinked instead of being linked manually in `settings.gradle`. I also removed some files specific for tvOS since we already have a separate app called TVOSExample. - [x] remove `react-native-gradle-plugin` from Example/package.json - [x] check Android / iOS - [ ] check debug / release - [x] check debugging worklets (Flipper needs to be launched before the app) - [x] check if `MaskedView` component works

…atedUIImplementation`

android/src/main/cpp/NativeProxy.cpp

Example/src/App.tsx

FabricExample/android/app/build.gradle

FabricExample/App.tsx

piaskowyk

## Summary This PR fixes a warning that `debugToken_` field is unused in release mode after #3745 which gets escalated to a compile error thanks to `-Werror`. ## Test plan Check if Example app compiles in release mode.

dcangulo · 2023-01-11T06:05:29Z

Will this be backported to 2.X or do I have to use version 3 for RN 0.71?

tomekzaw · 2023-01-11T08:30:54Z

@dcangulo Yes, this change was backported to Reanimated2 branch in cb6857f and will be released in 2.14.0 this week.

## Description It seems that autolinking got complete overhaul in 0.71.0 as `android/app/src/main/jni` directory was deleted -> thus it works differently for sure now. Still need to dive into it. **FabricTestExample** * [x] Android * [x] iOS **TestsExample** * #1679 **FabricExample** * #1680 **TODO**: Consider whether to use `com.facebook.react:react-native:+` or `com.facebook.react:react-native` (without `+`) in `android/build.gradle` of the library. AFAIK the former takes highest available version from defined repositories (should be `node_modules`?), the latter uses version injected by React Native Gradle Plugin (but I believe it works since React Native 0.71.0 or 0.70.0 (need to check) -- so version check might be necessary). Decided to leave: ```gradle implementation 'com.facebook.react:react-native:+' ``` in library's `android/build.gradle` due to following reasons: * [Android's readme in RN repo](https://github.com/facebook/react-native/blob/e108e9ebf1e6c52b6eeffeb6c41f842ad95baa0d/android/README.md) * [Road to 0.71.0 post](reactwg/react-native-releases#41 (reply in thread)) Blocked by: * ~facebook/react-native#35306 * ~software-mansion/react-native-reanimated#3745 * ~software-mansion/react-native-gesture-handler#2313 (decided to fix version on commit) * ~`react-native-safe-area-context` - lacks support for RN71~ (created patch) * ~`@react-native-community/cli-platform-android` requires this patch: kkafar/RNS-tester@9edaaa9. The patch is already merged, but it is not shipped with `react-native` yet.~ **NOTE**: Example application will handled in separate PR, as there are problems with detox (it does not support 0.71 yet) and we run CI on that app. ## Changes * Updated examples * Updated library's build code ## Test code and steps to reproduce Run example applications ## Checklist - [ ] Ensured that CI passes

## Description This PR aligns Example app with RN 0.70.5 app template in order to simplify the process of adoption of RN 0.71.0 (software-mansion#3745). Even though Example never runs with Fabric enabled (it's Paper-only), I decided to leave new-arch Java and C++ files which will be deleted in 0.71.0-rc.0 for the sake of completeness. Example app has a few dependencies, e.g. SVG, PagerView or MaskedView - as of this PR they are autolinked instead of being linked manually in `settings.gradle`. I also removed some files specific for tvOS since we already have a separate app called TVOSExample. ### TODO: - [x] remove `react-native-gradle-plugin` from Example/package.json - [x] check Android / iOS - [ ] check debug / release - [x] check debugging worklets (Flipper needs to be launched before the app) - [x] check if `MaskedView` component works

## Description Closes software-mansion#3871. ### TODO - [x] Update Example app template to 0.71.0-rc.5 - [x] Update FabricExample app template to 0.71.0-rc.5 - [x] Consume shared libraries and headers from prefabs (partially done) - [x] Use `implementation "com.facebook.react:react-native` (without plus) for RN 0.71+ - [x] Use `implementation "com.facebook.react:react-native:+" // From node_modules` for older RN versions (leave as it it now) - [x] Make it work with Hermes - [x] Make it works with JSC - [x] Properly detect Hermes on Android - [x] Include `folly-flags.cmake` directly - [x] Use headers from path instead of prefabs - [x] Depend on `jscexecutor` and `hermes-executor` - [x] Fix Layout Animations on Paper due after removal of deprecated `UIImplementation` (facebook/react-native@e7d7563) - [x] Use TypeScript types directly from package - [x] Add #ifdefs for backward-incompatible code changes (e.g. `debugToken_`) - [x] Use different sourcesets for `UIImplementationProvider` - [x] Add missing `SystraceSection` in `UIManager_cloneNode` - [x] Confirm that `UIManager_cloneNode` and `UIManagerBinding` are identical to those in react-native - [x] Remove react-native.config.js - [x] Update metro-inspector-proxy patch ### Won't do - [ ] Declare dependency on `React-jsi` & `React-jsc` based on `ENV['USE_HERMES']` in RNReanimated.podspec - not necessary - [ ] Fix Jest `testEnvironment`, use `react-native-env.js` - still doesn't work - [ ] Do we still need `kotlinVersion` in build.gradle? - probably yes - [ ] Restore MBFingerTip in ReanimatedExample ### Checklist - [ ] Check compatibility with older RN versions - [ ] Check if debugging worklets with Flipper works - [ ] Check if debugging in Android Studio works

## Summary This PR fixes a warning that `debugToken_` field is unused in release mode after software-mansion#3745 which gets escalated to a compile error thanks to `-Werror`. ## Test plan Check if Example app compiles in release mode.

## Description It seems that autolinking got complete overhaul in 0.71.0 as `android/app/src/main/jni` directory was deleted -> thus it works differently for sure now. Still need to dive into it. **FabricTestExample** * [x] Android * [x] iOS **TestsExample** * software-mansion/react-native-screens#1679 **FabricExample** * software-mansion/react-native-screens#1680 **TODO**: Consider whether to use `com.facebook.react:react-native:+` or `com.facebook.react:react-native` (without `+`) in `android/build.gradle` of the library. AFAIK the former takes highest available version from defined repositories (should be `node_modules`?), the latter uses version injected by React Native Gradle Plugin (but I believe it works since React Native 0.71.0 or 0.70.0 (need to check) -- so version check might be necessary). Decided to leave: ```gradle implementation 'com.facebook.react:react-native:+' ``` in library's `android/build.gradle` due to following reasons: * [Android's readme in RN repo](https://github.com/facebook/react-native/blob/e108e9ebf1e6c52b6eeffeb6c41f842ad95baa0d/android/README.md) * [Road to 0.71.0 post](reactwg/react-native-releases#41 (reply in thread)) Blocked by: * ~facebook/react-native#35306 * ~software-mansion/react-native-reanimated#3745 * ~software-mansion/react-native-gesture-handler#2313 (decided to fix version on commit) * ~`react-native-safe-area-context` - lacks support for RN71~ (created patch) * ~`@react-native-community/cli-platform-android` requires this patch: kkafar/RNS-tester@9edaaa9. The patch is already merged, but it is not shipped with `react-native` yet.~ **NOTE**: Example application will handled in separate PR, as there are problems with detox (it does not support 0.71 yet) and we run CI on that app. ## Changes * Updated examples * Updated library's build code ## Test code and steps to reproduce Run example applications ## Checklist - [ ] Ensured that CI passes

javier545dev · 2024-07-10T01:54:41Z

how to implement react native reanimated to nx monorepo project with react webpack? please

piaskowyk added 3 commits November 7, 2022 10:25

Update react-native version to 0.70.5

5289bdf

Update Podfile.lock

a5894fc

Update Podfile.lock for Fabric

9cbdc94

cortinico reviewed Nov 7, 2022

View reviewed changes

android/build.gradle Outdated Show resolved Hide resolved

tomekzaw added 2 commits November 7, 2022 14:49

iOS works

58aba40

Android works

e869e54

tomekzaw mentioned this pull request Nov 7, 2022

Align Example app template with 0.70.5 #3750

Merged

5 tasks

tomekzaw added 6 commits November 7, 2022 17:23

Merge branch 'main' into @tomekzaw/update-example-app-template

fe6f145

Autolink other libraries

5f89158

More changes

2ae53e6

Some more changes

555df06

Update Example app to 0.71.0-rc.0

1156012

Workarounds for Android

fe18e29

tomekzaw added 15 commits November 8, 2022 11:51

Merge branch 'main' into @tomekzaw/support-71-paper

f7d578a

Update download_aar.sh

ef80828

Bump react-native in package root

4863fd3

Fix Layout Animations by overwriting mUIImplementation with `Reanim…

99c2821

…atedUIImplementation`

Fix getting app project

5f734d6

Use artifacts from maven-local.zip

3f3e754

Run Example app with Hermes enabled

f514473

Use glog from prefab

61773f7

Use fbjni from prefab

821356f

Use folly from prefab

341589c

Use jsi from prefab

11728c8

Remove boost

0b4190c

Remove double-conversion

74b1d6d

Remove unnecessary header paths

56355ba

Set Folly flags

238afa2

tomekzaw added 8 commits December 30, 2022 11:11

Consume React Native types directly from package

2b0eb9e

Bring back dependencies

8798006

Rename utility functions

95281e0

Rename systrace section

ea8922b

Eliminate code duplication

906dbeb

Align Example app with template

a9b4f41

Update Podfile.lock

4b0a997

Update yarn.lock

374888e

tomekzaw requested a review from piaskowyk December 30, 2022 12:11

tomekzaw marked this pull request as ready for review December 30, 2022 12:11

piaskowyk reviewed Jan 3, 2023

View reviewed changes

android/src/main/cpp/NativeProxy.cpp Outdated Show resolved Hide resolved

Example/src/App.tsx Outdated Show resolved Hide resolved

FabricExample/android/app/build.gradle Show resolved Hide resolved

FabricExample/App.tsx Outdated Show resolved Hide resolved

tomekzaw added 3 commits January 3, 2023 13:27

Restore original App.tsx

ac5be7d

Remove unnecessary import

e631e67

Restore isReanimatedExampleApp flag in FabricExample

7cec411

piaskowyk approved these changes Jan 3, 2023

View reviewed changes

piaskowyk merged commit d3aea04 into main Jan 3, 2023

piaskowyk deleted the @tomekzaw/add-0.71-support branch January 3, 2023 16:42

tomekzaw mentioned this pull request Jan 4, 2023

Fix unused debugToken_ in release mode #3909

Merged

piaskowyk added a commit that referenced this pull request Jan 10, 2023

Add support for React Native 0.71 (#3745)

cb6857f

0xmiros mentioned this pull request Feb 9, 2023

Update the reanimated and gesture handler versions Expensify/App#14946

Merged

54 tasks

Latropos mentioned this pull request Sep 22, 2023

Add compatibility table #5122

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for React Native 0.71 #3745

Add support for React Native 0.71 #3745

tomekzaw commented Nov 7, 2022 •

edited

Loading

cortinico left a comment

piaskowyk left a comment

dcangulo commented Jan 11, 2023

tomekzaw commented Jan 11, 2023 •

edited

Loading

javier545dev commented Jul 10, 2024

Add support for React Native 0.71 #3745

Add support for React Native 0.71 #3745

Conversation

tomekzaw commented Nov 7, 2022 • edited Loading

Description

TODO

Won't do

Checklist

cortinico left a comment

Choose a reason for hiding this comment

piaskowyk left a comment

Choose a reason for hiding this comment

dcangulo commented Jan 11, 2023

tomekzaw commented Jan 11, 2023 • edited Loading

javier545dev commented Jul 10, 2024

tomekzaw commented Nov 7, 2022 •

edited

Loading

tomekzaw commented Jan 11, 2023 •

edited

Loading