-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/16448: Reset displayListViewBorder if user don't select option #16875
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
@iwiznia @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
We need to merge [this PR] or hash the commit
in package.json |
src/components/AddressSearch/resetDisplayListViewBorderWhenBlur/index.js
Outdated
Show resolved
Hide resolved
@eVoloshchak Thanks for your comment. I just updated, could you help to check again? |
src/components/AddressSearch/resetDisplayListViewBorderOnBlur.native.js
Outdated
Show resolved
Hide resolved
src/components/AddressSearch/resetDisplayListViewBorderOnBlur.js
Outdated
Show resolved
Hide resolved
src/components/AddressSearch/resetDisplayListViewBorderOnBlur.native.js
Outdated
Show resolved
Hide resolved
onBlur: props.onBlur, | ||
onBlur: (event) => { | ||
resetDisplayListViewBorderOnBlur(event, containerRef, setDisplayListViewBorder); | ||
props.onBlur(event); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props.onBlur(event); | |
props.onBlur(event); |
Do we need to pass event
to onBlur
here?
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eVoloshchak I think it is unnecessary. Just updated. Could you help to check again and also review this PR
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-04-06.at.18.38.46.movMobile Web - ChromeScreen_Recording_20230406-184046_Chrome.mp4Mobile Web - SafariScreen.Recording.2023-04-06.at.18.44.01.movDesktopScreen.Recording.2023-04-06.at.18.48.02.moviOSScreen.Recording.2023-04-06.at.18.42.40.movAndroidScreen_Recording_20230406-184150_New.Expensify.mp4 |
Looks good and test well!
@iwiznia, could you take a look at Expensify/react-native-google-places-autocomplete#3 please? |
@eVoloshchak Conflicts resolved and fork version updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested all the platforms, everything works as expected
@tienifr, there still seem to be some merge conflicts
@eVoloshchak I've resolved the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc: @iwiznia
Conflicts |
@iwiznia I've resolved it. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.6-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.6-0 🚀
|
Details
The displayListViewBorder is set to false if the user selects an option, but is not if the user blurs out of the GooglePlacesAutocomplete. So we need to set the displayListViewBorder to false when the user blurs the address search input and the options list.
Fixed Issues
$ #16448
PROPOSAL: #16448 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-04-04.at.16.10.04.mov
Mobile Web - Chrome
Screen.Recording.2023-04-04.at.16.11.12.mov
Mobile Web - Safari
Screen.Recording.2023-04-04.at.16.10.39.mov
Desktop
Screen.Recording.2023-04-04.at.16.14.12.mov
IOS
Screen.Recording.2023-04-04.at.21.37.34.mov
Android
Screen-Recording-2023-04-04-at-21.34.26.mp4