This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
Update latest version #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: upd broken docs link
fix: fix irregular separator height
feat: add inbetweenCompo prop in GooglePlacesAutocomplete component
…ct_onblur Added event object to `onBlur` and `onFocus` method sent through `textInputProps`
fixed event object for onFocus method in textInputProps
update version
This was referenced Apr 4, 2023
eVoloshchak
approved these changes
Apr 6, 2023
This comment was marked as outdated.
This comment was marked as outdated.
iwiznia
approved these changes
Apr 10, 2023
|
Can't merge this... should we remove this requirement from this repo? |
It seems logical to remove it for the forked repositories, but if that's a security concern - we can just cherry-pick those changes and rebase this PR with a signed commit |
|
Bump @eVoloshchak @iwiznia to check if the internal discussion had any updates. |
|
Looks like it was decided to remove the signed commits requirement in all of the forks. |
|
Oh sorry, yes, it is done. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This update is requested in this issue. This PR only merge the latest version 2.5.1 from the original react-native-google-places-autocomplete library.
Fixed Issues
$ Expensify/App#16448
PROPOSAL: Expensify/App#16448 (comment)
Tests
e8346780c43c33b55b62d0241d8a209b48c522a5for react-native-google-places-autocomplete in package.json then run npm installOffline tests
QA Steps
e8346780c43c33b55b62d0241d8a209b48c522a5for react-native-google-places-autocomplete in package.json then run npm installScreenshots/Videos
Web
Screen.Recording.2023-04-04.at.16.10.04.mov
Mobile Web - Chrome
Screen.Recording.2023-04-04.at.16.11.12.mov
Mobile Web - Safari
Screen.Recording.2023-04-04.at.16.10.39.mov
Desktop
Screen.Recording.2023-04-04.at.16.14.12.mov
IOS
Screen.Recording.2023-04-04.at.21.37.34.mov
Android
Screen-Recording-2023-04-04-at-21.34.26.mp4