Corrected confirm task button bottom margin #18843

PrashantMangukiya · 2023-05-12T16:10:52Z

@sobitneupane @flodnv PR is ready for review.

Details

On Confirm task page, the vertical gap of "Confirm task" button from the bottom is off as compared to other pages button. So in this PR we corrected the bottom gap for "Confirm task" Button.

Note: This issue happens with iOS native only. But screenshot uploaded for all platforms to make sure there is not any side effect.

Fixed Issues

$ #18739
PROPOSAL: #18739 (comment)

Tests

To test this make sure Task beta should be enabled.
Click FAB > Assign Task
Enter Task title desc etc. within form input and click Next button (at bottom)
It will navigate to Confirm task screen.
Verify that "Confirm task" button has bottom margin similar to previous page button.

Verify that no errors appear in the JS console

Offline tests

To test this make sure Task beta should be enabled.
Click FAB > Assign Task
Enter Task title desc etc. within form input and click Next button (at bottom)
It will navigate to Confirm task screen.
Verify that "Confirm task" button has bottom margin similar to previous page button.

QA Steps

To test this make sure Task beta should be enabled.
Click FAB > Assign Task
Enter Task title desc etc. within form input and click Next button (at bottom)
It will navigate to Confirm task screen.
Verify that "Confirm task" button has bottom margin similar to previous page button.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Chrome

Web-Chrome.mov

Safari

Web-Safari.mov

Mobile Web - Chrome

MWeb-Chrome.mov

Mobile Web - Safari

MWeb-Safari.mov

Desktop

Desktop.mov

iOS

iOS.mov

Android

Android.mov

melvin-bot · 2023-05-12T16:10:57Z

@flodnv @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

sobitneupane · 2023-05-15T08:27:21Z

With offline message, the bottom docked button appear quite higher in components within Form component than the component using screenwrapper with includeSafeAreaPaddingBottom true in IOS only. It doesn't look related to this PR. cc: @flodnv

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

flodnv · 2023-05-15T15:07:57Z

With offline message, the bottom docked button appear quite higher in components within Form component than the component using screenwrapper with includeSafeAreaPaddingBottom true in IOS only. It doesn't look related to this PR.

Weird, let's create another bug report I suppose...?

flodnv · 2023-05-15T15:10:28Z

src/pages/tasks/NewTaskPage.js

@@ -150,7 +150,7 @@ const NewTaskPage = (props) => {
    }

    return (
-        <ScreenWrapper includeSafeAreaPaddingBottom={false}>


@tgolen @thienlnam @fedirjh is there any particular reason it was built like that in #17992, that we are missing and for which we should not make this bug fix?

Additionally, should we also make this change in other places where it was done like that in that particular PR?

I don't believe so, I think it was just a styling thing that was copied from another file

You don't believe what? that there is something we are missing and for which we should not make this bug fix? that we should also make this change in other places where it was done like that in that particular PR? both?

I don't believe that there is any particular reason it was built like that. We should also make this same change on other task pages if it hasn't already been done (Assignee, Description, Title Pages)

Can you do that please?

PrashantMangukiya · 2023-05-17T13:02:46Z

@flodnv are we able to merge pr within timeline, otherwise I may get 50% penalty if merged after 9 days since assigned. Thank you.

flodnv · 2023-05-17T15:26:53Z

Thanks for the bump, I have bumped the above comment here: https://expensify.slack.com/archives/C01GTK53T8Q/p1684337157276239. Please bump us again if it is not answered within 12 hours

OSBotify · 2023-05-17T19:20:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-18T07:38:33Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-22T23:40:00Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T00:15:55Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T19:53:49Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T21:52:33Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Corrected confirm task button bottom margin

c34f594

PrashantMangukiya requested a review from a team as a code owner May 12, 2023 16:10

melvin-bot bot requested review from flodnv and sobitneupane and removed request for a team May 12, 2023 16:10

sobitneupane reviewed May 15, 2023

View reviewed changes

sobitneupane approved these changes May 15, 2023

View reviewed changes

flodnv reviewed May 15, 2023

View reviewed changes

flodnv approved these changes May 17, 2023

View reviewed changes

flodnv merged commit 021657b into Expensify:main May 17, 2023

OSBotify mentioned this pull request May 18, 2023

Deploy Checklist: New Expensify 2023-05-18 #19175

Closed

39 tasks

melvin-bot bot mentioned this pull request May 22, 2023

[HOLD for payment 2023-05-29] [$1000] On the "Confirm Task" page, the vertical alignment alignment is off compared with all the previous page ("Next") #18739

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Corrected confirm task button bottom margin #18843

Corrected confirm task button bottom margin #18843

PrashantMangukiya commented May 12, 2023

melvin-bot bot commented May 12, 2023

sobitneupane left a comment •

edited

Loading

sobitneupane commented May 15, 2023

sobitneupane left a comment

flodnv commented May 15, 2023

flodnv May 15, 2023

thienlnam May 17, 2023

flodnv May 17, 2023 •

edited

Loading

thienlnam May 17, 2023

flodnv May 18, 2023

thienlnam May 19, 2023

PrashantMangukiya commented May 17, 2023

flodnv commented May 17, 2023

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

OSBotify commented May 22, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

Corrected confirm task button bottom margin #18843

Corrected confirm task button bottom margin #18843

Conversation

PrashantMangukiya commented May 12, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Chrome

Safari

melvin-bot bot commented May 12, 2023

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented May 15, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

flodnv commented May 15, 2023

flodnv May 15, 2023

Choose a reason for hiding this comment

thienlnam May 17, 2023

Choose a reason for hiding this comment

flodnv May 17, 2023 • edited Loading

Choose a reason for hiding this comment

thienlnam May 17, 2023

Choose a reason for hiding this comment

flodnv May 18, 2023

Choose a reason for hiding this comment

thienlnam May 19, 2023

Choose a reason for hiding this comment

PrashantMangukiya commented May 17, 2023

flodnv commented May 17, 2023

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

OSBotify commented May 22, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

sobitneupane left a comment •

edited

Loading

flodnv May 17, 2023 •

edited

Loading