Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLA to not lock pull requests after merge #1998

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Mar 22, 2021

Details

Updates our CLA bot to not lock pull requests are merged, I asked them to implement this feature for us and they did! 🥳

contributor-assistant/github-action#77
contributor-assistant/github-action#78

Fixed Issues

Fixes contributor-assistant/github-action#77

Tests

  1. Merge this PR
  2. It will lock this PR as the last PR to be locked (pull_request_target is triggered on master, not on the code on the head branch)
  3. I will create a new "test" PR
  4. I will verify it is not locked

@AndrewGable AndrewGable requested a review from a team as a code owner March 22, 2021 21:23
@AndrewGable AndrewGable self-assigned this Mar 22, 2021
@botify botify requested review from alex-mechler and removed request for a team March 22, 2021 21:23
@AndrewGable
Copy link
Contributor Author

Self merging!

@AndrewGable AndrewGable merged commit 8e7f2c6 into master Mar 23, 2021
@AndrewGable AndrewGable deleted the andrew-cla-lock branch March 23, 2021 15:08
@AndrewGable
Copy link
Contributor Author

Looks like there is actually no need to create another test PR, this didn't lock so we are good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Make locking pull request an optional flag
2 participants