Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make locking pull request an optional flag #77

Closed
AndrewGable opened this issue Mar 12, 2021 · 3 comments · Fixed by Expensify/App#1998, Expensify/expensify-common#356 or Expensify/react-native-onyx#54
Assignees
Labels

Comments

@AndrewGable
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In our open source repo we sometimes have contributors who accidentally close their PRs, which locks them as mentioned here: #70 (comment)

The contributors cannot comment after this happens, leaving them to ask if we can manually unlock the pull request so they can comment and continue working on their solution. Otherwise they have to create a new pull request which can be time consuming.

Describe the solution you'd like
I would prefer the "locking" behavior to be an optional flag and we'd prefer it to not lock on our repository. We understand that contributors could delete or edit their comments, but we are OK with this trade off.

Describe alternatives you've considered
Alternatively, could we "unlock"/"re-open" the PR once the PR is reopened?

Additional context
Here is an example pull request (Expensify/App#1739) where it's locked, then reopened.

@ibakshay
Copy link
Member

Hi @AndrewGable, Absolutely, 100 percent!. This feature request makes a lot of sense. I will work on this topic and I will get it done before the end of next week :) . I will let you know here soon after I have made a new release :)

@ibakshay
Copy link
Member

This feature is implemented and reflected in the new release v2.1.2-beta :) .
You need to add this input lock-pullrequest-aftermerge: false to your CLA action and then the pull request won't be locked automatically by CLA action bot anymore.

@AndrewGable
Copy link
Contributor Author

Thank you @ibakshay! I updated all our repos to the latest version.

dentarg added a commit to cloudamqp/lavinmq that referenced this issue Apr 5, 2024
I don't think we want the CLA workflow to lock pull requests if they are closed/merged.

See this issue for context contributor-assistant/github-action#77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment