Reattempt to fix multiline comment link show pointer cursor in the empty space line #20114

bernhardoj · 2023-06-03T04:37:47Z

Details

Reverting #17496 and reattempt to fix the initial issue #16526.

Fixed Issues

$ #19717
$ #19934
PROPOSAL: #19934 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Attachment

Send an image and non image attachment to a chat
Click/Press on the empty space of the attachment chat message
Verify there is no action happen

Link (iOS/Android/mWeb)

Send a link to a chat
Long press on the empty space of the link chat message
Verify a common context menu appears
Long press on the link
Verify a Copy URL to clipboard context menu appears

To make sure #16526 is fixed here (Web/Desktop):

Send a long link to a chat
link example:

[Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer ornare dignissim nunc, eleifend molestie dui tempus non. Proin semper eu metus sit amet feugiat. Sed turpis augue, pellentesque sed accumsan ornare, malesuada in ligula. Aliquam porta condimentum varius. Morbi id lorem felis.](https://google.com/)

Hover over the link
Verify the cursor changes to pointer
Hover over empty area next to link
Verify the cursor changes to normal cursor

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-06-03.at.11.40.57.mov

Mobile Web - Chrome

Screen.Recording.2023-06-03.at.12.07.57.mov

Mobile Web - Safari

Screen.Recording.2023-06-03.at.12.02.02.mov

Desktop

Screen.Recording.2023-06-03.at.11.43.43.mov

iOS

Screen.Recording.2023-06-03.at.11.56.09.mov

Android

Screen.Recording.2023-06-03.at.12.13.29.mov

…-16526" This reverts commit b249584, reversing changes made to 4492f90.

melvin-bot · 2023-06-03T04:37:52Z

@Gonals @narefyev91 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-06-03T04:39:50Z

Oops, I think @thesahindia @grgia should be the one that review this? I linked #19934 too because the proposal I use is from my comment over there.

grgia · 2023-06-05T13:54:13Z

@bernhardoj no problem, I'll fix the reviewers. In the future, no need to link already closed/dupe issues!

grgia

@bernhardoj can you please update the Test Steps and QA steps for this PR

grgia · 2023-06-05T13:58:26Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.js

    ...anchorForCommentsOnlyPropTypes,
    ...windowDimensionsPropTypes,
 };

 const defaultProps = {
    onPressIn: undefined,
    onPressOut: undefined,
+    containerStyles: {},


Let's use the array and spread syntax described here https://github.com/Expensify/App/blob/main/contributingGuides/STYLING.md#complex-component

bernhardoj · 2023-06-05T15:45:56Z

@grgia sorry, which part of the test should I update? Is it missing any step?

grgia

changes look good, @thesahindia I think this is ready for C+ review, thanks!

thesahindia · 2023-06-06T11:50:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-06.at.4.37.30.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-06-06.at.4.59.52.PM.mov

Mobile Web - Safari

Screen.Recording.2023-06-06.at.5.05.07.PM.mov

Desktop

Screen.Recording.2023-06-06.at.4.44.17.PM.mov

iOS

Screen.Recording.2023-06-06.at.5.01.23.PM.mov

Android

Screen.Recording.2023-06-06.at.4.57.52.PM.mov

thesahindia

Looks good to me as well!

cc: @grgia

thesahindia · 2023-06-07T13:16:46Z

Friendly bump @grgia.

OSBotify · 2023-06-07T13:23:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

eh2077 · 2023-06-08T02:27:23Z

@bernhardoj @thesahindia @grgia It looks like this PR will display a normal link in a separate line. I found it when I'm preparing the PR for the other issue.

For example we can add a comment like

This is a [link](google.com) to Google

See demo video

Screen.Recording.2023-06-08.at.10.23.11.AM.mov

bernhardoj · 2023-06-08T03:30:11Z

That makes sense because the link display is now block. I think we should revert this PR.

(or maybe I can push a new PR that reverts this and include a different changes?)
@thesahindia @grgia

thesahindia · 2023-06-08T03:55:03Z

Thanks @eh2077 for mentioning it. @bernhardoj, yes please go ahead. Let's resolve this quickly.

bernhardoj · 2023-06-08T04:39:29Z

PR is here #20440
@thesahindia @grgia

Nikhil-Vats · 2023-06-08T13:44:09Z

src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js

@@ -60,7 +60,7 @@ const ImageRenderer = (props) => {
                >
                    {({show}) => (
                        <PressableWithoutFocus
-                            styles={[styles.noOutline, styles.alignItemsStart]}
+                            style={styles.noOutline}


Invalid prop being passed here. The correct prop is styles.

Interesting. That change is a straight revert from this
https://github.com/Expensify/App/pull/17496/files#diff-d5148cab886899d1e6ec29f3b13f0d9ea4736d2db1324586afb18ebeb8a611b0L69

which means the style props has been wrong for a long time.

But the noOutline style will hide the focus outline when we navigate with keyboard.

Here is how it looks if we have the outline

consistent with what we have in attachment

So, I guess we should remove the style?

@grgia @thesahindia

nevermind, @Nikhil-Vats handle this in their PR #19545

Thanks for taking care of it @Nikhil-Vats!

OSBotify · 2023-06-08T17:03:09Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T00:23:51Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 2 commits June 3, 2023 11:14

Revert "Merge pull request Expensify#17496 from aswin-s/aswin_s/issue…

1a16bf7

…-16526" This reverts commit b249584, reversing changes made to 4492f90.

fix inline display comment links

915696b

bernhardoj requested a review from a team as a code owner June 3, 2023 04:37

melvin-bot bot requested review from Gonals and narefyev91 and removed request for a team June 3, 2023 04:37

bernhardoj added 2 commits June 3, 2023 13:54

fix lint

e87fd28

fix prettier

5469d60

grgia requested review from grgia and thesahindia and removed request for Gonals and narefyev91 June 5, 2023 13:54

grgia requested changes Jun 5, 2023

View reviewed changes

update style props to accept array only

2054854

suppress lint

0f73cfd

grgia approved these changes Jun 6, 2023

View reviewed changes

thesahindia approved these changes Jun 6, 2023

View reviewed changes

grgia merged commit ff31072 into Expensify:main Jun 7, 2023

bernhardoj mentioned this pull request Jun 8, 2023

Fix link is shown in a separate line #20440

Merged

57 tasks

thesahindia mentioned this pull request Jun 8, 2023

[$1000] Attachment downloaded when user clicked outside the attachment button #19717

Closed

6 tasks

Nikhil-Vats reviewed Jun 8, 2023

View reviewed changes

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

situchan mentioned this pull request Jun 11, 2023

[HOLD for payment 2023-07-06] [HOLD App#20694] mWeb - Task - Assignees email is beyond the screen #20566

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 12, 2023

[HOLD for payment 2023-06-19] [$1000] Long-pressing the empty right section of a message with just a link doesn't show correct options. #19934

Closed

6 tasks

Nikhil-Vats mentioned this pull request Jun 14, 2023

[HOLD for payment 2023-06-30] [$1000] Chat - Deleted messages with heading style not strike-through in offline #18658

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reattempt to fix multiline comment link show pointer cursor in the empty space line #20114

Reattempt to fix multiline comment link show pointer cursor in the empty space line #20114

bernhardoj commented Jun 3, 2023

melvin-bot bot commented Jun 3, 2023

bernhardoj commented Jun 3, 2023

grgia commented Jun 5, 2023

grgia left a comment

grgia Jun 5, 2023

bernhardoj Jun 5, 2023

bernhardoj commented Jun 5, 2023

grgia left a comment

thesahindia commented Jun 6, 2023

thesahindia left a comment

thesahindia commented Jun 7, 2023

OSBotify commented Jun 7, 2023

eh2077 commented Jun 8, 2023

bernhardoj commented Jun 8, 2023 •

edited

Loading

thesahindia commented Jun 8, 2023

bernhardoj commented Jun 8, 2023

Nikhil-Vats Jun 8, 2023

bernhardoj Jun 8, 2023

bernhardoj Jun 8, 2023

thesahindia Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

Reattempt to fix multiline comment link show pointer cursor in the empty space line #20114

Reattempt to fix multiline comment link show pointer cursor in the empty space line #20114

Conversation

bernhardoj commented Jun 3, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 3, 2023

bernhardoj commented Jun 3, 2023

grgia commented Jun 5, 2023

grgia left a comment

Choose a reason for hiding this comment

grgia Jun 5, 2023

Choose a reason for hiding this comment

bernhardoj Jun 5, 2023

Choose a reason for hiding this comment

bernhardoj commented Jun 5, 2023

grgia left a comment

Choose a reason for hiding this comment

thesahindia commented Jun 6, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

thesahindia commented Jun 7, 2023

OSBotify commented Jun 7, 2023

eh2077 commented Jun 8, 2023

bernhardoj commented Jun 8, 2023 • edited Loading

thesahindia commented Jun 8, 2023

bernhardoj commented Jun 8, 2023

Nikhil-Vats Jun 8, 2023

Choose a reason for hiding this comment

bernhardoj Jun 8, 2023

Choose a reason for hiding this comment

bernhardoj Jun 8, 2023

Choose a reason for hiding this comment

thesahindia Jun 8, 2023

Choose a reason for hiding this comment

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

bernhardoj commented Jun 8, 2023 •

edited

Loading