Fix link is shown in a separate line #20440

bernhardoj · 2023-06-08T04:39:09Z

Details

This is a regression of #20114.

Fixed Issues

$ #19717
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Attachment

Send an image and non image attachment to a chat
Click/Press on the empty space of the attachment chat message
Verify there is no action happen

Link (iOS/Android/mWeb)

Send a link to a chat
Long press on the empty space of the link chat message
Verify a common context menu appears
Long press on the link
Verify a Copy URL to clipboard context menu appears

To make sure #16526 is fixed here (Web/Desktop):

Send a long link to a chat
link example:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer ornare dignissim nunc, eleifend molestie dui tempus non. Proin semper eu metus sit amet feugiat. Sed turpis augue, pellentesque sed accumsan ornare, malesuada in ligula. Aliquam porta condimentum varius. Morbi id lorem felis.
Hover over the link
Verify the cursor changes to pointer
Hover over empty area next to link
Verify the cursor changes to normal cursor

Link with text

Send a link with normal text to a chat, for example here is a [link](google.com)
Verify the link is on the same line with normal text

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.mweb.mov

Mobile Web - Safari

ios.mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-06-08T04:39:14Z

@grgia @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-06-08T04:39:57Z

Turns out it just need a little changes, so no need to revert.

The test step is copied from previous PR and added a test for link with normal text.

bernhardoj · 2023-06-08T04:40:25Z

src/components/AnchorForCommentsOnly/index.js

-        {...props}
-        onPressIn={() => DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
-        onPressOut={() => ControlSelection.unblock()}
-        // HTML renderer root view display is flex. Using flex will force all child elements


Removed this comment because actually we can use the display inline, so I think the comment is not valid anymore.

@bernhardoj can you please tell me the purpose of this View wrapper with display inline here?
I was working on #19545 which was also a regression from the same PR as your original issue and I will remove this wrapper.

I am checking all the related issues to make sure it doesn't break anything but just wanted to get your opinion.

bernhardoj · 2023-06-08T04:42:40Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.js

@@ -51,41 +51,39 @@ const BaseAnchorForCommentsOnly = (props) => {
    const isEmail = Str.isValidEmailMarkdown(props.href.replace(/mailto:/i, ''));

    return (
-        <View style={[...props.containerStyles]}>


Removed the View from here and move it to AnchorForCommentsOnly/index.js. Having a view here will misaligned the text in native.

thesahindia · 2023-06-08T08:07:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia · 2023-06-08T08:07:31Z

Thanks for the quick PR @bernhardoj!

thesahindia

LGTM!

cc: @grgia

grgia

lgtm

OSBotify · 2023-06-08T13:00:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-08T17:01:39Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T00:22:21Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix link is shown in a separate line

8883de7

bernhardoj requested a review from a team as a code owner June 8, 2023 04:39

melvin-bot bot requested review from grgia and thesahindia and removed request for a team June 8, 2023 04:39

bernhardoj mentioned this pull request Jun 8, 2023

Reattempt to fix multiline comment link show pointer cursor in the empty space line #20114

Merged

57 tasks

bernhardoj commented Jun 8, 2023

View reviewed changes

remove unused import

e37a362

thesahindia approved these changes Jun 8, 2023

View reviewed changes

thesahindia mentioned this pull request Jun 8, 2023

[$1000] Attachment downloaded when user clicked outside the attachment button #19717

Closed

6 tasks

grgia approved these changes Jun 8, 2023

View reviewed changes

grgia merged commit fa24e99 into Expensify:main Jun 8, 2023

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

lanitochka17 mentioned this pull request Jun 9, 2023

[HOLD #10894] Windows - Chat -Photo preview screen disappears after resizing window to full screen #20522

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix link is shown in a separate line #20440

Fix link is shown in a separate line #20440

bernhardoj commented Jun 8, 2023

melvin-bot bot commented Jun 8, 2023

bernhardoj commented Jun 8, 2023 •

edited

Loading

bernhardoj Jun 8, 2023

Nikhil-Vats Jun 8, 2023

bernhardoj Jun 8, 2023

thesahindia commented Jun 8, 2023

thesahindia commented Jun 8, 2023

thesahindia left a comment

grgia left a comment

OSBotify commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

Fix link is shown in a separate line #20440

Fix link is shown in a separate line #20440

Conversation

bernhardoj commented Jun 8, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 8, 2023

bernhardoj commented Jun 8, 2023 • edited Loading

bernhardoj Jun 8, 2023

Choose a reason for hiding this comment

Nikhil-Vats Jun 8, 2023

Choose a reason for hiding this comment

bernhardoj Jun 8, 2023

Choose a reason for hiding this comment

thesahindia commented Jun 8, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia commented Jun 8, 2023

thesahindia left a comment

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

bernhardoj commented Jun 8, 2023 •

edited

Loading