Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch dance! #20791

Merged
merged 45 commits into from
Jun 23, 2023
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
64369fb
Update protected branches without pull request
roryabraham Jun 15, 2023
3aa0723
Fix checkout in createNewVersion
roryabraham Jun 15, 2023
4cb2058
Dont use updateProtectedBranch from createNewVersion
roryabraham Jun 15, 2023
50f61b0
Dont use updateProtectedBranch from finishReleaseCycle
roryabraham Jun 15, 2023
e7d7730
Fix GPG password
roryabraham Jun 15, 2023
b0e9828
Remove updateProtectedBranch from preDeploy
roryabraham Jun 15, 2023
7d1e4e6
Remove updateProtectedBranch from finishReleaseCycle
roryabraham Jun 15, 2023
2ff4c95
Remove unused updateProtectedBranch action
roryabraham Jun 15, 2023
8fa0fce
Update documentation
roryabraham Jun 15, 2023
49658ef
Simplify createNewVersion by lifting turnstyle up
roryabraham Jun 15, 2023
efc10d6
Update tests to accurate represent new logic
roryabraham Jun 15, 2023
983153d
Cleanup tests a bit
roryabraham Jun 15, 2023
9174a34
Update tests to passing state
roryabraham Jun 15, 2023
2dcfaad
Simplify getPullRequestsMergedBetween implementation
roryabraham Jun 15, 2023
4294e5a
Use checkout v3
roryabraham Jun 15, 2023
a16e4b9
Filter out any commits by OSBotify from the checklist
roryabraham Jun 16, 2023
7e7a37a
Eliminate CPd PRs from next checklist
roryabraham Jun 16, 2023
8c6ec4e
Rebuild GH Actions
roryabraham Jun 16, 2023
4b614ba
Remove dummy command
roryabraham Jun 16, 2023
a7eab35
Uncomment code
roryabraham Jun 16, 2023
430bf2f
Fix GitUtilsTest
roryabraham Jun 16, 2023
21248dc
Rebuild GH Actions
roryabraham Jun 16, 2023
8b56f19
Remove PR_COUNT variable that seems to be messing up bashhh
roryabraham Jun 16, 2023
e42ea37
Remove unnecessary setupNode
roryabraham Jun 16, 2023
246312a
Secrets not inputs
roryabraham Jun 16, 2023
a6f4a46
Add setupNode back for underscore
roryabraham Jun 16, 2023
6cb914b
Create utility function for bumping version
roryabraham Jun 16, 2023
0766dd6
Create utility function for updating protected branch
roryabraham Jun 16, 2023
28282e6
Create utility function for merge_pr
roryabraham Jun 16, 2023
1643553
Create utility function for cherry_pick_pr
roryabraham Jun 16, 2023
a0b951f
Create tag_staging utility function
roryabraham Jun 16, 2023
5b30665
Add tests for the wonky case
roryabraham Jun 16, 2023
09fae72
Remove checkBundleVersionStringMatch
roryabraham Jun 16, 2023
7ee32c8
Only create pull request for cherrypick if theres a conflict
roryabraham Jun 16, 2023
30826f0
Remove unused isPullRequestMergeable actione
roryabraham Jun 16, 2023
e011630
Fix typo
roryabraham Jun 16, 2023
052291a
Merge branch 'main' into Rory-UseTheForce
roryabraham Jun 21, 2023
7e82c8a
Remove unnecessary safety check
roryabraham Jun 21, 2023
8a4ffcf
Update comments for branch dance
roryabraham Jun 21, 2023
d84db7b
Eliminate race condition in finishReleaseCycle
roryabraham Jun 21, 2023
c3c7224
Merge branch 'main' into Rory-UseTheForce
roryabraham Jun 21, 2023
d6bb512
Add CONST for OSBotify
roryabraham Jun 21, 2023
2140760
Fetch refs if needed from GitUtils so fetch-depth: 0 is not needed
roryabraham Jun 21, 2023
e680343
Add dependency for createNewStagingDeployCash
roryabraham Jun 21, 2023
93b0bd5
Update confusing comment
roryabraham Jun 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove checkBundleVersionStringMatch
roryabraham committed Jun 16, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 09fae724cacaa8db025da6e32994ca3a6d2083c8

This file was deleted.

This file was deleted.

3,359 changes: 0 additions & 3,359 deletions .github/actions/javascript/checkBundleVersionStringMatch/index.js

This file was deleted.

1 change: 0 additions & 1 deletion .github/scripts/buildActions.sh
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@ ACTIONS_DIR="$(dirname "$(dirname "$0")")/actions/javascript"
declare -r GITHUB_ACTIONS=(
"$ACTIONS_DIR/awaitStagingDeploys/awaitStagingDeploys.js"
"$ACTIONS_DIR/bumpVersion/bumpVersion.js"
"$ACTIONS_DIR/checkBundleVersionStringMatch/checkBundleVersionStringMatch.js"
"$ACTIONS_DIR/checkDeployBlockers/checkDeployBlockers.js"
"$ACTIONS_DIR/createOrUpdateStagingDeploy/createOrUpdateStagingDeploy.js"
"$ACTIONS_DIR/getDeployPullRequestList/getDeployPullRequestList.js"
16 changes: 1 addition & 15 deletions .github/workflows/cherryPick.yml
Original file line number Diff line number Diff line change
@@ -114,12 +114,8 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: Check if ShortVersionString is up to date
id: isShortVersionStringUpdated
uses: Expensify/App/.github/actions/javascript/checkBundleVersionStringMatch@main

- name: Auto-assign PR if there are merge conflicts or if the bundle versions are mismatched
if: ${{ !fromJSON(steps.cherryPick.outputs.SHOULD_AUTOMERGE) || !fromJSON(steps.isShortVersionStringUpdated.outputs.BUNDLE_VERSIONS_MATCH) }}
if: ${{ !fromJSON(steps.cherryPick.outputs.SHOULD_AUTOMERGE) }}
run: gh pr edit --add-label "Engineering,Hourly"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -140,16 +136,6 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: If PR has a bundle version mismatch, comment with the instructions for assignee
if: ${{ !fromJSON(steps.isShortVersionStringUpdated.outputs.BUNDLE_VERSIONS_MATCH) }}
run: |
gh pr comment --body \
"The CFBundleShortVersionString value in this PR is not compatible with the CFBundleVersion, so cherry picking it will result in an iOS deploy failure.
Please manually resolve the mismatch, push your changes, and then request another reviewer to review and merge.
**Important:** This mismatch can be caused by a failed Update Protected Branch workflow followed by a manual CP, but please confirm the cause of the mismatch before updating any version numbers."
env:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: Auto-approve the PR
# Important: only auto-approve if there was no merge conflict!
if: ${{ fromJSON(steps.cherryPick.outputs.SHOULD_AUTOMERGE) }}