Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: optimize getDefaultAvatar calculation #25816

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Performance: optimize getDefaultAvatar calculation #25816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
602dc4f
optimize getDefaultAvatar calculation
hannojg Aug 24, 2023
297ebbe
use const
hannojg Aug 24, 2023
bd1dafc
update comment
hannojg Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/UserUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ function getDefaultAvatar(accountID = -1) {
}

// There are 24 possible default avatars, so we choose which one this user has based
// on a simple hash of their login. Note that Avatar count starts at 1.
const accountIDHashBucket = hashText(accountID.toString(), CONST.DEFAULT_AVATAR_COUNT) + 1;
// on a simple modulo operation of their login number. Note that Avatar count starts at 1.
const accountIDHashBucket = (accountID % CONST.DEFAULT_AVATAR_COUNT) + 1;

return defaultAvatars[`Avatar${accountIDHashBucket}`];
}
Expand Down