Converted SidebarLinks to fn component and improve use of window props #27855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
allroundexperts
and removed request for
a team
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Unable to test on Android emulator due to this weird problem 
|
|
@allroundexperts Can you do the review? |
Comment on lines
+73
to
+75
| if (_.isNull(modalArg)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why is this needed?
There was a problem hiding this comment.
To prevent
if (modal.current.willAlertModalBecomeVisible) {
return;
}from erroring out when the modal is null in onyx initially (Safeguarding the modal ref)
allroundexperts
suggested changes
Sep 25, 2023
|
@allroundexperts Waiting for your comments |
|
@allroundexperts You can now continue |
|
@allroundexperts Can you do the review today? |
|
Yes @shubham1206agra! |
| constructor(props) { | ||
| super(props); | ||
| function SidebarLinks({onLinkClick, insets, optionListItems, isLoading, priorityMode = CONST.PRIORITY_MODE.DEFAULT, isActiveReport, isCreateMenuOpen}) { | ||
| const modal = useRef({}); |
There was a problem hiding this comment.
We usually pass a null as the initialiser.
There was a problem hiding this comment.
It actually depends on the case to case basis.
|
@allroundexperts Please check my comment |
|
@allroundexperts Can you please review? |
|
On it. |
|
@shubham1206agra Can you please resolve the conflicts? |
Reviewer Checklist
Screenshots/VideosWeb
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
|
|
@allroundexperts You can continue with your review |
|
@thienlnam Can you merge this? |
thienlnam
approved these changes
Oct 4, 2023
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
57 tasks
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.78-0 🚀
|
1 task
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀
|
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.79-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #16271
PROPOSAL: #16271 (comment)
Tests / QA Steps
Login to App and test FAB, and sidebar
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-09-20.at.4.49.09.PM.mov
Mobile Web - Chrome
Screen.Recording.2023-09-20.at.4.54.49.PM.mov
Mobile Web - Safari
Screen.Recording.2023-09-20.at.5.00.00.PM.mov
Desktop
Screen.Recording.2023-09-20.at.5.04.24.PM.mov
iOS
Screen.Recording.2023-09-20.at.4.40.38.PM.mov
Android