fix message in LHN when scanning #28244

DylanDylann · 2023-09-26T09:45:53Z

Details

The subtitle in LHN display wrong message when requesting message by scanning

Fixed Issues

$ #27697
PROPOSAL: #27697 (comment)

Tests

Go to any chat
Clicking + button > Request Money > Scan
Upload receipt and request
See that in the LHN: Verify that the message is "Receipt scan in progress…"

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat
Clicking + button > Request Money > Scan
Upload receipt and request
See that in the LHN: Verify that the message is "Receipt scan in progress…"

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mp4

Mobile Web - Safari

safari.mp4

Desktop

desktop.mov

iOS

ios.mov

Android

Screen.Recording.2023-09-26.at.18.15.00.mov

melvin-bot · 2023-09-26T12:27:07Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-09-27T08:11:53Z

@DylanDylann

Go to any chat

I don't think that a workspace chat is fine here, for example

DylanDylann · 2023-09-27T08:13:53Z

@cubuspl42 Why do you think that? because this bug can reproduce in all chats that can request money (not only ws chat)

cubuspl42 · 2023-09-27T08:18:40Z

@DylanDylann You're probably right; let's forget about that.

I have a problem reproducing the fix in general:

receipt-message-issue-1.mp4

This is on your branch + merged main

DylanDylann · 2023-09-27T08:21:35Z

@cubuspl42 Thanks, I am going to investigate now. But It's seem another bug

DylanDylann · 2023-09-28T08:05:17Z

@cubuspl42 I just updated to fix this case. But It is another bug with another RCA, solution even though it also happens when we request money by the amount (manual request). The RCA is that we don't reset lastMessageTranslationKey when calling requestMoney API

cubuspl42 · 2023-09-28T08:20:28Z

@DylanDylann So what you're saying is that we were unlucky and another bug got into main in the meantime, and for that reason your solution seemed to stop working after we merged main, right?

DylanDylann · 2023-09-28T08:22:35Z

Yes, It is my meaning. But I updated to fix that bug

src/libs/ReportUtils.js

cubuspl42 · 2023-09-28T08:36:46Z

Uncaught TypeError: reportAction.childLastReceiptTransactionIDs is undefined
    getReportPreviewMessage ReportUtils.js:1488
    getLastMessageTextForReport OptionsListUtils.js:395
    getOptionData SidebarUtils.js:314
    optionItem OptionRowLHNData.js:96
    React 3
    OptionRowLHNData OptionRowLHNData.js:94
    React 16
    setWithOnyxState web.development.js:2641
    sendDataToConnection web.development.js:794
    connect web.development.js:902
    promise callback*connect web.development.js:889
    connectMappingToOnyx web.development.js:2714
    componentDidMount web.development.js:2560
    each Underscore
    componentDidMount web.development.js:2559
    React 12
    _updateCellsToRender index.js:435
    _taskHandle index.js:77
    handle index.js:25
    requestIdleCallback handler*runAfterInteractions/promise< index.js:23
    runAfterInteractions index.js:22
    timeoutHandle index.js:73
    setTimeout handler*schedule index.js:72
    _scheduleCellsToRenderUpdate index.js:1416
    componentDidUpdate index.js:1163
    React 12
    _updateCellsToRender index.js:435
    _taskHandle index.js:77
    handle index.js:25
    requestIdleCallback handler*runAfterInteractions/promise< index.js:23
    runAfterInteractions index.js:22
    timeoutHandle index.js:73
    setTimeout handler*schedule index.js:72
    _scheduleCellsToRenderUpdate index.js:1416
    componentDidUpdate index.js:1163
    React 6
ReportUtils.js:1488

DylanDylann · 2023-09-28T08:40:43Z

@cubuspl42 how you can reproduce this bug? I can't reproduce it

DylanDylann · 2023-09-28T08:43:38Z

Oh, I can reproduce it now

DylanDylann · 2023-09-28T09:57:23Z

@cubuspl42 The bug we got is because I am using childLastReceiptTransactionIDs to get the last transaction. It is incorrect because it only be last receipt transaction not the last transaction. So I updated the code to get last money report action of the IOU report and then using it to get last transaction of IOU report

src/libs/actions/IOU.js

cubuspl42 · 2023-09-28T10:32:25Z

Is this behavior expected? It looks buggy, as if something goes wrong...

receips-scan-issues-1.mp4

Also, in console:

Warning: Failed prop type: Invalid prop `transaction.comment` of type `string` supplied to `MoneyRequestPreview`, expected `object`.
MoneyRequestPreview@webpack-internal:///./src/components/ReportActionItem/MoneyRequestPreview.js:168:101
withOnyx@webpack-internal:///./node_modules/react-native-onyx/dist/web.development.js:2500:9
withLocalize(Component)
MoneyRequestAction@webpack-internal:///./src/components/ReportActionItem/MoneyRequestAction.js:101:16
withNetwork(MoneyRequestAction)
withOnyx@webpack-internal:///./node_modules/react-native-onyx/dist/web.development.js:2500:9
div
View<@webpack-internal:///./node_modules/@expensify/react-native-web/dist/exports/View/index.js:52:19
div
View<@webpack-internal:///./node_modules/@expensify/react-native-web/dist/exports/View/index.js:52:19
div
View<@webpack-internal:///./node_modules/@expensify/react-native-web/dist/exports/View/index.js:52:19
ReportActionItemSingle@webpack-internal:///./src/pages/home/report/ReportActionItemSingle.js:121:24

Sounds worryingly related to what we do here

DylanDylann · 2023-09-28T10:35:15Z

@cubuspl42

Your video is expected.
About console, I don't think it relates to this PR

cubuspl42 · 2023-09-28T10:38:34Z

Your video is expected

I upload a receipt
The chat summary goes from "cubuspl42.1+3... owes..." to "Scanning the receipt..." to "cubuspl42.1+3... owes..." and again to "Scanning the receipt..."
Out of the blue, this appears, and it wasn't there before:

DylanDylann · 2023-09-29T03:33:14Z

@cubuspl42 I try to reproduce your bug but I can't. Could you try again?

Screen-Recording-2023-09-29-at-10.31.35.mp4

cubuspl42 · 2023-09-29T09:11:23Z

Out of the blue, this appears, and it wasn't there before

I believe that this is an unrelated thing, but this part...

The chat summary goes from "cubuspl42.1+3... owes..." to "Scanning the receipt..." to "cubuspl42.1+3... owes..." and again to "Scanning the receipt..."

...might be related to our PR.

I'll test again.

cubuspl42 · 2023-09-29T09:29:37Z

@DylanDylann I can't reproduce it with the last main merged-in. Maybe it was something unrelated, or a backend glitch.

cubuspl42 · 2023-09-29T09:32:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

receipt-summary-web.mp4

Mobile Web - Chrome

receipt-summary-android-web-compressed.mp4

Mobile Web - Safari

receipt-summary-ios-web.mp4

Desktop

iOS

receipt-summary-ios.mp4

Android

receipt-summary-android-compressed.mp4

DylanDylann · 2023-10-02T04:37:50Z

@tylerkaraszewski Gentle bump, please help to review this PR when you have a chance

DylanDylann · 2023-10-04T02:51:26Z

@tylerkaraszewski Friendly bump, Please check if you are available

OSBotify · 2023-10-04T17:05:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-05T00:38:30Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T07:53:27Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T08:25:39Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:34:13Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:43:06Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:19:00Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix message in LHN when scanning

0f2a90b

DylanDylann marked this pull request as ready for review September 26, 2023 12:27

DylanDylann requested a review from a team as a code owner September 26, 2023 12:27

melvin-bot bot requested review from cubuspl42 and removed request for a team September 26, 2023 12:27

DylanDylann added 7 commits September 27, 2023 15:49

merge main

70216cd

fix: add condition in get report preview message

ee92b09

fix: lint

241cd41

fix lint

35a91da

fix case there are many request

bf3eef6

fix: update last message translation key when call request money api

1175311

Merge branch 'main' into fix/27697

9163111

cubuspl42 reviewed Sep 28, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

DylanDylann added 2 commits September 28, 2023 16:39

pass iouReportAction if last message is REPORTPREVIEW

9e57296

pass MoneyReportAction if last message is REPORTPREVIEW

2e7bde2

cubuspl42 reviewed Sep 28, 2023

View reviewed changes

src/libs/actions/IOU.js Show resolved Hide resolved

fix line

f1b58ee

cubuspl42 approved these changes Sep 29, 2023

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski September 29, 2023 09:33

tylerkaraszewski approved these changes Oct 4, 2023

View reviewed changes

tylerkaraszewski merged commit 1663440 into Expensify:main Oct 4, 2023
12 of 13 checks passed

OSBotify mentioned this pull request Oct 5, 2023

Deploy Checklist: New Expensify 2023-10-05 #28883

Closed

57 tasks

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

melvin-bot bot mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-10-13] [$500] The subtitle in LHN display wrong message when requesting message by scanning #27697

Closed

6 tasks

tobyjsullivan mentioned this pull request Feb 26, 2024

Fix: IOU description can't be seen on the LHN reports #34840

Merged

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix message in LHN when scanning #28244

fix message in LHN when scanning #28244

DylanDylann commented Sep 26, 2023 •

edited

Loading

melvin-bot bot commented Sep 26, 2023

cubuspl42 commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

cubuspl42 commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

DylanDylann commented Sep 28, 2023 •

edited

Loading

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 28, 2023

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 28, 2023

DylanDylann commented Sep 28, 2023

DylanDylann commented Sep 28, 2023 •

edited

Loading

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 28, 2023 •

edited

Loading

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 29, 2023

cubuspl42 commented Sep 29, 2023

cubuspl42 commented Sep 29, 2023

cubuspl42 commented Sep 29, 2023

DylanDylann commented Oct 2, 2023

DylanDylann commented Oct 4, 2023

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

fix message in LHN when scanning #28244

fix message in LHN when scanning #28244

Conversation

DylanDylann commented Sep 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 26, 2023

cubuspl42 commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

cubuspl42 commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

DylanDylann commented Sep 28, 2023 • edited Loading

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 28, 2023

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 28, 2023

DylanDylann commented Sep 28, 2023

DylanDylann commented Sep 28, 2023 • edited Loading

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 28, 2023 • edited Loading

cubuspl42 commented Sep 28, 2023

DylanDylann commented Sep 29, 2023

cubuspl42 commented Sep 29, 2023

cubuspl42 commented Sep 29, 2023

cubuspl42 commented Sep 29, 2023

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Oct 2, 2023

DylanDylann commented Oct 4, 2023

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

DylanDylann commented Sep 26, 2023 •

edited

Loading

DylanDylann commented Sep 28, 2023 •

edited

Loading

DylanDylann commented Sep 28, 2023 •

edited

Loading

DylanDylann commented Sep 28, 2023 •

edited

Loading