Fix input lost focus when entering on no result found #28459

dukenv0307 · 2023-09-29T10:18:59Z

Details

When the search has no result and the user uses the enter key, we should keep the input is focused

Fixed Issues

$ #28072
PROPOSAL: #28072 (comment)

Tests

Go to Settings > Workspaces
Select any workspace and open the member page
Click on the invite button
Enter the random input that will display no result found
Press the enter key
Verify that the input keeps focusing
Open emoji picker and do the same thing
Verify that the result is the same with step 6

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Settings > Workspaces
Select any workspace and open the member page
Click on the invite button
Enter the random input that will display no result found
Press the enter key
Verify that the input keeps focusing
Open the emoji picker and do the same thing
Verify that the result is the same with step 6

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-29.at.16.49.08.mov

Mobile Web - Chrome

Record_2023-09-29-16-51-49.mp4

Mobile Web - Safari

Screen.Recording.2023-09-29.at.16.55.02.mov

Desktop

Screen.Recording.2023-09-29.at.17.34.22.mov

iOS

Screen.Recording.2023-09-29.at.17.22.44.mov

Android

Screen.Recording.2023-09-29.at.17.28.32.mp4

melvin-bot · 2023-10-02T09:36:37Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiros · 2023-10-02T19:41:14Z

src/components/EmojiPicker/EmojiPickerMenu/index.js

@@ -515,6 +516,7 @@ class EmojiPickerMenu extends Component {
                        onFocus={() => this.setState({isFocused: true, highlightedIndex: -1, isUsingKeyboardMovement: false})}
                        onBlur={() => this.setState({isFocused: false})}
                        autoCorrect={false}
+                        blurOnSubmit={this.state.searchTerm.length > 0 && this.state.filteredEmojis.length > 0}


Any reason to prevent blur when no input?
OptionsList, SelectionList (after fix) still blurs when search text is empty.

@0xmiroslav Just prevent blurring this input when submitting if no result found

Do you think we don't need to check searchTerm, when searchTerm is empty the list will not empty.

I think it's better UX to keep focus in that case.
Actually emoji search and selection list are different.
In selection list, both input and result are focused so when press Enter key while showing result, it triggers selected item.
But in emoji search, both cannot be focused together.

So what should we do in emoji picker?

your current change looks good to me

So that means I don't need to update any thing else, right?

Weird behavior on mSafari

msafari.mov

Confirmed this happens on main

0xmiros · 2023-10-03T19:22:24Z

src/components/EmojiPicker/EmojiPickerMenu/index.js

@@ -402,7 +403,7 @@ class EmojiPickerMenu extends Component {
        const newFilteredEmojiList = EmojiUtils.suggestEmojis(`:${normalizedSearchTerm}`, this.props.preferredLocale, this.emojis.length);

        // Remove sticky header indices. There are no headers while searching and we don't want to make emojis sticky
-        this.setState({filteredEmojis: newFilteredEmojiList, headerIndices: [], highlightedIndex: 0});
+        this.setState({filteredEmojis: newFilteredEmojiList, headerIndices: [], highlightedIndex: 0, searchTerm});


Also add searchTerm here - https://github.com/Expensify/App/pull/28459/files#diff-67118ceda8cb66e4c6e8367afc02904c8a06f92ac5cb6e9e0a52a0c26433695fR395-R399

@0xmiroslav Updated. Do you think we also should add blurOnSubmit to index.native.js?

For consistency, let's remove searchTerm logic and only check filteredEmojis.length on both web and native.
Do you agree?

That makes sense to me.

@0xmiroslav I updated.

0xmiros · 2023-10-04T05:22:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

OSBotify · 2023-10-04T06:06:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-05T00:39:27Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T07:54:24Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T08:26:39Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:35:13Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:44:06Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:20:00Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 2 commits September 27, 2023 11:38

fix input lost focus when entering on not found result

5eca533

Merge branch 'main' into fix/28072

dde4e81

dukenv0307 marked this pull request as ready for review October 2, 2023 09:36

dukenv0307 requested a review from a team as a code owner October 2, 2023 09:36

melvin-bot bot requested review from 0xmiros and removed request for a team October 2, 2023 09:36

0xmiros reviewed Oct 2, 2023

View reviewed changes

0xmiros reviewed Oct 3, 2023

View reviewed changes

dukenv0307 added 2 commits October 4, 2023 11:20

add state

6a1314f

refactor logic

4b8fc0a

0xmiros approved these changes Oct 4, 2023

View reviewed changes

melvin-bot bot requested a review from nkuoch October 4, 2023 05:23

nkuoch approved these changes Oct 4, 2023

View reviewed changes

nkuoch merged commit 33b17c4 into Expensify:main Oct 4, 2023
14 of 15 checks passed

OSBotify mentioned this pull request Oct 5, 2023

Deploy Checklist: New Expensify 2023-10-05 #28883

Closed

57 tasks

melvin-bot bot mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-10-13] [$500] Web - The input is lost focus on pressing enter key after no result found #28072

Closed

6 tasks

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix input lost focus when entering on no result found #28459

Fix input lost focus when entering on no result found #28459

dukenv0307 commented Sep 29, 2023 •

edited

Loading

melvin-bot bot commented Oct 2, 2023

0xmiros Oct 2, 2023 •

edited

Loading

dukenv0307 Oct 3, 2023

dukenv0307 Oct 3, 2023

0xmiros Oct 3, 2023

dukenv0307 Oct 3, 2023

0xmiros Oct 3, 2023

dukenv0307 Oct 3, 2023

0xmiros Oct 3, 2023

0xmiros Oct 3, 2023

0xmiros Oct 3, 2023

dukenv0307 Oct 4, 2023

0xmiros Oct 4, 2023

dukenv0307 Oct 4, 2023

dukenv0307 Oct 4, 2023

0xmiros commented Oct 4, 2023

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

Fix input lost focus when entering on no result found #28459

Fix input lost focus when entering on no result found #28459

Conversation

dukenv0307 commented Sep 29, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 2, 2023

0xmiros Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmiros commented Oct 4, 2023

Reviewer Checklist

Screenshots/Videos

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

dukenv0307 commented Sep 29, 2023 •

edited

Loading

0xmiros Oct 2, 2023 •

edited

Loading