Add new blocking view for new room page #30051

dukenv0307 · 2023-10-20T04:43:17Z

Details

Add new blocking view for new room page

Fixed Issues

$ #27995
PROPOSAL: #27995 (comment)

Tests

Login with a new account that doesn't contain any workspace
Click on FAB > Start chat > Room
Verify that NotFoundPage appears with a button in the footer
Click on Learn more button
Verify that we navigate to the workspace page

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Login with a new account that doesn't contain any workspace
Click on FAB > Start chat > Room
Verify that NotFoundPage appears with a button in the footer
Click on Learn more button
Verify that we navigate to the workspace page

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-20.at.11.31.03.mov

Android: mWeb Chrome

Screen.Recording.2023-10-20.at.11.19.11.mov

iOS: Native

Screen.Recording.2023-10-20.at.11.24.25.mov

iOS: mWeb Safari

Screen.Recording.2023-10-20.at.11.21.05.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-20.at.11.16.29.mov

MacOS: Desktop

Screen.Recording.2023-10-20.at.11.35.43.mov

melvin-bot · 2023-10-20T04:43:35Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-10-23T10:10:02Z

src/libs/Permissions.ts

@@ -2,6 +2,7 @@ import CONST from '../CONST';
 import Beta from '../types/onyx/Beta';

 function canUseAllBetas(betas: Beta[]): boolean {
+    return true;


please revert this commit

hoangzinh · 2023-10-23T10:52:01Z

src/pages/workspace/WorkspaceNewRoomPage.js

            linkKey="workspace.emptyWorkspace.title"
            onLinkPress={() => App.createWorkspaceAndNavigateToIt('', false, '', false, false)}


I think with our change, we should revert those changes from the previous PR #27983. It doesn't make sense when we don't have permission to use policy room, but the helper text is creating workspaces

hoangzinh · 2023-10-23T10:53:13Z

I found a bug when I tested offline on small screen devices. There are 2 "offline text" in the screen

dukenv0307 · 2023-10-24T05:50:58Z

I found a bug when I tested offline on small screen devices. There are 2 "offline text" in the screen

@hoangzinh The root cause is NewChatSelectorPage already has ScreenWrapper but we also added ScreenWrapper in NewChatPage and WorkspaceNewRoomPage.

We have two solution to fix this

Remove ScreenWrapper in NewChatPage and WorkspaceNewRoomPage
Add prop shouldShowOfflineIndicator as false in two pages.

hoangzinh · 2023-10-25T17:11:02Z

@dukenv0307 I prefer we should remove duplicated (option 1). What do you think?

dukenv0307 · 2023-10-26T08:36:22Z

@hoangzinh We are using safeAreaPaddingBottomStyle and insets from ScreenWrapper so I think the second solution is better.

hoangzinh · 2023-10-26T16:22:20Z

@dukenv0307 hmm I think we're good to go with option 2.

dukenv0307 · 2023-10-26T16:45:45Z

@hoangzinh Already updated with option 2 and resolved conflict.

hoangzinh · 2023-10-26T17:14:25Z

Thanks @dukenv0307, I asked on Slack to speed up the comment here #27995 (comment)

bfitzexpensify · 2023-12-05T13:43:05Z

OK, looks like we have the updated copy, so we should be able to push this forward fairly quickly now?

dukenv0307 · 2023-12-05T13:49:58Z

Updating now.

dukenv0307 · 2023-12-05T14:08:38Z

@hoangzinh Updated. Please help to review again.

hoangzinh · 2023-12-05T15:35:20Z

@dukenv0307 have you confirmed the copy text in Spain yet?

dukenv0307 · 2023-12-08T04:23:41Z

@hoangzinh The translation is confirmed.

hoangzinh · 2023-12-08T12:49:09Z

src/pages/workspace/WorkspaceNewRoomPage.js

-                            onSubmit={submit}
-                            enabledWhenOffline
+                {({insets}) =>
+                    workspaceOptions.length ? (


It looks hard to read code. Because the children of <KeyboardAvoidingView are long, we have to scroll back and forth to read the empty view logic and main logic.

Do you have any idea to make it more readable? Thanks

@hoangzinh Updated.

Why didn't we do the reverse? Lift the empty view out (because I think it's a sub/edge case view), and arrange the code to something like this:

isEmpty(workspaceOptions) ? renderEmptyWorkspace() : ...

what do you think?

@hoangzinh Do you think about lifting both views out?

It's up to you, but I think it's not necessary.

hoangzinh · 2023-12-12T13:26:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-12-13.at.22.00.33.-.web.mov

MacOS: Desktop

hoangzinh · 2023-12-12T15:34:03Z

App crashes when starting a new chat.

dukenv0307 · 2023-12-13T08:27:45Z

@hoangzinh Updated.

hoangzinh · 2023-12-13T11:26:29Z

src/pages/workspace/WorkspaceNewRoomPage.js

-                            enabledWhenOffline
+                {({insets}) =>
+                    workspaceOptions.length === 0 ? (
+                        <>{emptyWorkspaceView}</>


this syntax is weird. Can we make emptyWorkspaceView as a function and call it here intead?

@hoangzinh Updated.

techievivek

Looks good.

OSBotify · 2023-12-14T09:56:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-14T16:05:22Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T16:45:10Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shawnborton · 2023-12-18T13:34:15Z

Hmm it looks like the screenshots here don't match what was provided by @Expensify/design

Can we follow up ASAP and get the correct illustration in here?

@dukenv0307 any idea what happened there?

OSBotify · 2023-12-19T02:01:28Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add new blocking view for new room page

eab7290

dukenv0307 marked this pull request as ready for review October 20, 2023 04:43

dukenv0307 requested a review from a team as a code owner October 20, 2023 04:43

melvin-bot bot requested review from hoangzinh and removed request for a team October 20, 2023 04:43

fix lint

299a60c

hoangzinh reviewed Oct 23, 2023

View reviewed changes

dukenv0307 added 3 commits October 24, 2023 13:00

revert hard code

5e4f72e

Merge branch 'main' into fix/27995

dba11e8

fix lint

d1e23ef

merge main

f633aa2

dukenv0307 added 5 commits October 30, 2023 14:35

merge main

587a390

fix lint

70fec0f

Merge branch 'main' into fix/27995

dac71e2

merge main

b5014c7

fix lint

6af325a

merge main

4590ea0

Merge branch 'main' into fix/27995

fd71189

hoangzinh reviewed Dec 8, 2023

View reviewed changes

dukenv0307 added 4 commits December 11, 2023 15:59

Merge branch 'main' into fix/27995

388b7d1

refactor component

452a6e8

Merge branch 'main' into fix/27995

399635f

reverse view

133f9d2

Merge branch 'main' into fix/27995

ee544d8

hoangzinh mentioned this pull request Dec 13, 2023

[HOLD for payment 2024-01-09] [HOLD for payment 2023-12-26] HIGH: [$500] Show workspace interstitial when trying to create a room with no workspace #27995

Closed

6 tasks

dukenv0307 added 2 commits December 13, 2023 15:25

fix crashes app

1c63ef7

merge main

dad8c0c

hoangzinh reviewed Dec 13, 2023

View reviewed changes

dukenv0307 added 2 commits December 13, 2023 21:38

Merge branch 'main' into fix/27995

5573367

refactor empty view variable

1f0e812

hoangzinh approved these changes Dec 13, 2023

View reviewed changes

melvin-bot bot requested a review from techievivek December 13, 2023 16:41

techievivek approved these changes Dec 14, 2023

View reviewed changes

techievivek merged commit 5c0f3e4 into Expensify:main Dec 14, 2023
16 of 17 checks passed

github-actions bot mentioned this pull request Dec 14, 2023

Deploy Checklist: New Expensify 2023-12-14 #33072

Closed

77 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new blocking view for new room page #30051

Add new blocking view for new room page #30051

dukenv0307 commented Oct 20, 2023 •

edited by github-actions bot

Loading

melvin-bot bot commented Oct 20, 2023

hoangzinh Oct 23, 2023

hoangzinh Oct 23, 2023

hoangzinh commented Oct 23, 2023

dukenv0307 commented Oct 24, 2023

hoangzinh commented Oct 25, 2023

dukenv0307 commented Oct 26, 2023

hoangzinh commented Oct 26, 2023

dukenv0307 commented Oct 26, 2023

hoangzinh commented Oct 26, 2023

bfitzexpensify commented Dec 5, 2023

dukenv0307 commented Dec 5, 2023

dukenv0307 commented Dec 5, 2023

hoangzinh commented Dec 5, 2023

dukenv0307 commented Dec 8, 2023

hoangzinh Dec 8, 2023

dukenv0307 Dec 11, 2023

hoangzinh Dec 11, 2023

dukenv0307 Dec 11, 2023 •

edited

Loading

hoangzinh Dec 11, 2023

hoangzinh commented Dec 12, 2023 •

edited

Loading

hoangzinh commented Dec 12, 2023

dukenv0307 commented Dec 13, 2023

hoangzinh Dec 13, 2023

dukenv0307 Dec 13, 2023

techievivek left a comment

OSBotify commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 14, 2023

shawnborton commented Dec 18, 2023

OSBotify commented Dec 19, 2023

		linkKey="workspace.emptyWorkspace.title"
		onLinkPress={() => App.createWorkspaceAndNavigateToIt('', false, '', false, false)}

Add new blocking view for new room page #30051

Add new blocking view for new room page #30051

Conversation

dukenv0307 commented Oct 20, 2023 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Oct 23, 2023

dukenv0307 commented Oct 24, 2023

hoangzinh commented Oct 25, 2023

dukenv0307 commented Oct 26, 2023

hoangzinh commented Oct 26, 2023

dukenv0307 commented Oct 26, 2023

hoangzinh commented Oct 26, 2023

bfitzexpensify commented Dec 5, 2023

dukenv0307 commented Dec 5, 2023

dukenv0307 commented Dec 5, 2023

hoangzinh commented Dec 5, 2023

dukenv0307 commented Dec 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dukenv0307 Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Dec 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Dec 12, 2023

dukenv0307 commented Dec 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

techievivek left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 14, 2023

shawnborton commented Dec 18, 2023

OSBotify commented Dec 19, 2023

dukenv0307 commented Oct 20, 2023 •

edited by github-actions bot

Loading

dukenv0307 Dec 11, 2023 •

edited

Loading

hoangzinh commented Dec 12, 2023 •

edited

Loading