Fix - mWeb/Safari- Chat - After tapping on "Copy to clipboard", options menu does not close #28820

[AmjedNazzal]

Details

We are adding a check for anchorNode and focusNode not being null before using setBaseAndExtent since it no longer accepts null as per changes in WebKit source code

Fixed Issues

$ #28820
PROPOSAL: #28820 (comment)

Tests

1. Open the app in either MacOS Safari v17 and above or Safari on iPhone 15 and above
2. Go to any chat and right click/Long press on a chat message to view the context menu
3. Click/Press on Copy to clipboard
4. Confirm that the context menu closes

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

1. Open the app in either MacOS Safari v17 and above or Safari on iPhone 15 and above
2. Go to any chat and right click/Long press on a chat message to view the context menu
3. Click/Press on Copy to clipboard
4. Confirm that the context menu closes

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

copytoclipboard-android-native.mp4

Android: mWeb Chrome

copytoclipboard-mweb-chrome.mp4

iOS: Native

copytoclipboard-ios-native.mov

iOS: mWeb Safari

copytoclipboard-mweb-safari17.mov

MacOS: Chrome / Safari

copytoclipboard-web-safari.mov

MacOS: Desktop

copytoclipboard-macos-desktop.mov

[melvin-bot]

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[cubuspl42]

@AmjedNazzal While Expensify doesn't have a strict policy on commit message content, and it's a known situation that many quickly typed commit messages land in the repo, I think this one is too much:

Issue28820

Please make it something like "Fix issue #28820" and force-push

[cubuspl42]

On Android/Chrome, are you able to paste the copied message successfully?

[AmjedNazzal]

@cubuspl42 Ops, apologies for that, I even noticed I hadn't made the title of the PR proper so I've edited that, now about chrome/android, thank you for bringing that up because I hadn't noticed but it seem like I can't paste copied messages but it's not related to this PR, I've tried with a new clone of the app that has nothing related to this PR and I can't paste the copied message in android/chrome even though the local app I'm testing on doesn't have my changes in it, interestingly it works on staging so I'm wondering if there is a recent PR that hasn't gone to staging yet that is causing this as a regression, I'm going to look into this

[cubuspl42]

I also noticed that this is not likely related to this PR. Still, as we're changing essentially the same functionality, we should ensure that it's working after our changes (unless we're in an extreme hurry, etc.).

So I would say we should classify why the functionality is not fully working on Android/Chrome and hold on the relevant issue/PR.

[cubuspl42]

• On my iPhone 15 / iOS 17 emulator I still don't reproduce the issue
• On my Mac, I do reproduce the issue

On physical iPhone 13 mini / iOS 17, though, I have the following problem both on main on and on your feature branch:

RPReplay_Final1698066244-compressed.mp4

The app blinks and the copying is not effective (the clipboard content is as it was before).

[AmjedNazzal]

@cubuspl42 I had a look around in all recent PRs and I couldn't find anything that has been merged but not deployed to staging yet that could be causing the android/chrome issue, I then checked why this is happening and what I managed to find out is that when running the app locally and browsing it from an android phone on chrome, it seem like whenever we try to call clipboard.write it throws an issue that it doesn't exist, I've done some logs and it seems like clipboard.write is not being exposed in navigation object at all, I'm suspecting this has to do with a permission issue as android phones connecting to.a locally run app will have a website not secure warning and maybe that's why it works on staging but not on local build, I don't have a way to absoloutely confirm that yet but I tried emulating a samsung phone on a cloud service and using a tunnel to access localhost and as you see in the video below it did work on that

emulated-check.mov

When it comes to not being able to reproduce on iPhone 15, on my end without my changes I can reproduce the issue on iphone 15 as the video below shows

issueOniPhone15.mov

When it comes to the physical iPhone 13 mini, unfortunately I don't have access to a physical iPhone, I tested on imulated 13 mini with iOS 17 and I couldn't see blinking, all I could see is that without my changes, the original issue happened and with my changes it behaved fine as I will show in two recordings, one with the original main and one after the change

iphone13miniWithissue.mov

iphone13miniFixed.mov

You said you get the blinking issue on your physical iPhone, do you get it in staging too or only on local builds?

[AmjedNazzal]

I found a stack discussion about the android chrome thing:

https://stackoverflow.com/questions/51805395/navigator-clipboard-is-undefined

Since when we try to access local build we use something like 192,168.1.100:8082 the browser will see it as not a secure origin since it's neither HTTPS nor localhost, hence why it worked when I tunneled into localhost using the emulator

[cubuspl42]

I had issues related to permissions & HTTP before, I'll try tunneling.

[AmjedNazzal]

I tried tunneling using ngrok with ngrok http --host-header=rewrite 8082 and it gave me a secure https connection to the local build so I tried it from my physical android phone and the paste now works fine, maybe that could resolve the iPhone mini issue as well

[cubuspl42]

I'm getting 429 during sign-in when I use ngrok or stunel. I asked on Slack.

[AmjedNazzal]

@cubuspl42 what is your setup like? can you share some more information?

What I do is configure authtoken with ngrok config add-authtoken <token> and just run ngrok http --host-header=rewrite 8082 to bypass CORS kind of issues and it works

[AmjedNazzal]

@cubuspl42 any updates?

[cubuspl42]

I'll try testing with the new HTTPS setup as recommended on Slack

[cubuspl42]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

fix-safari-copy-web.mp4

Mobile Web - Chrome

fix-safari-copy-android-web-compressed.mp4

Mobile Web - Safari

fix-safari-copy-ios-web.mp4

Desktop

fix-safari-copy-desktop.mp4

iOS

fix-safari-copy-ios.mp4

Android

fix-safari-copy-android-compressed.mp4

[AmjedNazzal]

@tgolen Done!

[cubuspl42]

If we are to add a comment, I think we should focus on:

• why these values can become null in practice
• that null values are disallowed by this API per the standard

The fact that Safari actually started enforcing that is the least important matter and the comment might get outdated once other implementors start enforcing these null-checks

[AmjedNazzal]

I've added some further explanation

[AmjedNazzal]

@cubuspl42 is it better now?

[cubuspl42]

@AmjedNazzal Yes, thank you

[cubuspl42]

@tgolen Any more thoughts, or are we good to move forward?

[tgolen]

Looks really good, thanks for that comment 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅