Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - mWeb/Safari- Chat - After tapping on "Copy to clipboard", options menu does not close #28820 #30085

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Fix - mWeb/Safari- Chat - After tapping on "Copy to clipboard", options menu does not close #28820 #30085

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d79894
Issue28820
AmjedNazzal Oct 20, 2023
f81b511
Merge branch 'Expensify:main' into Issue28820
AmjedNazzal Oct 23, 2023
771be44
Merge branch 'Expensify:main' into Issue28820
AmjedNazzal Oct 26, 2023
7e54a42
Fix issue #28820
AmjedNazzal Oct 26, 2023
0246e29
Fix issue #28820
AmjedNazzal Oct 26, 2023
6295b06
Merge branch 'Expensify:main' into Issue28820
AmjedNazzal Oct 27, 2023
3a43d13
Fix issue #Issue28820 - adding comment
AmjedNazzal Oct 27, 2023
90f1631
Fix issue #Issue28820 - editing comment
AmjedNazzal Oct 30, 2023
82bf64e
Fix issue #Issue28820 - Small change
AmjedNazzal Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libs/Clipboard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ function setHTMLSync(html, text) {

if (isComposer) {
firstAnchorChild.setSelectionRange(originalSelection.start, originalSelection.end, originalSelection.direction);
} else {
} else if (originalSelection.anchorNode && originalSelection.focusNode) {
AmjedNazzal marked this conversation as resolved.
Show resolved Hide resolved
// We are adding a check for anchorNode and focusNode to prevent null values from being passed to setBaseAndExtent as per recent changes in Safari
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are to add a comment, I think we should focus on:

  • why these values can become null in practice
  • that null values are disallowed by this API per the standard

The fact that Safari actually started enforcing that is the least important matter and the comment might get outdated once other implementors start enforcing these null-checks

selection.setBaseAndExtent(originalSelection.anchorNode, originalSelection.anchorOffset, originalSelection.focusNode, originalSelection.focusOffset);
}

Expand Down
Loading