Hide notifications@expensify.com from basically everywhere #32361

Gonals · 2023-12-01T15:45:39Z

Details

Fixed Issues

$ #32340
PROPOSAL:

Tests

Create an account with notifications@expensify.com as login.
In your .env file, add this line: EXPENSIFY_ACCOUNT_ID_NOTIFICATIONS=XXX, where XXX is the account ID of the notifications@expensify.com account.

You are ready to test!

Log into another @expensify.com account and try to start a new chat. Confirm you can't find notifications@expensify.com.
Log into notifications@expensify.com and start a chat with another account (Account B) (not a big deal, since this should never happen in real life)
Log into Account B and confirm you DON'T see the chat in the LHN.
Remove this line
You should now see the chat in the LHN. Open it and hover over the notifications@expensify.com name in the chat message. You should see an X and not be able to open the profile

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Log into a XXX@expensify.com account.
Try to start a chat. Confirm you can't find notifications@expensify.com
Request money from another account by uploading a non-legible receipt (a random pic).
Wait for smartscan to finish. It should fail.
Under the Money request, you should see a message like this:

Confirm that you can't open a chat with Expensify, nor open their profile by clicking the name

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Not much to show, since what happens it that the account doesn't show up 🤷

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-01T15:45:45Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2023-12-04T10:26:58Z

src/libs/ReportUtils.ts

@@ -3424,6 +3424,8 @@ function shouldReportBeInOptionList(
        report?.reportName === undefined ||
        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
        report?.isHidden ||
+        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+        report?.participantAccountIDs?.includes(CONST.ACCOUNT_ID.NOTIFICATIONS) ||


not a blocker, just a small suggestion. In the future, if we frequently use || in conditions, we can also modify the option ignoreConditionalTests

'@typescript-eslint/prefer-nullish-coalescing': [ 'error', { ignoreConditionalTests: true, } ],

https://typescript-eslint.io/rules/prefer-nullish-coalescing#ignoreconditionaltests

ntdiary · 2023-12-04T10:27:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

32361-android-app.mp4

Android: mWeb Chrome

32361-android-chrome.mp4

iOS: Native

32361-ios-app.mp4

iOS: mWeb Safari

32361-ios-safari.mp4

MacOS: Chrome / Safari

32361-web.mp4

MacOS: Desktop

32361-desktop.mp4

ntdiary

LGTM. Btw, just a tiny question, not quite sure if we also need to disable Reply in thread. :)

melvin-bot · 2023-12-04T10:54:46Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Gonals · 2023-12-04T12:35:15Z

LGTM. Btw, just a tiny question, not quite sure if we also need to disable Reply in thread. :)

I think that's fine, as they could start a thread there to discuss the failure with the admin or something 🤷

srikarparsi

lgtm

OSBotify · 2023-12-05T00:41:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-05T02:57:14Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-05T13:42:19Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:32:27Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:41:59Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fedirjh · 2024-02-26T22:07:02Z

Coming from #32500, we should have disabled the navigation to notifications@expensify.com profile.

Gonals added 5 commits December 1, 2023 15:07

exclude notificatiosn from cht search

cd1204f

exclude from recets

7206bce

exclude from LHN

34971db

prevent profile access

17717f5

remove debug lines

53f10a9

Gonals self-assigned this Dec 1, 2023

Gonals requested a review from a team as a code owner December 1, 2023 15:45

melvin-bot bot requested review from ntdiary and removed request for a team December 1, 2023 15:45

Gonals added 2 commits December 1, 2023 16:51

lint

a12d140

prettier

9379c26

ntdiary reviewed Dec 4, 2023

View reviewed changes

ntdiary approved these changes Dec 4, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi December 4, 2023 10:54

srikarparsi approved these changes Dec 5, 2023

View reviewed changes

srikarparsi merged commit 99ae282 into main Dec 5, 2023
14 of 15 checks passed

srikarparsi deleted the alberto-hideNot branch December 5, 2023 00:38

github-actions bot mentioned this pull request Dec 5, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

Christinadobrzyn mentioned this pull request Dec 6, 2023

[Hold for Payment 12-13] Don't let users chat with notifications@expensify.com #32340

Closed

fedirjh mentioned this pull request Jan 25, 2024

[HOLD for payment 2024-02-26] [$500] [MEDIUM] Smartscan: Thread - You can go to the notifications@expensify.com profile and send a private message #32500

Closed

6 tasks

mountiny mentioned this pull request Jun 10, 2024

Feature/38774 expensify persona #41343

Merged

61 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide notifications@expensify.com from basically everywhere #32361

Hide notifications@expensify.com from basically everywhere #32361

Gonals commented Dec 1, 2023 •

edited

Loading

melvin-bot bot commented Dec 1, 2023

ntdiary Dec 4, 2023

ntdiary commented Dec 4, 2023 •

edited

Loading

ntdiary left a comment

melvin-bot bot commented Dec 4, 2023

Gonals commented Dec 4, 2023

srikarparsi left a comment

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

fedirjh commented Feb 26, 2024

Hide notifications@expensify.com from basically everywhere #32361

Hide notifications@expensify.com from basically everywhere #32361

Conversation

Gonals commented Dec 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 1, 2023

ntdiary Dec 4, 2023

Choose a reason for hiding this comment

ntdiary commented Dec 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

ntdiary left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 4, 2023

Gonals commented Dec 4, 2023

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

fedirjh commented Feb 26, 2024

Gonals commented Dec 1, 2023 •

edited

Loading

ntdiary commented Dec 4, 2023 •

edited

Loading